Changeset 98614 in vbox for trunk/src/VBox/Main/include

Timestamp:

Feb 17, 2023 1:09:38 AM (2 years ago)

Author:

vboxsync

Message:

Main/GuestProcess: Simplified the GuestProcessToolbox::run stuff to sort out the issue VERR_IPE_UNINITIALIZED_STATUS introduced around r155802+. Also decoded the meaning of the GuestCtrlStreamObjects parameters and tried to make that easier to understand for the uninitiated. bugref:9783

File:

• trunk/src/VBox/Main/include/GuestProcessImpl.h (modified) (1 diff)

trunk/src/VBox/Main/include/GuestProcessImpl.h

@@ -269 +269 @@
 
     /** Wrapped @name Static run methods.
-     * @{ */
-    static int run(GuestSession *pGuestSession, const GuestProcessStartupInfo &startupInfo, int *pvrcGuest);
-
-    static int runErrorInfo(GuestSession *pGuestSession, const GuestProcessStartupInfo &startupInfo, GuestProcessToolErrorInfo &errorInfo);
-
-    static int runEx(GuestSession *pGuestSession, const GuestProcessStartupInfo &startupInfo,
-                     GuestCtrlStreamObjects *pStrmOutObjects, uint32_t cStrmOutObjects, int *pvrcGuest);
-
-    static int runExErrorInfo(GuestSession *pGuestSession, const GuestProcessStartupInfo &startupInfo,
-                              GuestCtrlStreamObjects *pStrmOutObjects, uint32_t cStrmOutObjects, GuestProcessToolErrorInfo &errorInfo);
+     * @note Do not call anything 'run' here, it's way too common.
+     * @{ */
+    static int runTool(GuestSession *pGuestSession, const GuestProcessStartupInfo &startupInfo, int *pvrcGuest,
+                       GuestCtrlStreamObjects *pLstStdOutObjPairs = NULL, uint32_t cStdOutObjectsToRead = 1);
+
+    static int runToolWithErrorInfo(GuestSession *pGuestSession, const GuestProcessStartupInfo &startupInfo,
+                                    GuestProcessToolErrorInfo &errorInfo,
+                                    GuestCtrlStreamObjects *pLstStdOutObjPairs = NULL, uint32_t cStdOutObjectsToRead = 1);
     /** @}  */