Changeset 98618 in vbox for trunk/src/VBox/Runtime/r3/win

Timestamp:

Feb 17, 2023 12:40:37 PM (2 years ago)

Author:

vboxsync

Message:

IPRT/pipe-win.cpp: Deal correctly with partial overlapping writes (shouldn't happen).

File:

• trunk/src/VBox/Runtime/r3/win/pipe-win.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/r3/win/pipe-win.cpp

@@ -326 +326 @@
 
                 /* resubmit the remainder of the buffer - can this actually happen? */
-                memmove(&pThis->pbBounceBuf[0], &pThis->pbBounceBuf[cbWritten], pThis->cbBounceBufUsed - cbWritten);
+                pThis->cbBounceBufUsed -= cbWritten;
+                memmove(&pThis->pbBounceBuf[0], &pThis->pbBounceBuf[cbWritten], pThis->cbBounceBufUsed);
                 rc = ResetEvent(pThis->Overlapped.hEvent); Assert(rc == TRUE);
-                if (!WriteFile(pThis->hPipe, pThis->pbBounceBuf, (DWORD)pThis->cbBounceBufUsed,
-                               &cbWritten, &pThis->Overlapped))
-                {
-                    if (GetLastError() == ERROR_IO_PENDING)
+                if (!WriteFile(pThis->hPipe, pThis->pbBounceBuf, (DWORD)pThis->cbBounceBufUsed, &cbWritten, &pThis->Overlapped))
+                {
+                    DWORD const dwErr = GetLastError();
+                    if (dwErr == ERROR_IO_PENDING)
                         rc = VINF_TRY_AGAIN;
                     else
                     {
                         pThis->fIOPending = false;
-                        if (GetLastError() == ERROR_NO_DATA)
+                        if (dwErr == ERROR_NO_DATA)
                             rc = VERR_BROKEN_PIPE;
                         else