Changeset 98661 in vbox for trunk/src/VBox/Devices/VirtIO

Timestamp:

Feb 20, 2023 4:31:14 PM (2 years ago)

Author:

vboxsync

Message:

Devices/DevVirtioSCSI: Possible fix for bugref:9440#c164, the queue head can get out of sync if two threads complete I/O requests concurrently

File:

• trunk/src/VBox/Devices/VirtIO/VirtioCore.cpp (modified) (1 diff)

trunk/src/VBox/Devices/VirtIO/VirtioCore.cpp

@@ -1049 +1049 @@
      * Place used buffer's descriptor in used ring but don't update used ring's slot index.
      * That will be done with a subsequent client call to virtioCoreVirtqUsedRingSync()
+     *
+     * @todo r=aeichner: The increment of the shadow index is not atomic but this code can be called
+     *                   concurrently!!
      */
     virtioWriteUsedElem(pDevIns, pVirtio, pVirtq, pVirtq->uUsedIdxShadow++, pVirtqBuf->uHeadIdx, (uint32_t)cbTotal);