Changeset 98665 in vbox for trunk/src/VBox/Additions/common/VBoxService

Timestamp:

Feb 21, 2023 7:49:56 AM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

155965

Message:

Guest Control: Implemented the GuestSession::i_fsQueryInfo() + GuestSession::i_fsCreateTemp() calls. bugref:9783

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlSession.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlSession.cpp

@@ -1780 +1780 @@
     if (RT_SUCCESS(rc))
     {
+        uint32_t fFlagsRuntime = 0;
+
         if (!(fFlags & ~GSTCTL_QUERYINFO_F_VALID_MASK))
         {
-            uint32_t fFlagsRuntime = 0;
             if (fFlags & GSTCTL_QUERYINFO_F_ON_LINK)
                 fFlagsRuntime |= RTPATH_F_ON_LINK;
@@ -1790 +1791 @@
                 fFlagsRuntime |= RTPATH_F_NO_SYMLINKS;
 
+            if (!RTPATH_F_IS_VALID(fFlagsRuntime, 0))
+                rc = VERR_INVALID_PARAMETER;
+        }
+        else
+            rc = VERR_INVALID_PARAMETER;
+
+        if (RT_FAILURE(rc))
+            VGSvcError("Invalid fsqueryinfo flags: %#x (%#x)\n", fFlags, fFlagsRuntime);
+
+        if (RT_SUCCESS(rc))
+        {
 #define CASE_ATTR_ADD_VAL(a_Val) \
             case GSTCTL##a_Val: enmAttrRuntime = RT##a_Val; break;
@@ -1820 +1832 @@
 
             rc = RTPathQueryInfoEx(szPath, &objInfoRuntime, enmAttrRuntime, fFlagsRuntime);
-        }
-        else
-        {
-            VGSvcError("Invalid stat flags: %#x\n", fFlags);
-            rc = VERR_NOT_SUPPORTED;
         }