Changeset 98698 in vbox for trunk/src/VBox/Devices/Audio

Timestamp:

Feb 22, 2023 11:47:44 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

155998

Message:

DrvHostAudioDSound: Removed dsoundUpdateStatusInternal which has been empty since r143618. bugref:9886 bugref:9890

File:

• trunk/src/VBox/Devices/Audio/DrvHostAudioDSound.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Audio/DrvHostAudioDSound.cpp

@@ -249 +249 @@
 static int      drvHostDSoundStreamStopPlayback(PDRVHOSTDSOUND pThis, PDSOUNDSTREAM pStreamDS, bool fReset);
 
-static int      dsoundDevicesEnumerate(PDRVHOSTDSOUND pThis, PDMAUDIOHOSTENUM pDevEnm, uint32_t fEnum);
-
-static void     dsoundUpdateStatusInternal(PDRVHOSTDSOUND pThis);
-
 
 #if defined(LOG_ENABLED) || defined(RTLOG_REL_ENABLED)
@@ -715 +711 @@
     LogFlowFunc(("LEAVE %Rhrc\n", hrc));
     return hrc;
-}
-
-
-/**
- * Updates this host driver's internal status, according to the global, overall input/output
- * state and all connected (native) audio streams.
- *
- * @todo r=bird: This is a 'ing waste of 'ing time!  We're doing this everytime
- *       an 'ing stream is created and we doesn't 'ing use the information here
- *       for any darn thing!  Given the reported slowness of enumeration and
- *       issues with the 'ing code the only appropriate response is:
- *       AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAARG!!!!!!!
- *
- * @param   pThis               Host audio driver instance.
- */
-static void dsoundUpdateStatusInternal(PDRVHOSTDSOUND pThis)
-{
-#if 0 /** @todo r=bird: This isn't doing *ANYTHING* useful. So, I've just disabled it.  */
-    AssertPtrReturnVoid(pThis);
-    LogFlowFuncEnter();
-
-    PDMAudioHostEnumDelete(&pThis->DeviceEnum);
-    int rc = dsoundDevicesEnumerate(pThis, &pThis->DeviceEnum);
-    if (RT_SUCCESS(rc))
-    {
-#if 0
-        if (   pThis->fEnabledOut != RT_BOOL(cbCtx.cDevOut)
-            || pThis->fEnabledIn  != RT_BOOL(cbCtx.cDevIn))
-        {
-            /** @todo Use a registered callback to the audio connector (e.g "OnConfigurationChanged") to
-             *        let the connector know that something has changed within the host backend. */
-        }
-#endif
-        pThis->fEnabledIn  = PDMAudioHostEnumCountMatching(&pThis->DeviceEnum, PDMAUDIODIR_IN)  != 0;
-        pThis->fEnabledOut = PDMAudioHostEnumCountMatching(&pThis->DeviceEnum, PDMAUDIODIR_OUT) != 0;
-    }
-
-    LogFlowFuncLeaveRC(rc);
-#else
-    RT_NOREF(pThis);
-#endif
 }
 
@@ -1697 +1652 @@
     RTListInit(&pStreamDS->ListEntry); /* paranoia */
 
-    /* For whatever reason: */
-    dsoundUpdateStatusInternal(pThis);
-
     /*
      * DSound has different COM interfaces for working with input and output
@@ -2378 +2330 @@
     }
     Log4Func(("cbBuf=%#x stream '%s' {%s}\n", cbBuf, pStreamDS->Cfg.szName, drvHostDSoundStreamStatusString(pStreamDS) ));
-
-/** @todo Any condition under which we should call dsoundUpdateStatusInternal(pThis) here?
- * The old code thought it did so in case of failure, only it couldn't ever fails, so it never did. */
 
     /*