Changeset 98824 in vbox for trunk/include/VBox/GuestHost

Timestamp:

Mar 2, 2023 5:06:36 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

156144

Message:

Guest Control: Made the directory entry reading really dynamic by letting the guest tell us the size it reports to the guest (limited by GSTCTL_DIRENTRY_MAX_SIZE). Re-introduced the #pragma pack(1) because we need the structures on mixed bitness (32 / 64 or vice versa) with the same size. bugref:9783

File:

• trunk/include/VBox/GuestHost/GuestControl.h (modified) (3 diffs)

trunk/include/VBox/GuestHost/GuestControl.h

@@ -303 +303 @@
  * Additional Unix Attributes (GSTCTLFSOBJATTRADD_UNIX).
  */
+#pragma pack(1)
 typedef struct GSTCTLFSOBJATTRUNIX
 {
@@ -344 +345 @@
     RTDEV           Device;
 } GSTCTLFSOBJATTRUNIX;
+#pragma pack()
+AssertCompileSize(GSTCTLFSOBJATTRUNIX, 36);
 
 /**
@@ -549 +552 @@
 typedef GSTCTLDIRENTRYEX const *PCGSTCTLDIRENTRYEX;
 
-/** The maximum size (in bytes) of a GSTCTLDIRENTRYEX (includes dynamic szName[pDirEntry->cbName + 1]). */
-#define GSTCTL_DIRENTRY_MAX_SIZE    (sizeof(GSTCTLDIRENTRYEX) + RTPATH_MAX)
+/** The maximum size (in bytes) of an entry file name (at least RT_UOFFSETOF(GSTCTLDIRENTRYEX, szName[2]). */
+#define GSTCTL_DIRENTRY_MAX_SIZE    4096
 
 } /* namespace guestControl */