Changeset 99083 in vbox for trunk/src/VBox

Timestamp:

Mar 21, 2023 11:34:44 AM (23 months ago)

Author:

vboxsync

Message:

FE/Qt: bugref:10322: Runtime UI: Network status-bar indicator do not need update timer anymore, we have network-adapter-change event for attachment type and cable state.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIIndicatorsPool.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIIndicatorsPool.cpp

@@ -382 +382 @@
     UIIndicatorNetwork(UIMachine *pMachine)
         : UISessionStateStatusBarIndicator(IndicatorType_Network, pMachine)
-        , m_pTimerAutoUpdate(0)
     {
         /* Assign state-icons: */
@@ -389 +388 @@
         setStateIcon(KDeviceActivity_Writing, UIIconPool::iconSet(":/nw_write_16px.png"));
         setStateIcon(KDeviceActivity_Null,    UIIconPool::iconSet(":/nw_disabled_16px.png"));
-        /* Configure machine state-change listener: */
+        /* Configure connection: */
         connect(m_pMachine, &UIMachine::sigMachineStateChange,
-                this, &UIIndicatorNetwork::sltHandleMachineStateChange);
-        /* Create auto-update timer: */
-        m_pTimerAutoUpdate = new QTimer(this);
-        if (m_pTimerAutoUpdate)
-        {
-            /* Configure auto-update timer: */
-            connect(m_pTimerAutoUpdate, &QTimer::timeout,
-                    this, &UIIndicatorNetwork::updateAppearance);
-            /* Start timer immediately if machine is running: */
-            sltHandleMachineStateChange();
-        }
+                this, &UIIndicatorNetwork::updateAppearance);
+        connect(m_pMachine, &UIMachine::sigNetworkAdapterChange,
+                this, &UIIndicatorNetwork::updateAppearance);
         /* Translate finally: */
         retranslateUi();
@@ -428 +419 @@
         setState(fAdaptersPresent && !fCablesDisconnected ? KDeviceActivity_Idle : KDeviceActivity_Null);
     }
-
-private slots:
-
-    /** Updates auto-update timer depending on machine state. */
-    void sltHandleMachineStateChange()
-    {
-        if (m_pMachine->machineState() == KMachineState_Running)
-        {
-            /* Start auto-update timer otherwise: */
-            m_pTimerAutoUpdate->start(5000);
-            return;
-        }
-        /* Stop auto-update timer otherwise: */
-        m_pTimerAutoUpdate->stop();
-    }
-
-private:
-
-    /** Holds the auto-update timer instance. */
-    QTimer *m_pTimerAutoUpdate;
 };