Changeset 99096 in vbox

Timestamp:

Mar 21, 2023 3:54:10 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

156461

Message:

FE/Qt: bugref:10322: Runtime UI: Recording status-bar indicator should be updated directly by recording-change event.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/runtime

Files:

• UIIndicatorsPool.cpp (modified) (1 diff)
• UIMachineDefs.h (modified) (1 diff)
• normal/UIMachineWindowNormal.cpp (modified) (4 diffs)
• normal/UIMachineWindowNormal.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIIndicatorsPool.cpp

@@ -616 +616 @@
         /* Configure connection: */
         connect(pMachine, &UIMachine::sigMachineStateChange,
+                this, &UIIndicatorRecording::updateAppearance);
+        connect(pMachine, &UIMachine::sigRecordingChange,
                 this, &UIIndicatorRecording::updateAppearance);
         /* Create *enabled* state animation: */

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIMachineDefs.h

@@ -49 +49 @@
     UIVisualElement_MouseIntegrationStuff = RT_BIT(1),
     UIVisualElement_IndicatorPoolStuff    = RT_BIT(2),
-    UIVisualElement_Recording             = RT_BIT(11),
     UIVisualElement_FeaturesStuff         = RT_BIT(12),
 #ifndef VBOX_WS_MAC

trunk/src/VBox/Frontends/VirtualBox/src/runtime/normal/UIMachineWindowNormal.cpp

@@ -80 +80 @@
 
     /* Update indicator-pool and virtualization stuff: */
-    updateAppearanceOf(UIVisualElement_IndicatorPoolStuff | UIVisualElement_Recording | UIVisualElement_FeaturesStuff);
-}
-
-void UIMachineWindowNormal::sltRecordingChange()
-{
-    /* Update video-capture stuff: */
-    updateAppearanceOf(UIVisualElement_Recording);
+    updateAppearanceOf(UIVisualElement_IndicatorPoolStuff | UIVisualElement_FeaturesStuff);
 }
 
@@ -210 +204 @@
 
     /* Start watching for console events: */
-    connect(machineLogic()->uimachine(), &UIMachine::sigRecordingChange,
-            this, &UIMachineWindowNormal::sltRecordingChange);
     connect(machineLogic()->uimachine(), &UIMachine::sigCPUExecutionCapChange,
             this, &UIMachineWindowNormal::sltCPUExecutionCapChange);
@@ -402 +394 @@
 {
     /* Stop watching for console events: */
-    disconnect(machineLogic()->uimachine(), &UIMachine::sigRecordingChange,
-               this, &UIMachineWindowNormal::sltRecordingChange);
     disconnect(machineLogic()->uimachine(), &UIMachine::sigCPUExecutionCapChange,
                this, &UIMachineWindowNormal::sltCPUExecutionCapChange);
@@ -669 +659 @@
                 m_pIndicatorsPool->updateAppearance(IndicatorType_Features);
         }
-        /* If VM is running or paused: */
-        if (uimachine()->isRunning() || uimachine()->isPaused())
-        {
-            if (iElement & UIVisualElement_Recording)
-                m_pIndicatorsPool->updateAppearance(IndicatorType_Recording);
-        }
     }
 }

trunk/src/VBox/Frontends/VirtualBox/src/runtime/normal/UIMachineWindowNormal.h

@@ -59 +59 @@
     /** Handles machine state change event. */
     void sltMachineStateChanged();
-    /** Handles recording change event. */
-    void sltRecordingChange();
     /** Handles CPU execution cap change event. */
     void sltCPUExecutionCapChange();