Changeset 99123 in vbox

Timestamp:

Mar 22, 2023 9:40:58 PM (21 months ago)

Author:

vboxsync

Message:

ValidationKit/tests/api/tdTreeDepth1.py: If all of the API tests are
run via tdApi1.py then VMs created before tdTreeDepth1.py which
don't clean up after themselves will have populated the global
IVirtualBox::hardDisks[] array which this test examines for any base
media leftover after calling IMachine::unregister(). The check here
needs smartening up to verify whether any of the base hard disks in the
HardDisks[] array actually belong to this VM.

File:

• trunk/src/VBox/ValidationKit/tests/api/tdTreeDepth1.py (modified) (5 diffs)

trunk/src/VBox/ValidationKit/tests/api/tdTreeDepth1.py

@@ -97 +97 @@
                     reporter.log2('parent medium = %s cDisks = %d' % (oParentMedium.location, cDisks));
                     oParentMedium = oParentMedium.parent;
+        return cDisks;
+
+    def getNumOfHDsFromHardDisksArray(self):
+        """
+        Helper routine for counting the hard disks that belong to this VM which are
+        contained in the global IVirtualBox::hardDisks[] array (which contains base media
+        only).
+        """
+        cDisks = 0;
+        aoHDs = self.oTstDrv.oVBoxMgr.getArray(self.oTstDrv.oVBox, 'hardDisks');
+        # Walk the IVirtualBox::hardDisks[] array for hard disks belonging to this VM.
+        # The array may contain entries from other VMs created by previous API tessts
+        # which haven't unregistered and deleted their VM's configuration.  The location
+        # attribute of each disk looks similar to:
+        # /var/tmp/VBoxTestTmp/VBoxUserHome/Machines/vm 2/tdAppliance1-t2-disk1.vmdk
+        # So we compare the directory where the disk is located, i.e. the 'basefolder',
+        # with our VM's basefolder which looks similar to:
+        # /var/tmp/VBoxTestTmp/VBoxUserHome/Machines/test-medium
+        # to determine if the disk belongs to us.
+        for oHD in aoHDs:
+            sHDBaseFolder = os.path.dirname(oHD.location);
+            sVMBaseFolder = os.path.join(self.oTstDrv.oVBox.systemProperties.defaultMachineFolder, 'test-medium');
+            reporter.log2('HDBaseFolder = %s VMBaseFolder = %s' % (sHDBaseFolder, sVMBaseFolder));
+            if sHDBaseFolder== sVMBaseFolder:
+                cDisks = cDisks + 1;
         return cDisks;
 
@@ -209 +234 @@
         oVM = None;
 
-        # If there is no base image (expected) then there are no leftover
-        # child images either.
-        cBaseImages = len(self.oTstDrv.oVBoxMgr.getArray(self.oTstDrv.oVBox, 'hardDisks'))
-        reporter.log('After unregister(DetachAllReturnHardDisksOnly): API reports %d base images' % (cBaseImages));
-        if cBaseImages != 0:
-            reporter.error('Got %d initial base images, expected zero (0)' % (cBaseImages));
+        # If there are no base media belonging to this VM in the global IVirtualBox::hardDisks[]
+        # array (expected) then there are no leftover child images either.
+        cNumDisks = self.getNumOfHDsFromHardDisksArray();
+        reporter.log('After unregister(DetachAllReturnHardDisksOnly): API reports %d base images (should be zero)' % (cNumDisks));
+        if cNumDisks != 0:
+            reporter.error('Got %d initial base images, expected zero (0)' % (cNumDisks));
 
         # re-register to test loading of settings
@@ -251 +276 @@
         time.sleep(3);
 
-        cBaseImages = len(self.oTstDrv.oVBoxMgr.getArray(self.oTstDrv.oVBox, 'hardDisks'))
-        reporter.log('After unregister(UnregisterOnly): API reports %d base images' % (cBaseImages));
-        if cBaseImages != 0:
-            reporter.error('Got %d base images after unregistering, expected zero (0)' % (cBaseImages));
+        # If there are no base media belonging to this VM in the global IVirtualBox::hardDisks[]
+        # array (expected) then there are no leftover child images either.
+        cNumDisks = self.getNumOfHDsFromHardDisksArray();
+        reporter.log('After unregister(UnregisterOnly): API reports %d base images (should be zero)' % (cNumDisks));
+        if cNumDisks != 0:
+            reporter.error('Got %d base images after unregistering, expected zero (0)' % (cNumDisks));
 
         return reporter.testDone()[1] == 0;
@@ -303 +330 @@
         oVM = None;
 
-        # If there is no base image (expected) then there are no leftover
-        # child images either.
-        cBaseImages = len(self.oTstDrv.oVBoxMgr.getArray(self.oTstDrv.oVBox, 'hardDisks'))
-        reporter.log('After unregister(DetachAllReturnHardDisksOnly): API reports %d base images' % (cBaseImages));
-        fRc = fRc and cBaseImages == 0
-        if cBaseImages != 0:
-            reporter.error('Got %d initial base images, expected zero (0)' % (cBaseImages));
+        # If there are no base media belonging to this VM in the global IVirtualBox::hardDisks[]
+        # array (expected) then there are no leftover child images either.
+        cNumDisks = self.getNumOfHDsFromHardDisksArray();
+        reporter.log('After unregister(DetachAllReturnHardDisksOnly): API reports %d base images (should be zero)' % (cNumDisks));
+        fRc = fRc and cNumDisks == 0
+        if cNumDisks != 0:
+            reporter.error('Got %d initial base images, expected zero (0)' % (cNumDisks));
 
         # re-register to test loading of settings
@@ -345 +372 @@
         time.sleep(3);
 
-        cBaseImages = len(self.oTstDrv.oVBoxMgr.getArray(self.oTstDrv.oVBox, 'hardDisks'))
-        reporter.log('After unregister(UnregisterOnly): API reports %d base images' % (cBaseImages));
-        if cBaseImages != 0:
-            reporter.error('Got %d base images after unregistering, expected zero (0)' % (cBaseImages));
+        # If there are no base media belonging to this VM in the global IVirtualBox::hardDisks[]
+        # array (expected) then there are no leftover child images either.
+        cNumDisks = self.getNumOfHDsFromHardDisksArray();
+        reporter.log('After unregister(UnregisterOnly): API reports %d base images (should be zero)' % (cNumDisks));
+        if cNumDisks != 0:
+            reporter.error('Got %d base images after unregistering, expected zero (0)' % (cNumDisks));
 
         return reporter.testDone()[1] == 0