Changeset 99235 in vbox for trunk/src/VBox/ValidationKit/tests/api

Timestamp:

Mar 30, 2023 2:24:55 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

156614

Message:

ValidationKit/tests/api/tdCloneMedium1.py: Solaris delivers python2 as a
32-bit binary which can't handle signed values above 0x7fffffff (MAXINT)
such as 0xdeadbeef. This causes the test suite to fail on Solaris with
the message: 'OverflowError: Python int too large to convert to C long'.
Fixed by using a smaller value when running 32-bit python2 on Solaris.

File:

• trunk/src/VBox/ValidationKit/tests/api/tdCloneMedium1.py (modified) (5 diffs)

trunk/src/VBox/ValidationKit/tests/api/tdCloneMedium1.py

@@ -44 +44 @@
 import os
 import sys
+import platform
 
 # Only the main script needs to modify the path.
@@ -52 +53 @@
 
 # Validation Kit imports.
+from common     import utils
 from testdriver import base
 from testdriver import reporter
@@ -65 +67 @@
     def __init__(self, oTstDrv):
         base.SubTestDriverBase.__init__(self, oTstDrv, 'clone-medium', 'Move Medium');
+        # Solaris delivers a 32-bit version of Python 2.7 which can't handle signed values
+        # above 0x7fffffff (MAXINT) such as 0xdeadbeef.  N.B. If this ever needs to be
+        # extended to other OSes the Python docs:
+        # https://docs.python.org/3/library/platform.html#platform.architecture
+        # mention that the platform.architecture() call can be wrong on macOS.
+        if utils.getHostOs() == 'solaris' and sys.version_info[0] < 3 and platform.architecture()[0] == '32bit':
+            self.iDataToWrite = 0x0badcafe;
+        else:
+            self.iDataToWrite = 0xdeadbeef;
 
     def testIt(self):
@@ -174 +185 @@
         oVM = self.oTstDrv.createTestVM('test-medium-clone-only', 1, None, 4)
 
-        hd1 = self.createTestMedium(oVM, "hd1-cloneonly", data=[0xdeadbeef])
+        hd1 = self.createTestMedium(oVM, "hd1-cloneonly", data=[self.iDataToWrite])
         hd2 = self.createTestMedium(oVM, "hd2-cloneonly")
 
@@ -205 +216 @@
         oVM = self.oTstDrv.createTestVM('test-medium-clone-only', 1, None, 4)
 
-        hd1 = self.createTestMedium(oVM, "hd1-resizeandclone", data=[0xdeadbeef])
+        hd1 = self.createTestMedium(oVM, "hd1-resizeandclone", data=[self.iDataToWrite])
         hd2 = self.createTestMedium(oVM, "hd2-resizeandclone")