Changeset 9927 in vbox

Timestamp:

Jun 25, 2008 3:03:04 PM (17 years ago)

Author:

vboxsync

Message:

@todo

File:

• trunk/src/VBox/HostServices/SharedFolders/vbsf.cpp (modified) (7 diffs)

trunk/src/VBox/HostServices/SharedFolders/vbsf.cpp

@@ -236 +236 @@
     {
 #ifdef RT_OS_DARWIN
+/** @todo This belongs in rtPathToNative or in the windows shared folder file system driver...
+ * The question is simply whether the NFD normalization is actually applied on a (virtaul) file
+ * system level in darwin, or just by the user mode application libs. */
                 SHFLSTRING *pPathParameter = pPath;
                 size_t cbPathLength;
@@ -241 +244 @@
                 uint16_t ucs2Length;
                 CFRange rangeCharacters;
-                
+
                 // Is 8 times length enough for decomposed in worst case...?
                 cbPathLength = sizeof(SHFLSTRING) + pPathParameter->u16Length * 8 + 2;
@@ -251 +254 @@
                         return rc;
                 }
-                
+
                 ::CFStringAppendCharacters(inStr, (UniChar*)pPathParameter->String.ucs2, pPathParameter->u16Length / sizeof(pPathParameter->String.ucs2[0]));
                 ::CFStringNormalize(inStr, kCFStringNormalizationFormD);
                 ucs2Length = ::CFStringGetLength(inStr);
-                
+
                 rangeCharacters.location = 0;
                 rangeCharacters.length = ucs2Length;
@@ -262 +265 @@
                 pPath->u16Length = ucs2Length * sizeof(pPath->String.ucs2[0]);
                 pPath->u16Size = pPath->u16Length + sizeof(pPath->String.ucs2[0]);
-                
+
                 CFRelease(inStr);
 #endif
@@ -1387 +1390 @@
 
 #ifdef RT_OS_DARWIN
+/** @todo This belongs in rtPathToNative or in the windows shared folder file system driver...
+ * The question is simply whether the NFD normalization is actually applied on a (virtaul) file
+ * system level in darwin, or just by the user mode application libs. */
                         {
                                 // Convert to
@@ -1395 +1401 @@
                                 CFRange rangeCharacters;
                                 CFMutableStringRef inStr = ::CFStringCreateMutable(NULL, 0);
-                                
+
                                 ::CFStringAppendCharacters(inStr, (UniChar *)pwszString, RTUtf16Len (pwszString));
                                 ::CFStringNormalize(inStr, kCFStringNormalizationFormC);
                                 ucs2Length = ::CFStringGetLength(inStr);
-                                
+
                                 rangeCharacters.location = 0;
                                 rangeCharacters.length = ucs2Length;
                                 ::CFStringGetCharacters(inStr, rangeCharacters, pwszString);
                                 pwszString[ucs2Length] = 0x0000; // NULL terminated
-                                
+
                                 CFRelease(inStr);
                         }
@@ -1435 +1441 @@
     }
     Assert(rc != VINF_SUCCESS || *pcbBuffer > 0);
-    
+
 end:
     if (pDirEntry)