Changeset 99288 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Apr 4, 2023 11:55:49 PM (21 months ago)

Author:

vboxsync

Message:

VMM/IEM: More work on processing MC blocks and generating threaded functions from them. bugref:10369

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• IEMAllInstructionsPython.py (modified) (12 diffs)
• IEMAllThreadedPython.py (modified) (4 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsPython.py

@@ -529 +529 @@
 
 ## \@ophints values.
+# pylint: disable=line-too-long
 g_kdHints = {
     'invalid':                   'DISOPTYPE_INVALID',                   ##<
@@ -568 +569 @@
     'lock_allowed':          '',                                        ##< Lock prefix allowed.
 };
+# pylint: enable=line-too-long
 
 ## \@opxcpttype values (see SDMv2 2.4, 2.7).
@@ -1741 +1743 @@
 
 #
+# Decoder functions.
+#
+
+class DecoderFunction(object):
+    """
+    Decoder function.
+
+    This is mainly for searching for scoping searches for variables used in
+    microcode blocks.
+    """
+    def __init__(self, sSrcFile, iBeginLine, sName, asDefArgs):
+        self.sName        = sName;                  ##< The function name.
+        self.asDefArgs    = asDefArgs;              ##< The FNIEMOP*DEF/STUB* macro argument list, 0th element is the macro name.
+        self.sSrcFile     = sSrcFile;               ##< The source file the function is defined in.
+        self.iBeginLine   = iBeginLine;             ##< The start line.
+        self.iEndLine     = -1;                     ##< The line the function (probably) ends on.
+        self.asLines      = [] # type: list(str)    ##< The raw lines the function is made up of.
+
+    def complete(self, iEndLine, asLines):
+        """
+        Completes the function.
+        """
+        assert self.iEndLine == -1;
+        self.iEndLine     = iEndLine;
+        self.asLines      = asLines;
+
+
+#
 # "Microcode" statements and blocks
 #
@@ -1887 +1917 @@
     """
 
-    def __init__(self, sSrcFile, iBeginLine, offBeginLine, sFunction, iInFunction, cchIndent = None):
+    def __init__(self, sSrcFile, iBeginLine, offBeginLine, oFunction, iInFunction, cchIndent = None):
         self.sSrcFile     = sSrcFile;                           ##< The source file containing the block.
         self.iBeginLine   = iBeginLine;                         ##< The line with the IEM_MC_BEGIN statement.
@@ -1893 +1923 @@
         self.iEndLine     = -1;                                 ##< The line with the IEM_MC_END statement.
         self.offEndLine   = 0;                                  ##< The offset of the IEM_MC_END statement within the line.
-        self.sFunction    = sFunction;                          ##< The function the block resides in.
+        self.oFunction    = oFunction;                          ##< The function the block resides in.
+        self.sFunction    = oFunction.sName;                    ##< The name of the function the block resides in. DEPRECATED.
         self.iInFunction  = iInFunction;                        ##< The block number wihtin the function.
         self.cchIndent    = cchIndent if cchIndent else offBeginLine;
@@ -2860 +2891 @@
         self.iCommentLine   = 0;
         self.aoCurInstrs    = []    # type: list(Instruction)
-        self.sCurFunction   = None  # type: str
+        self.oCurFunction   = None  # type: DecoderFunction
         self.iMcBlockInFunc = 0;
         self.oCurMcBlock    = None  # type: McBlock
@@ -3252 +3283 @@
         self.aoCurInstrs  = [];
         if fEndOfFunction:
-            #self.debug('%s: sCurFunction=None' % (self.iLine, ));
-            self.sCurFunction   = None;
+            #self.debug('%s: oCurFunction=None' % (self.iLine, ));
+            if self.oCurFunction:
+                self.oCurFunction.complete(self.iLine, self.asLines[self.oCurFunction.iBeginLine - 1 : self.iLine]);
+            self.oCurFunction   = None;
             self.iMcBlockInFunc = 0;
         return True;
@@ -4510 +4543 @@
 
         # Check preconditions.
-        if not self.sCurFunction:
+        if not self.oCurFunction:
             self.raiseError('IEM_MC_BEGIN w/o current function (%s)' % (sCode,));
         if self.oCurMcBlock:
@@ -4520 +4553 @@
         if offPrevNewline >= 0:
             cchIndent -= offPrevNewline + 1;
-        #self.debug('cchIndent=%s offPrevNewline=%s sFunc=%s' % (cchIndent, offPrevNewline, self.sCurFunction));
+        #self.debug('cchIndent=%s offPrevNewline=%s sFunc=%s' % (cchIndent, offPrevNewline, self.oCurFunction.sName));
 
         # Start a new block.
         self.oCurMcBlock = McBlock(self.sSrcFile, self.iLine, offBeginStatementInLine,
-                                   self.sCurFunction, self.iMcBlockInFunc, cchIndent);
+                                   self.oCurFunction, self.iMcBlockInFunc, cchIndent);
         g_aoMcBlocks.append(self.oCurMcBlock);
         self.cTotalMcBlocks += 1;
@@ -4570 +4603 @@
         self.oCurMcBlock.complete(self.iLine, offEndStatementInLine, asLines);
         self.oCurMcBlock = None;
+        return True;
+
+    def workerStartFunction(self, asArgs):
+        """
+        Deals with the start of a decoder function.
+
+        These are all defined using one of the FNIEMOP*_DEF* and FNIEMOP_*STUB*
+        macros, so we get a argument list for these where the 0th argument is the
+        macro name.
+        """
+        # Complete any existing function.
+        if self.oCurFunction:
+            self.oCurFunction.complete(self.iLine - 1, self.asLines[self.oCurFunction.iBeginLine - 1 : self.iLine - 1]);
+
+        # Create the new function.
+        self.oCurFunction = DecoderFunction(self.sSrcFile, self.iLine, asArgs[1], asArgs);
         return True;
 
@@ -4590 +4639 @@
                                                              'FNIEMOP_UD_STUB_1' ]);
             if asArgs is not None:
-                self.sCurFunction = asArgs[1];
-                #self.debug('%s: sCurFunction=%s' % (self.iLine, self.sCurFunction,));
+                self.workerStartFunction(asArgs);
+                #self.debug('%s: oCurFunction=%s' % (self.iLine, self.oCurFunction.sName,));
 
                 if not self.aoCurInstrs:
@@ -4612 +4661 @@
                                                              'FNIEMOP_DEF_2', ]);
             if asArgs is not None:
-                self.sCurFunction = asArgs[1];
-                #self.debug('%s: sCurFunction=%s (%s)' % (self.iLine, self.sCurFunction, asArgs[0]));
+                self.workerStartFunction(asArgs);
+                #self.debug('%s: oCurFunction=%s (%s)' % (self.iLine, self.oCurFunction.sName, asArgs[0]));
                 return True;
 

trunk/src/VBox/VMM/VMMAll/IEMAllThreadedPython.py

@@ -38 +38 @@
 import datetime;
 import os;
+import re;
 import sys;
 import argparse;
@@ -222 +223 @@
         return None; # Shut up pylint 2.16.2.
 
+    def analyzeCallToType(self, sFnRef):
+        """
+        Determins the type of an indirect function call.
+        """
+        assert sFnRef[0] == 'p';
+
+        #
+        # Simple?
+        #
+        if sFnRef.find('-') < 0:
+            oDecoderFunction = self.oParent.oMcBlock.oFunction;
+
+            # Try the argument list of the function defintion macro invocation first.
+            iArg = 2;
+            while iArg < len(oDecoderFunction.asDefArgs):
+                if sFnRef == oDecoderFunction.asDefArgs[iArg]:
+                    return oDecoderFunction.asDefArgs[iArg - 1];
+                iArg += 1;
+
+            # Then check out line that includes the word and looks like a variable declaration.
+            oRe = re.compile(' +(P[A-Z0-9_]+|const +IEMOP[A-Z0-9_]+ *[*]) +(const |) *' + sFnRef + ' *(;|=)');
+            for sLine in oDecoderFunction.asLines:
+                oMatch = oRe.match(sLine);
+                if oMatch:
+                    if not oMatch.group(1).startswith('const'):
+                        return oMatch.group(1);
+                    return 'PC' + oMatch.group(1)[len('const ') : -1].strip();
+
+        #
+        # Deal with the pImpl->pfnXxx:
+        #
+        elif sFnRef.startswith('pImpl->pfn'):
+            sMember   = sFnRef[len('pImpl->') : ];
+            sBaseType = self.analyzeCallToType('pImpl');
+            offBits   = sMember.rfind('U') + 1;
+            if sBaseType == 'PCIEMOPBINSIZES':          return 'PFNIEMAIMPLBIN'         + sMember[offBits:];
+            if sBaseType == 'PCIEMOPUNARYSIZES':        return 'PFNIEMAIMPLBIN'         + sMember[offBits:];
+            if sBaseType == 'PCIEMOPSHIFTSIZES':        return 'PFNIEMAIMPLSHIFT'       + sMember[offBits:];
+            if sBaseType == 'PCIEMOPSHIFTDBLSIZES':     return 'PFNIEMAIMPLSHIFTDBLU'   + sMember[offBits:];
+            if sBaseType == 'PCIEMOPMULDIVSIZES':       return 'PFNIEMAIMPLMULDIVU'     + sMember[offBits:];
+            if sBaseType == 'PCIEMOPMEDIAF3':           return 'PFNIEMAIMPLMEDIAF3U'    + sMember[offBits:];
+            if sBaseType == 'PCIEMOPMEDIAOPTF3':        return 'PFNIEMAIMPLMEDIAOPTF3U' + sMember[offBits:];
+            if sBaseType == 'PCIEMOPMEDIAOPTF2':        return 'PFNIEMAIMPLMEDIAOPTF2U' + sMember[offBits:];
+            if sBaseType == 'PCIEMOPMEDIAOPTF3IMM8':    return 'PFNIEMAIMPLMEDIAOPTF3U' + sMember[offBits:] + 'IMM8';
+            if sBaseType == 'PCIEMOPBLENDOP':           return 'PFNIEMAIMPLAVXBLENDU'   + sMember[offBits:];
+
+            self.raiseProblem('Unknown call reference: %s::%s (%s)' % (sBaseType, sMember, sFnRef,));
+
+        self.raiseProblem('Unknown call reference: %s' % (sFnRef,));
+        return None; # Shut up pylint 2.16.2.
+
     def analyzeMorphStmtForThreaded(self, aoStmts, iParamRef = 0):
         """
@@ -430 +482 @@
             if isinstance(oStmt, iai.McStmtCall):
                 if oStmt.sFn[0] == 'p':
-                    self.aoParamRefs.append(ThreadedParamRef(oStmt.sFn, 'uintptr_t', oStmt, oStmt.idxFn));
+                    self.aoParamRefs.append(ThreadedParamRef(oStmt.sFn, self.analyzeCallToType(oStmt.sFn), oStmt, oStmt.idxFn));
                 elif (    oStmt.sFn[0] != 'i'
                       and not oStmt.sFn.startswith('IEMTARGETCPU_EFL_BEHAVIOR_SELECT')
@@ -588 +640 @@
     def dummyInstance():
         """ Gets a dummy instance. """
-        return ThreadedFunction(iai.McBlock('null', 999999999, 999999999, 'nil', 999999999));
+        return ThreadedFunction(iai.McBlock('null', 999999999, 999999999,
+                                            iai.DecoderFunction('null', 999999999, 'nil', ('','')), 999999999));
 
     def raiseProblem(self, sMessage):