Changeset 99304 in vbox for trunk/src

Timestamp:

Apr 6, 2023 1:38:19 AM (22 months ago)

Author:

vboxsync

Message:

VMM/IEM: More work on processing MC blocks, mainly related to reducing number of parameters for MC blocks in threaded function mode. bugref:10369

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IEMAllInstructionsOneByte.cpp.h (modified) (2 diffs)
• VMMAll/IEMAllInstructionsPython.py (modified) (1 diff)
• include/IEMMc.h (modified) (1 diff)
• testcase/tstIEMCheckMc.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsOneByte.cpp.h

@@ -2834 +2834 @@
 
                 IEM_MC_CALC_RM_EFF_ADDR(GCPtrEffDst, bRm, 4);
-                uint64_t u64Imm; IEM_OPCODE_GET_NEXT_S32_SX_U64(&u64Imm);
-                IEM_MC_ASSIGN(u64Src, u64Imm);
+                uint32_t u32Imm; IEM_OPCODE_GET_NEXT_U32(&u32Imm); /* Not using IEM_OPCODE_GET_NEXT_S32_SX_U64 to reduce the */
+                IEM_MC_ASSIGN_U32_SX_U64(u64Src, u32Imm);          /* parameter count for the threaded function for this block. */
                 IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX();
                 IEM_MC_FETCH_MEM_U64(u64Tmp, pVCpu->iem.s.iEffSeg, GCPtrEffDst);
@@ -3037 +3037 @@
 
                 IEM_MC_CALC_RM_EFF_ADDR(GCPtrEffDst, bRm, 1);
-                uint64_t u64Imm; IEM_OPCODE_GET_NEXT_S8_SX_U64(&u64Imm);
-                IEM_MC_ASSIGN(u64Src, u64Imm);
+                uint8_t u8Imm; IEM_OPCODE_GET_NEXT_U8(&u8Imm); /* Not using IEM_OPCODE_GET_NEXT_S8_SX_U64 to reduce the */
+                IEM_MC_ASSIGN_U8_SX_U64(u64Src, u8Imm);        /* parameter count for the threaded function for this block. */
                 IEMOP_HLP_DONE_DECODING_NO_LOCK_PREFIX();
                 IEM_MC_FETCH_MEM_U64(u64Tmp, pVCpu->iem.s.iEffSeg, GCPtrEffDst);

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsPython.py

@@ -2477 +2477 @@
     'IEM_MC_ASSIGN':                                             McBlock.parseMcGeneric,
     'IEM_MC_ASSIGN_TO_SMALLER':                                  McBlock.parseMcGeneric,
+    'IEM_MC_ASSIGN_U8_SX_U64':                                   McBlock.parseMcGeneric,
+    'IEM_MC_ASSIGN_U32_SX_U64':                                  McBlock.parseMcGeneric,
     'IEM_MC_BEGIN':                                              McBlock.parseMcGeneric,
     'IEM_MC_BSWAP_LOCAL_U16':                                    McBlock.parseMcGeneric,

trunk/src/VBox/VMM/include/IEMMc.h

@@ -275 +275 @@
 #define IEM_MC_ASSIGN(a_VarOrArg, a_CVariableOrConst)   (a_VarOrArg) = (a_CVariableOrConst)
 #define IEM_MC_ASSIGN_TO_SMALLER                        IEM_MC_ASSIGN
+#define IEM_MC_ASSIGN_U8_SX_U64(a_u64VarOrArg, a_u8CVariableOrConst) \
+   (a_u64VarOrArg) = (int8_t)(a_u8CVariableOrConst)
+#define IEM_MC_ASSIGN_U32_SX_U64(a_u64VarOrArg, a_u32CVariableOrConst) \
+   (a_u64VarOrArg) = (int32_t)(a_u32CVariableOrConst)
 
 #define IEM_MC_FETCH_GREG_U8(a_u8Dst, a_iGReg)          (a_u8Dst)  = iemGRegFetchU8(pVCpu, (a_iGReg))

trunk/src/VBox/VMM/testcase/tstIEMCheckMc.cpp

@@ -656 +656 @@
 #define IEM_MC_ASSIGN(a_VarOrArg, a_CVariableOrConst)   do { (a_VarOrArg) = (0); (void)fMcBegin; } while (0)
 #define IEM_MC_ASSIGN_TO_SMALLER                        IEM_MC_ASSIGN
+#define IEM_MC_ASSIGN_U8_SX_U64                         IEM_MC_ASSIGN
+#define IEM_MC_ASSIGN_U32_SX_U64                        IEM_MC_ASSIGN
 
 #define IEM_MC_FETCH_GREG_U8(a_u8Dst, a_iGReg)          do { (a_u8Dst)  = 0; CHK_TYPE(uint8_t,  a_u8Dst);  CHK_GREG_IDX(a_iGReg); (void)fMcBegin; } while (0)