Changeset 9935 in vbox for trunk/src/VBox/Runtime/r3

Timestamp:

Jun 25, 2008 4:49:24 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

32357

Message:

r=bird: Review comments, work to be done. Marked the RTSystemProcessorGetCount/ActiveMask as retired by the RTMp stuff (partly a todo).

File:

• trunk/src/VBox/Runtime/r3/posix/system-posix.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/r3/posix/system-posix.cpp

@@ -94 +94 @@
 /**
  * Gets the current figures of overall system processor usage.
- *  
- * @remarks To get meaningful stats this function has to be 
+ *
+ * @remarks To get meaningful stats this function has to be
  *          called twice with a bit of delay between calls. This
  *          is due to the fact that at least two samples of
  *          system usage stats are needed to calculate the load.
- *  
+ *
  * @returns None.
  */
 RTDECL(int) RTSystemProcessorGetUsageStats(PRTCPUUSAGESTATS pStats)
 {
+/** @todo r=bird: This is Linux specific and doesn't belong here. Move this to r3/linux/RTSystemGetCpuLoadStats-linux.cpp. */
     int rc = VINF_SUCCESS;
     uint32_t u32UserNow, u32NiceNow, u32SystemNow, u32IdleNow;
@@ -139 +140 @@
 /**
  * Gets the current processor usage for a partucilar process.
- *  
- * @remarks To get meaningful stats this function has to be 
+ *
+ * @remarks To get meaningful stats this function has to be
  *          called twice with a bit of delay between calls. This
  *          is due to the fact that at least two samples of
  *          system usage stats are needed to calculate the load.
- *  
+ *
  * @returns None.
  */
@@ -153 +154 @@
     uint32_t u32UserDelta, u32SystemDelta;
     uint64_t u64TotalNow, u64TotalDelta;
+
+/** @todo r=bird: This is Linux specific and doesn't belong here. Move this to r3/linux/RTSystemGetCpuLoadStats-linux.cpp. */
     FILE *f = fopen("/proc/stat", "r");
 
     if (f)
     {
-        if (fscanf(f, "cpu %u %u %u %u", &u32UserNow, &u32NiceNow, &u32SystemNow, &u32IdleNow) == 4)
+        if (fscanf(f, "cpu %u %u %u %u", &u32UserNow, &u32NiceNow, &u32SystemNow, &u32IdleNow) == 4) /** @todo 'uint32_t' is not necessarily the same as 'unsigned int'. */
         {
             char *pszName;