Changeset 99354 in vbox

Timestamp:

Apr 8, 2023 12:37:37 AM (20 months ago)

Author:

vboxsync

Message:

VMM/IEM: Mojo improvments for IEM_MC_MAYBE_RAISE_MMX_RELATED_XCPT. bugref:10369

File:

• trunk/src/VBox/VMM/include/IEMMc.h (modified) (1 diff)

trunk/src/VBox/VMM/include/IEMMc.h

@@ -127 +127 @@
 #define IEM_MC_MAYBE_RAISE_MMX_RELATED_XCPT() \
     do { \
-        if (RT_LIKELY(!(pVCpu->cpum.GstCtx.cr0 & (X86_CR0_EM | X86_CR0_TS)))) \
+        /* Since the two CR0 bits doesn't overlap with FSW.ES, this can be reduced to a
+           single compare branch in the more probable code path. */ \
+        if (RT_LIKELY(!(  (pVCpu->cpum.GstCtx.cr0 & (X86_CR0_EM | X86_CR0_TS)) \
+                        | (pVCpu->cpum.GstCtx.XState.x87.FSW & X86_FSW_ES)))) \
         { /* probable */ } \
         else if (pVCpu->cpum.GstCtx.cr0 & X86_CR0_EM) \
             return iemRaiseUndefinedOpcode(pVCpu); \
+        else if (pVCpu->cpum.GstCtx.cr0 & X86_CR0_TS) \
+            return iemRaiseDeviceNotAvailable(pVCpu); \
         else \
-            return iemRaiseDeviceNotAvailable(pVCpu); \
-        \
-        if (!(pVCpu->cpum.GstCtx.XState.x87.FSW & X86_FSW_ES)) { /* probable */ } \
-        else return iemRaiseMathFault(pVCpu); \
-    } while (0)
+            return iemRaiseMathFault(pVCpu); \
+    } while (0)
+AssertCompile(!((X86_CR0_EM | X86_CR0_TS) & X86_FSW_ES));
 #define IEM_MC_RAISE_GP0_IF_CPL_NOT_ZERO() \
     do { \