Changeset 99444 in vbox for trunk/src/VBox/Frontends

Timestamp:

Apr 18, 2023 3:02:55 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

156905

Message:

FE/Qt: Fixed Q_ASSERT issues in UIPortForwardingModel::setRules when working with with empty rule lists (both original and new).

File:

• trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIPortForwardingTable.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UIPortForwardingTable.cpp

@@ -564 +564 @@
 {
     /* Clear old data first of all: */
-    beginRemoveRows(QModelIndex(), 0, m_dataList.size() - 1);
-    foreach (const UIPortForwardingRow *pRow, m_dataList)
-        delete pRow;
-    m_dataList.clear();
-    endRemoveRows();
+    if (!m_dataList.isEmpty())
+    {
+        beginRemoveRows(QModelIndex(), 0, m_dataList.size() - 1);
+        foreach (const UIPortForwardingRow *pRow, m_dataList)
+            delete pRow;
+        m_dataList.clear();
+        endRemoveRows();
+    }
 
     /* Fetch incoming data: */
-    beginInsertRows(QModelIndex(), 0, newRules.size() - 1);
-    foreach (const UIDataPortForwardingRule &rule, newRules)
-        m_dataList << new UIPortForwardingRow(qobject_cast<QITableView*>(parent()),
-                                              rule.name, rule.protocol,
-                                              rule.hostIp, rule.hostPort,
-                                              rule.guestIp, rule.guestPort);
-    endInsertRows();
+    if (!newRules.isEmpty())
+    {
+        beginInsertRows(QModelIndex(), 0, newRules.size() - 1);
+        foreach (const UIDataPortForwardingRule &rule, newRules)
+            m_dataList << new UIPortForwardingRow(qobject_cast<QITableView*>(parent()),
+                                                  rule.name, rule.protocol,
+                                                  rule.hostIp, rule.hostPort,
+                                                  rule.guestIp, rule.guestPort);
+        endInsertRows();
+    }
 }