Changeset 99466 in vbox for trunk/src/VBox/Main

Timestamp:

Apr 19, 2023 7:42:38 PM (20 months ago)

Author:

vboxsync

Message:

Main/MediumImpl.cpp: Corrected incorrect MediaList::const_reverse_iterator use.

File:

• trunk/src/VBox/Main/src-server/MediumImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/MediumImpl.cpp

@@ -1491 +1491 @@
         Assert(llParentsTodo.size() == 0);
         /* Create the list of notifications, parent first. */
-        MediaList::const_reverse_iterator itBegin = llMediaTocleanup.rbegin();
-        MediaList::const_reverse_iterator itEnd = llMediaTocleanup.rend();
-        for (MediaList::const_reverse_iterator it = itBegin; it != itEnd; --it)
+        for (MediaList::const_reverse_iterator it = llMediaTocleanup.rbegin(); it != llMediaTocleanup.rend(); ++it)
         {
             ComObjPtr<Medium> pMedium = *it;
             AutoCaller mediumCaller(pMedium);
-            if (FAILED(mediumCaller.hrc())) continue;
-            const Guid &id = pMedium->i_getId();
-            uIdsForNotify.push_back(std::pair<Guid, DeviceType_T>(id, aDeviceType));
+            if (mediumCaller.isOk())
+            {
+                const Guid &id = pMedium->i_getId();
+                uIdsForNotify.push_back(std::pair<Guid, DeviceType_T>(id, aDeviceType));
+            }
         }
     }