Changeset 99529 in vbox

Timestamp:

Apr 26, 2023 6:07:54 AM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157038

Message:

Devices/DevPL011: Need to set and clear the TX FIFO full bit as well, fixes losing characters, bugref:10403

File:

• trunk/src/VBox/Devices/Serial/DevPL011.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Serial/DevPL011.cpp

@@ -421 +421 @@
 #else
             pThis->uRegDr = bVal;
-            pThis->uRegFr |= PL011_REG_UARTFR_BUSY;
+            pThis->uRegFr |= PL011_REG_UARTFR_BUSY | PL011_REG_UARTFR_TXFF;
             pl011IrqUpdate(pDevIns, pThis, pThisCC);
             fNotifyDrv = true;
@@ -525 +525 @@
         pThisCC->pDrvSerial->pfnQueuesFlush(pThisCC->pDrvSerial, true /*fQueueRecv*/, false /*fQueueXmit*/);
         ASMAtomicWriteU32(&pThis->cbAvailRdr, 0);
-        PL011_REG_CLR(pThis->uRegFr, PL011_REG_UARTFR_BUSY);
+        PL011_REG_CLR(pThis->uRegFr, PL011_REG_UARTFR_BUSY | PL011_REG_UARTFR_TXFF);
     }
 }
@@ -593 +593 @@
         *(uint8_t *)pvBuf = pThis->uRegDr;
         *pcbRead = 1;
-        PL011_REG_CLR(pThis->uRegFr, PL011_REG_UARTFR_BUSY);
+        PL011_REG_CLR(pThis->uRegFr, PL011_REG_UARTFR_BUSY | PL011_REG_UARTFR_TXFF);
         pl011IrqUpdate(pDevIns, pThis, pThisCC);
     }