Changeset 99692 in vbox

Timestamp:

May 9, 2023 9:31:21 AM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157240

Message:

NetworkServices,VirtualBox: Omit -rpath on macOS when running parfait, as parfait produces an ../MacOS can't be accessed error and we don't want to run the output from the parfait builds anyway, bugref:3409

Location:

trunk/src/VBox

Files:

• Frontends/VirtualBox/Makefile.kmk (modified) (2 diffs)
• NetworkServices/IntNetSwitch/Makefile.kmk (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/Makefile.kmk

@@ -401 +401 @@
 endif
 
+#
+# Parfait fails with an error that ../MacOS can't be accessed while standard clang has no problem with it.
+# As we don't want to run the output just omit the -rpath arguments to make it build
+#
 VirtualBox_LDFLAGS.darwin = \
-        $(if $(VBOX_WITH_HARDENING),,-rpath @executable_path/../MacOS -rpath @executable_path/../Frameworks) \
+        $(if $(VBOX_WITH_HARDENING) || $(VBOX_WITH_PARFAIT),,-rpath @executable_path/../MacOS -rpath @executable_path/../Frameworks) \
         -framework AppKit -framework Carbon -framework IOKit
 
@@ -432 +436 @@
 endif
 
-VirtualBoxVM_LDFLAGS.darwin = \
-        $(if $(VBOX_WITH_HARDENING) \
-                ,-install_name $(VBOX_DYLD_EXECUTABLE_PATH)/VirtualBoxVM.dylib \
-                ,-rpath @executable_path/../../../../MacOS \
-                -rpath @executable_path/../../../../Frameworks) \
-        -framework AppKit -framework Carbon -framework IOKit
+#
+# Parfait fails with an error that ../MacOS can't be accessed while standard clang has no problem with it.
+# As we don't want to run the output just omit the -rpath arguments to make it build
+#
+ifndef VBOX_WITH_PARFAIT
+ VirtualBoxVM_LDFLAGS.darwin = \
+        $(if $(VBOX_WITH_HARDENING)) \
+                ,-install_name $(VBOX_DYLD_EXECUTABLE_PATH)/VirtualBoxVM.dylib \
+                ,-rpath @executable_path/../../../../MacOS \
+                -rpath @executable_path/../../../../Frameworks) \
+        -framework AppKit -framework Carbon -framework IOKit
+else
+ VirtualBoxVM_LDFLAGS.darwin = -framework AppKit -framework Carbon -framework IOKit
+endif
 
 ifdef VBOX_GUI_WITH_QTGLFRAMEBUFFER

trunk/src/VBox/NetworkServices/IntNetSwitch/Makefile.kmk

@@ -46 +46 @@
         SrvIntNetWrapper.cpp
 VBoxIntNetSwitch_LIBS = $(LIB_RUNTIME)
-VBoxIntNetSwitch_LDFLAGS.darwin = \
-        -rpath @executable_path/../../../../MacOS
+
+#
+# Parfait fails with an error that ../../../../MacOS can't be accessed while standard clang has no problem with it.
+# As we don't want to run the output just omit the -rpath arguments to make it build
+#
+ifndef VBOX_WITH_PARFAIT
+ VBoxIntNetSwitch_LDFLAGS.darwin = \
+        -rpath @executable_path/../../../../MacOS
+endif
 
 ifeq ($(KBUILD_TARGET),darwin)