Changeset 99775 in vbox for trunk/src/VBox/Devices/Graphics

Timestamp:

May 12, 2023 12:21:58 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157370

Message:

*: Mark functions as static if not used outside of a given compilation unit. Enables the compiler to optimize inlining, reduces the symbol tables, exposes unused functions and in some rare cases exposes mismtaches between function declarations and definitions, but most importantly reduces the number of parfait reports for the extern-function-no-forward-declaration category. This should not result in any functional changes, bugref:3409

Location:

trunk/src/VBox/Devices/Graphics

Files:

• DevVGA-SVGA.cpp (modified) (5 diffs)
• DevVGA-SVGA3d-ogl.cpp (modified) (5 diffs)
• DevVGA.cpp (modified) (1 diff)
• HGSMI/HGSMIHost.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA.cpp

@@ -899 +899 @@
  * @param   pThisCC     The VGA/VMSVGA state for ring-3.
  */
-void vmsvgaR3VBVAResize(PVGASTATE pThis, PVGASTATECC pThisCC)
+static void vmsvgaR3VBVAResize(PVGASTATE pThis, PVGASTATECC pThisCC)
 {
     int rc;
@@ -4563 +4563 @@
  * @param   pThisCC     The VGA/VMSVGA state for ring-3.
  */
-void vmsvgaR3FifoPendingActions(PPDMDEVINS pDevIns, PVGASTATE pThis, PVGASTATECC pThisCC)
+static void vmsvgaR3FifoPendingActions(PPDMDEVINS pDevIns, PVGASTATE pThis, PVGASTATECC pThisCC)
 {
     RT_NOREF(pDevIns);
@@ -5393 +5393 @@
  * @callback_method_impl{FNDBGFHANDLERDEV, "vmsvga3dsfc"}
  */
-DECLCALLBACK(void) vmsvgaR3Info3dSurface(PPDMDEVINS pDevIns, PCDBGFINFOHLP pHlp, const char *pszArgs)
+static DECLCALLBACK(void) vmsvgaR3Info3dSurface(PPDMDEVINS pDevIns, PCDBGFINFOHLP pHlp, const char *pszArgs)
 {
     /* There might be a specific surface ID at the start of the
@@ -5438 +5438 @@
  * @callback_method_impl{FNDBGFHANDLERDEV, "vmsvga3dsurf"}
  */
-DECLCALLBACK(void) vmsvgaR3Info3dSurfaceBmp(PPDMDEVINS pDevIns, PCDBGFINFOHLP pHlp, const char *pszArgs)
+static DECLCALLBACK(void) vmsvgaR3Info3dSurfaceBmp(PPDMDEVINS pDevIns, PCDBGFINFOHLP pHlp, const char *pszArgs)
 {
     /* pszArg = "sid[>dir]"
@@ -5463 +5463 @@
  * @callback_method_impl{FNDBGFHANDLERDEV, "vmsvga3dctx"}
  */
-DECLCALLBACK(void) vmsvgaR3Info3dContext(PPDMDEVINS pDevIns, PCDBGFINFOHLP pHlp, const char *pszArgs)
+static DECLCALLBACK(void) vmsvgaR3Info3dContext(PPDMDEVINS pDevIns, PCDBGFINFOHLP pHlp, const char *pszArgs)
 {
     /* There might be a specific surface ID at the start of the

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-ogl.cpp

@@ -3225 +3225 @@
  * @param   pvUser          pointer to pState structure
  */
-DECLCALLBACK(int) vmsvga3dXEventThread(RTTHREAD hThreadSelf, void *pvUser)
+static DECLCALLBACK(int) vmsvga3dXEventThread(RTTHREAD hThreadSelf, void *pvUser)
 {
     RT_NOREF(hThreadSelf);
@@ -5597 +5597 @@
 }
 
-uint32_t vmsvga3dSVGA3dColor2RGBA(SVGA3dColor value)
+#if 0 /* unused */
+static uint32_t vmsvga3dSVGA3dColor2RGBA(SVGA3dColor value)
 {
     /* flip the red and blue bytes */
@@ -5604 +5605 @@
     return (value & 0xff00ff00) | red | (blue << 16);
 }
+#endif
 
 static DECLCALLBACK(int) vmsvga3dBackSetTextureState(PVGASTATECC pThisCC, uint32_t cid, uint32_t cTextureStates, SVGA3dTextureState *pTextureState)
@@ -6426 +6428 @@
 
 /* Convert VMWare vertex declaration to its OpenGL equivalent. */
-int vmsvga3dVertexDecl2OGL(SVGA3dVertexArrayIdentity &identity, GLint &size, GLenum &type, GLboolean &normalized, uint32_t &cbAttrib)
+static int vmsvga3dVertexDecl2OGL(SVGA3dVertexArrayIdentity &identity, GLint &size, GLenum &type, GLboolean &normalized, uint32_t &cbAttrib)
 {
     normalized = GL_FALSE;
@@ -6691 +6693 @@
 /* Convert VMWare primitive type to its OpenGL equivalent. */
 /* Calculate the vertex count based on the primitive type and nr of primitives. */
-int vmsvga3dPrimitiveType2OGL(SVGA3dPrimitiveType PrimitiveType, GLenum *pMode, uint32_t cPrimitiveCount, uint32_t *pcVertices)
+static int vmsvga3dPrimitiveType2OGL(SVGA3dPrimitiveType PrimitiveType, GLenum *pMode, uint32_t cPrimitiveCount, uint32_t *pcVertices)
 {
     switch (PrimitiveType)

trunk/src/VBox/Devices/Graphics/DevVGA.cpp

@@ -576 +576 @@
 }
 
-int vga_ioport_invalid(PVGASTATE pThis, uint32_t addr)
+static int vga_ioport_invalid(PVGASTATE pThis, uint32_t addr)
 {
     if (pThis->msr & MSR_COLOR_EMULATION) {

trunk/src/VBox/Devices/Graphics/HGSMI/HGSMIHost.cpp

@@ -1667 +1667 @@
 }
 
-int hgsmiCompleteGuestCommand(PHGSMIINSTANCE pIns, HGSMIOFFSET offBuffer, bool fDoIrq)
+static int hgsmiCompleteGuestCommand(PHGSMIINSTANCE pIns, HGSMIOFFSET offBuffer, bool fDoIrq)
 {
     int rc = hgsmiGuestCommandComplete(pIns, offBuffer);