Changeset 99775 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

May 12, 2023 12:21:58 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157370

Message:

*: Mark functions as static if not used outside of a given compilation unit. Enables the compiler to optimize inlining, reduces the symbol tables, exposes unused functions and in some rare cases exposes mismtaches between function declarations and definitions, but most importantly reduces the number of parfait reports for the extern-function-no-forward-declaration category. This should not result in any functional changes, bugref:3409

Location:

trunk/src/VBox/Devices/Network

Files:

• DevVirtioNet.cpp (modified) (2 diffs)
• DrvCloudTunnel.cpp (modified) (2 diffs)
• DrvNAT.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Network/DevVirtioNet.cpp

@@ -1580 +1580 @@
  * @param   fOn             New LED state.
  */
-void virtioNetR3SetReadLed(PVIRTIONETR3 pThisR3, bool fOn)
+static void virtioNetR3SetReadLed(PVIRTIONETR3 pThisR3, bool fOn)
 {
     if (fOn)
@@ -1595 +1595 @@
  * @param   fOn            New LED state.
  */
-void virtioNetR3SetWriteLed(PVIRTIONETR3 pThisR3, bool fOn)
+static void virtioNetR3SetWriteLed(PVIRTIONETR3 pThisR3, bool fOn)
 {
     if (fOn)

trunk/src/VBox/Devices/Network/DrvCloudTunnel.cpp

@@ -60 +60 @@
 # define INVALID_SOCKET -1
 # define SOCKET_ERROR   -1
- int WSAGetLastError() { return errno; }
+DECLINLINE(int) WSAGetLastError() { return errno; }
 #endif
 
@@ -1265 +1265 @@
 
 
-DECL_NOTHROW(void) drvCloudTunnelSshLogCallback(int priority, const char *function, const char *buffer, void *userdata)
+static DECL_NOTHROW(void) drvCloudTunnelSshLogCallback(int priority, const char *function, const char *buffer, void *userdata)
 {
     PDRVCLOUDTUNNEL pThis = (PDRVCLOUDTUNNEL)userdata;

trunk/src/VBox/Devices/Network/DrvNAT.cpp

@@ -972 +972 @@
 
 
+#if 0 /* unused */
 /**
  * Function called by slirp to check if it's possible to feed incoming data to the network port.
@@ -983 +984 @@
 }
 
-void slirp_push_recv_thread(void *pvUser)
+static void slirp_push_recv_thread(void *pvUser)
 {
     PDRVNAT pThis = (PDRVNAT)pvUser;
@@ -989 +990 @@
     drvNATUrgRecvWakeup(pThis->pDrvIns, pThis->pUrgRecvThread);
 }
+#endif
 
 void slirp_urg_output(void *pvUser, struct mbuf *m, const uint8_t *pu8Buf, int cb)