Changeset 99775 in vbox for trunk/src/VBox/Devices/Storage

Timestamp:

May 12, 2023 12:21:58 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157370

Message:

*: Mark functions as static if not used outside of a given compilation unit. Enables the compiler to optimize inlining, reduces the symbol tables, exposes unused functions and in some rare cases exposes mismtaches between function declarations and definitions, but most importantly reduces the number of parfait reports for the extern-function-no-forward-declaration category. This should not result in any functional changes, bugref:3409

Location:

trunk/src/VBox/Devices/Storage

Files:

• DevLsiLogicSCSI.cpp (modified) (1 diff)
• DrvRamDisk.cpp (modified) (1 diff)
• DrvVD.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/DevLsiLogicSCSI.cpp

@@ -3438 +3438 @@
  * @todo Generate better SAS addresses. (Request a block from SUN probably)
  */
-void lsilogicSASAddressGenerate(PSASADDRESS pSASAddress, unsigned iId)
+DECLINLINE(void) lsilogicSASAddressGenerate(PSASADDRESS pSASAddress, unsigned iId)
 {
     pSASAddress->u8Address[0] = (0x5 << 5);

trunk/src/VBox/Devices/Storage/DrvRamDisk.cpp

@@ -725 +725 @@
  * @param   rc        Status code to check.
  */
-bool drvramdiskMediaExIoReqIsRedoSetWarning(PDRVRAMDISK pThis, int rc)
+static bool drvramdiskMediaExIoReqIsRedoSetWarning(PDRVRAMDISK pThis, int rc)
 {
     if (rc == VERR_NO_MEMORY)

trunk/src/VBox/Devices/Storage/DrvVD.cpp

@@ -2331 +2331 @@
  * @param   rc        Status code to check.
  */
-bool drvvdMediaExIoReqIsRedoSetWarning(PVBOXDISK pThis, int rc)
+static bool drvvdMediaExIoReqIsRedoSetWarning(PVBOXDISK pThis, int rc)
 {
     if (rc == VERR_DISK_FULL)