Changeset 99775 in vbox for trunk/src/VBox/Frontends/VBoxManage

Timestamp:

May 12, 2023 12:21:58 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157370

Message:

*: Mark functions as static if not used outside of a given compilation unit. Enables the compiler to optimize inlining, reduces the symbol tables, exposes unused functions and in some rare cases exposes mismtaches between function declarations and definitions, but most importantly reduces the number of parfait reports for the extern-function-no-forward-declaration category. This should not result in any functional changes, bugref:3409

Location:

trunk/src/VBox/Frontends/VBoxManage

Files:

• VBoxManage.h (modified) (1 diff)
• VBoxManageControlVM.cpp (modified) (1 diff)
• VBoxManageGuestCtrl.cpp (modified) (2 diffs)
• VBoxManageInfo.cpp (modified) (2 diffs)
• VBoxManageMisc.cpp (modified) (6 diffs)
• VBoxManageSnapshot.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManage.h

@@ -175 +175 @@
 #endif
 RTEXITCODE handleModifyVM(HandlerArg *a);
+VMProcPriority_T nameToVMProcPriority(const char *pszName);
 
 /* VBoxManageDebugVM.cpp */

trunk/src/VBox/Frontends/VBoxManage/VBoxManageControlVM.cpp

@@ -53 +53 @@
 
 DECLARE_TRANSLATION_CONTEXT(ControlVM);
-
-VMProcPriority_T nameToVMProcPriority(const char *pszName);
 
 /**

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp

@@ -370 +370 @@
  * Translates a guest process wait result to a human readable string.
  */
-const char *gctlProcessWaitResultToText(ProcessWaitResult_T enmWaitResult)
+static const char *gctlProcessWaitResultToText(ProcessWaitResult_T enmWaitResult)
 {
     switch (enmWaitResult)
@@ -455 +455 @@
  * Translates a file system objec type to a string.
  */
-const char *gctlFsObjTypeToName(FsObjType_T enmType)
+static const char *gctlFsObjTypeToName(FsObjType_T enmType)
 {
     switch (enmType)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageInfo.cpp

@@ -400 +400 @@
 }
 
-const char *facilityStateToName(AdditionsFacilityStatus_T faStatus, bool fShort)
+static const char *facilityStateToName(AdditionsFacilityStatus_T faStatus, bool fShort)
 {
     switch (faStatus)
@@ -471 +471 @@
  * This simply outputs the string adding necessary escaping and nothing else.
  */
-void outputMachineReadableStringWorker(const char *psz)
+static void outputMachineReadableStringWorker(const char *psz)
 {
     for (;;)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageMisc.cpp

@@ -932 +932 @@
 };
 
-RTEXITCODE handleSetVMEncryption(HandlerArg *a, const char *pszFilenameOrUuid)
+static RTEXITCODE handleSetVMEncryption(HandlerArg *a, const char *pszFilenameOrUuid)
 {
     HRESULT           hrc;
@@ -1065 +1065 @@
 }
 
-RTEXITCODE handleCheckVMPassword(HandlerArg *a, const char *pszFilenameOrUuid)
+static RTEXITCODE handleCheckVMPassword(HandlerArg *a, const char *pszFilenameOrUuid)
 {
     HRESULT hrc;
@@ -1108 +1108 @@
 };
 
-RTEXITCODE handleAddVMPassword(HandlerArg *a, const char *pszFilenameOrUuid)
+static RTEXITCODE handleAddVMPassword(HandlerArg *a, const char *pszFilenameOrUuid)
 {
     HRESULT hrc;
@@ -1189 +1189 @@
 }
 
-RTEXITCODE handleRemoveVMPassword(HandlerArg *a, const char *pszFilenameOrUuid)
+static RTEXITCODE handleRemoveVMPassword(HandlerArg *a, const char *pszFilenameOrUuid)
 {
     HRESULT hrc;
@@ -1967 +1967 @@
 }
 
-RTEXITCODE handleUnattendedDetect(HandlerArg *a)
+static RTEXITCODE handleUnattendedDetect(HandlerArg *a)
 {
     HRESULT hrc;
@@ -2087 +2087 @@
 }
 
-RTEXITCODE handleUnattendedInstall(HandlerArg *a)
+static RTEXITCODE handleUnattendedInstall(HandlerArg *a)
 {
     HRESULT hrc;

trunk/src/VBox/Frontends/VBoxManage/VBoxManageSnapshot.cpp

@@ -60 +60 @@
  * @return
  */
-bool FindAndPrintSnapshotUsingMedium(ComPtr<IMedium> &pMedium,
-                                     ComPtr<ISnapshot> &pThisSnapshot,
-                                     ComPtr<ISnapshot> &pCurrentSnapshot,
-                                     uint32_t uMediumLevel,
-                                     uint32_t uSnapshotLevel)
+static bool FindAndPrintSnapshotUsingMedium(ComPtr<IMedium> &pMedium,
+                                            ComPtr<ISnapshot> &pThisSnapshot,
+                                            ComPtr<ISnapshot> &pCurrentSnapshot,
+                                            uint32_t uMediumLevel,
+                                            uint32_t uSnapshotLevel)
 {
     HRESULT hrc;
@@ -138 +138 @@
  * @param uLevel variant, the recursion level for output indentation.
  */
-void DumpMediumWithChildren(ComPtr<IMedium> &pCurrentStateMedium,
-                            ComPtr<IMedium> &pMedium,
-                            ComPtr<ISnapshot> &pRootSnapshot,
-                            ComPtr<ISnapshot> &pCurrentSnapshot,
-                            uint32_t uLevel)
+static void DumpMediumWithChildren(ComPtr<IMedium> &pCurrentStateMedium,
+                                   ComPtr<IMedium> &pMedium,
+                                   ComPtr<ISnapshot> &pRootSnapshot,
+                                   ComPtr<ISnapshot> &pCurrentSnapshot,
+                                   uint32_t uLevel)
 {
     HRESULT hrc;
@@ -227 +227 @@
  * @param pMachine Machine to dump snapshots for.
  */
-void DumpSnapshot(ComPtr<IMachine> &pMachine)
+static void DumpSnapshot(ComPtr<IMachine> &pMachine)
 {
     HRESULT hrc;