Changeset 99775 in vbox for trunk/src/VBox/Main/testcase

Timestamp:

May 12, 2023 12:21:58 PM (19 months ago)

Author:

vboxsync

Message:

*: Mark functions as static if not used outside of a given compilation unit. Enables the compiler to optimize inlining, reduces the symbol tables, exposes unused functions and in some rare cases exposes mismtaches between function declarations and definitions, but most importantly reduces the number of parfait reports for the extern-function-no-forward-declaration category. This should not result in any functional changes, bugref:3409

Location:

trunk/src/VBox/Main/testcase

Files:

• tstAPI.cpp (modified) (2 diffs)
• tstCollector.cpp (modified) (5 diffs)
• tstOVF.cpp (modified) (2 diffs)
• tstVBoxAPIXPCOM.cpp (modified) (2 diffs)

trunk/src/VBox/Main/testcase/tstAPI.cpp

@@ -65 +65 @@
 ///////////////////////////////////////////////////////////////////////////////
 
-HRESULT readAndChangeMachineSettings(IMachine *machine, IMachine *readonlyMachine = 0)
+#if 0 /* unused */
+static HRESULT readAndChangeMachineSettings(IMachine *machine, IMachine *readonlyMachine = 0)
 {
     HRESULT hrc = S_OK;
@@ -199 +200 @@
     return hrc;
 }
+#endif
 
 // main

trunk/src/VBox/Main/testcase/tstCollector.cpp

@@ -82 +82 @@
   } while (0)
 
-void shutdownProcessList(std::vector<RTPROCESS> const &rProcesses)
+static void shutdownProcessList(std::vector<RTPROCESS> const &rProcesses)
 {
     for (size_t i = 0; i < rProcesses.size(); i++)
@@ -88 +88 @@
 }
 
-void measurePerformance(pm::CollectorHAL *collector, const char *pszName, int cVMs)
+static void measurePerformance(pm::CollectorHAL *collector, const char *pszName, int cVMs)
 {
 
@@ -164 +164 @@
 #define NETIFNAME "eth0"
 #endif
-int testNetwork(pm::CollectorHAL *collector)
+static int testNetwork(pm::CollectorHAL *collector)
 {
     pm::CollectorHints hints;
@@ -222 +222 @@
 
 #define FSNAME "/"
-int testFsUsage(pm::CollectorHAL *collector)
+static int testFsUsage(pm::CollectorHAL *collector)
 {
     RTPrintf("tstCollector: TESTING - File system usage\n");
@@ -245 +245 @@
 }
 
-int testDisk(pm::CollectorHAL *collector)
+static int testDisk(pm::CollectorHAL *collector)
 {
     pm::CollectorHints hints;

trunk/src/VBox/Main/testcase/tstOVF.cpp

@@ -89 +89 @@
  * @param llMachinesCreated out: UUIDs of machines that were created so that caller can clean up.
  */
-void importOVF(const char *pcszPrefix,
-               ComPtr<IVirtualBox> &pVirtualBox,
-               const char *pcszOVF0,
-               std::list<Guid> &llMachinesCreated)
+static void importOVF(const char *pcszPrefix,
+                      ComPtr<IVirtualBox> &pVirtualBox,
+                      const char *pcszOVF0,
+                      std::list<Guid> &llMachinesCreated)
 {
     char szAbsOVF[RTPATH_MAX];
@@ -289 +289 @@
  * @param pcszDest Target for dummy VMDK.
  */
-void copyDummyDiskImage(const char *pcszPrefix,
-                        std::list<Utf8Str> &llFiles2Delete,
-                        const char *pcszDest)
+static void copyDummyDiskImage(const char *pcszPrefix,
+                               std::list<Utf8Str> &llFiles2Delete,
+                               const char *pcszDest)
 {
     char szSrc[RTPATH_MAX];

trunk/src/VBox/Main/testcase/tstVBoxAPIXPCOM.cpp

@@ -104 +104 @@
  * @param virtualBox VirtualBox instance object.
  */
-void listVMs(IVirtualBox *virtualBox)
+static void listVMs(IVirtualBox *virtualBox)
 {
     nsresult rc;
@@ -188 +188 @@
  * @param virtualBox VirtualBox instance object.
  */
-void createVM(IVirtualBox *virtualBox)
+static void createVM(IVirtualBox *virtualBox)
 {
     nsresult rc;