Changeset 99775 in vbox for trunk/src/VBox/Runtime/common/misc

Timestamp:

May 12, 2023 12:21:58 PM (22 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157370

Message:

*: Mark functions as static if not used outside of a given compilation unit. Enables the compiler to optimize inlining, reduces the symbol tables, exposes unused functions and in some rare cases exposes mismtaches between function declarations and definitions, but most importantly reduces the number of parfait reports for the extern-function-no-forward-declaration category. This should not result in any functional changes, bugref:3409

Location:

trunk/src/VBox/Runtime/common/misc

Files:

• lockvalidator.cpp (modified) (1 diff)
• thread.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/common/misc/lockvalidator.cpp

@@ -956 +956 @@
  * Call after rtLockValidatorSerializeDetectionEnter.
  */
-DECLHIDDEN(void) rtLockValidatorSerializeDetectionLeave(void)
+DECLINLINE(void) rtLockValidatorSerializeDetectionLeave(void)
 {
     RTSEMXROADS hXRoads = g_hLockValidatorXRoads;

trunk/src/VBox/Runtime/common/misc/thread.cpp

@@ -1195 +1195 @@
 #ifdef IN_RING3
 
+#if 0 /* unused */
 /**
  * Recalculates scheduling attributes for the default process
@@ -1206 +1207 @@
  * @remarks Will only work for strict builds.
  */
-int rtThreadDoCalcDefaultPriority(RTTHREADTYPE enmType)
+static int rtThreadDoCalcDefaultPriority(RTTHREADTYPE enmType)
 {
     RT_THREAD_LOCK_RW();
@@ -1213 +1214 @@
     return rc;
 }
+#endif