VirtualBox

Changeset 99775 in vbox for trunk/src/VBox/VMM


Ignore:
Timestamp:
May 12, 2023 12:21:58 PM (21 months ago)
Author:
vboxsync
Message:

*: Mark functions as static if not used outside of a given compilation unit. Enables the compiler to optimize inlining, reduces the symbol tables, exposes unused functions and in some rare cases exposes mismtaches between function declarations and definitions, but most importantly reduces the number of parfait reports for the extern-function-no-forward-declaration category. This should not result in any functional changes, bugref:3409

Location:
trunk/src/VBox/VMM
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/VBox/VMM/VMMR3/CPUM.cpp

    r99739 r99775  
    11841184 * @param   pszArgs     "terse", "default" or "verbose".
    11851185 */
    1186 DECLCALLBACK(void) cpumR3InfoVmxFeatures(PVM pVM, PCDBGFINFOHLP pHlp, const char *pszArgs)
     1186static DECLCALLBACK(void) cpumR3InfoVmxFeatures(PVM pVM, PCDBGFINFOHLP pHlp, const char *pszArgs)
    11871187{
    11881188    RT_NOREF(pszArgs);

  • trunk/src/VBox/VMM/VMMR3/CPUMR3CpuId.cpp

    r98827 r99775  
    39663966 * @param   pMsrs               The guest MSRs.
    39673967 */
    3968 int cpumR3LoadCpuIdInner(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, PCPUMCPUIDLEAF paLeaves, uint32_t cLeaves, PCCPUMMSRS pMsrs)
     3968static int cpumR3LoadCpuIdInner(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, PCPUMCPUIDLEAF paLeaves, uint32_t cLeaves, PCCPUMMSRS pMsrs)
    39693969{
    39703970    AssertMsgReturn(uVersion >= CPUM_SAVED_STATE_VERSION_VER3_2, ("%u\n", uVersion), VERR_SSM_UNSUPPORTED_DATA_UNIT_VERSION);
    … …  
    47034703 * Get L2 cache associativity.
    47044704 */
    4705 const char *getL2CacheAss(unsigned u)
     4705static const char *getL2CacheAss(unsigned u)
    47064706{
    47074707    switch (u)

  • trunk/src/VBox/VMM/VMMR3/DBGF.cpp

    r99739 r99775  
    286286 * @thread  EMT(pVCpu)
    287287 */
    288 bool dbgfR3WaitForAttach(PVM pVM, PVMCPU pVCpu, DBGFEVENTTYPE enmEvent)
     288static bool dbgfR3WaitForAttach(PVM pVM, PVMCPU pVCpu, DBGFEVENTTYPE enmEvent)
    289289{
    290290    /*

  • trunk/src/VBox/VMM/VMMR3/DBGFR3ModInMem.cpp

    r98103 r99775  
    145145 * @param   cbBuf           Size of buffer.
    146146 */
    147 const char *dbgfR3ModNormalizeName(const char *pszName, char *pszBuf, size_t cbBuf)
     147static const char *dbgfR3ModNormalizeName(const char *pszName, char *pszBuf, size_t cbBuf)
    148148{
    149149    /*

  • trunk/src/VBox/VMM/VMMR3/DBGFR3Tracer.cpp

    r99739 r99775  
    924924 * @param   ppDbgfTracerR3          Where to store the pointer to the tracer on success.
    925925 */
    926 DECLHIDDEN(int) dbgfR3TracerCreate(PVM pVM, bool fR0Enabled, const char *pszTraceFilePath,
    927                                    uint32_t cbRingBuf, PDBGFTRACERINSR3 *ppDbgfTracerR3)
     926static int dbgfR3TracerCreate(PVM pVM, bool fR0Enabled, const char *pszTraceFilePath,
     927                              uint32_t cbRingBuf, PDBGFTRACERINSR3 *ppDbgfTracerR3)
    928928{
    929929    PDBGFTRACERINSR3 pThis = NULL;

  • trunk/src/VBox/VMM/VMMR3/PDMAsyncCompletion.cpp

    r99739 r99775  
    835835 * @param   pCfgHandle  Pointer to the CFGM tree.
    836836 */
    837 int pdmR3AsyncCompletionEpClassInit(PVM pVM, PCPDMASYNCCOMPLETIONEPCLASSOPS pEpClassOps, PCFGMNODE pCfgHandle)
     837static int pdmR3AsyncCompletionEpClassInit(PVM pVM, PCPDMASYNCCOMPLETIONEPCLASSOPS pEpClassOps, PCFGMNODE pCfgHandle)
    838838{
    839839    /* Validate input. */

  • trunk/src/VBox/VMM/VMMR3/PDMAsyncCompletionFile.cpp

    r99739 r99775  
    393393}
    394394
    395 int pdmacFileEpTaskInitiate(PPDMASYNCCOMPLETIONTASK pTask,
    396                             PPDMASYNCCOMPLETIONENDPOINT pEndpoint, RTFOFF off,
    397                             PCRTSGSEG paSegments, size_t cSegments,
    398                             size_t cbTransfer, PDMACTASKFILETRANSFER enmTransfer)
     395static int pdmacFileEpTaskInitiate(PPDMASYNCCOMPLETIONTASK pTask,
     396                                   PPDMASYNCCOMPLETIONENDPOINT pEndpoint, RTFOFF off,
     397                                   PCRTSGSEG paSegments, size_t cSegments,
     398                                   size_t cbTransfer, PDMACTASKFILETRANSFER enmTransfer)
    399399{
    400400    PPDMASYNCCOMPLETIONENDPOINTFILE pEpFile = (PPDMASYNCCOMPLETIONENDPOINTFILE)pEndpoint;

  • trunk/src/VBox/VMM/VMMR3/PDMLdr.cpp

    r98103 r99775  
    11011101 *                          case the arch dependent install dir is searched.
    11021102 */
    1103 char *pdmR3FileR0(const char *pszFile, const char *pszSearchPath)
     1103static char *pdmR3FileR0(const char *pszFile, const char *pszSearchPath)
    11041104{
    11051105    return pdmR3File(pszFile, NULL, pszSearchPath, /*fShared=*/false);
    … …  
    11071107
    11081108
     1109#if 0 /* unused */
    11091110/**
    11101111 * Constructs the full filename for a RC image file.
    … …  
    11191120 *                          case the arch dependent install dir is searched.
    11201121 */
    1121 char *pdmR3FileRC(const char *pszFile, const char *pszSearchPath)
     1122static char *pdmR3FileRC(const char *pszFile, const char *pszSearchPath)
    11221123{
    11231124    return pdmR3File(pszFile, NULL, pszSearchPath, /*fShared=*/false);
    11241125}
     1126#endif
    11251127
    11261128

  • trunk/src/VBox/VMM/testcase/tstIEMAImpl.cpp

    r98822 r99775  
    756756
    757757
    758 const char *GenFormatR80(PCRTFLOAT80U plrd)
     758static const char *GenFormatR80(PCRTFLOAT80U plrd)
    759759{
    760760    if (RTFLOAT80U_IS_ZERO(plrd))
    … …  
    775775}
    776776
    777 const char *GenFormatR64(PCRTFLOAT64U prd)
     777static const char *GenFormatR64(PCRTFLOAT64U prd)
    778778{
    779779    char *pszBuf = g_aszBuf[g_idxBuf++ % RT_ELEMENTS(g_aszBuf)];
    … …  
    784784
    785785
    786 const char *GenFormatR32(PCRTFLOAT32U pr)
     786static const char *GenFormatR32(PCRTFLOAT32U pr)
    787787{
    788788    char *pszBuf = g_aszBuf[g_idxBuf++ % RT_ELEMENTS(g_aszBuf)];
    … …  
    792792
    793793
    794 const char *GenFormatD80(PCRTPBCD80U pd80)
     794static const char *GenFormatD80(PCRTPBCD80U pd80)
    795795{
    796796    char *pszBuf = g_aszBuf[g_idxBuf++ % RT_ELEMENTS(g_aszBuf)];
    … …  
    811811
    812812
    813 const char *GenFormatI64(int64_t i64)
     813static const char *GenFormatI64(int64_t i64)
    814814{
    815815    if (i64 == INT64_MIN) /* This one is problematic */
    … …  
    822822}
    823823
    824 
    825 const char *GenFormatI64(int64_t const *pi64)
     824#if 0 /* unused */
     825static const char *GenFormatI64(int64_t const *pi64)
    826826{
    827827    return GenFormatI64(*pi64);
    828828}
    829 
    830 
    831 const char *GenFormatI32(int32_t i32)
     829#endif
     830
     831static const char *GenFormatI32(int32_t i32)
    832832{
    833833    if (i32 == INT32_MIN) /* This one is problematic */
    … …  
    18611861#ifdef TSTIEMAIMPL_WITH_GENERATOR
    18621862# define GEN_SHIFT_DBL(a_cBits, a_Fmt, a_TestType, a_aSubTests) \
    1863 void ShiftDblU ## a_cBits ## Generate(PRTSTREAM pOut, uint32_t cTests) \
     1863static void ShiftDblU ## a_cBits ## Generate(PRTSTREAM pOut, uint32_t cTests) \
    18641864{ \
    18651865    for (size_t iFn = 0; iFn < RT_ELEMENTS(a_aSubTests); iFn++) \
    … …  
    19671967#ifdef TSTIEMAIMPL_WITH_GENERATOR
    19681968# define GEN_UNARY(a_cBits, a_Type, a_Fmt, a_TestType, a_SubTestType) \
    1969 void UnaryU ## a_cBits ## Generate(PRTSTREAM pOut, uint32_t cTests) \
     1969static void UnaryU ## a_cBits ## Generate(PRTSTREAM pOut, uint32_t cTests) \
    19701970{ \
    19711971    for (size_t iFn = 0; iFn < RT_ELEMENTS(g_aUnaryU ## a_cBits); iFn++) \
    … …  
    20692069#ifdef TSTIEMAIMPL_WITH_GENERATOR
    20702070# define GEN_SHIFT(a_cBits, a_Fmt, a_TestType, a_aSubTests) \
    2071 void ShiftU ## a_cBits ## Generate(PRTSTREAM pOut, uint32_t cTests) \
     2071static void ShiftU ## a_cBits ## Generate(PRTSTREAM pOut, uint32_t cTests) \
    20722072{ \
    20732073    for (size_t iFn = 0; iFn < RT_ELEMENTS(a_aSubTests); iFn++) \

  • trunk/src/VBox/VMM/testcase/tstSSM.cpp

    r98103 r99775  
    7777
    7878/** initializes gabBigMem with some non zero stuff. */
    79 void initBigMem(void)
     79static void initBigMem(void)
    8080{
    8181#if 0
    … …  
    112112 * @param   pSSM            SSM operation handle.
    113113 */
    114 DECLCALLBACK(int) Item01Save(PVM pVM, PSSMHANDLE pSSM)
     114static DECLCALLBACK(int) Item01Save(PVM pVM, PSSMHANDLE pSSM)
    115115{
    116116    uint64_t u64Start = RTTimeNanoTS();
    … …  
    197197 * @param   uPass           The data pass.
    198198 */
    199 DECLCALLBACK(int) Item01Load(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, uint32_t uPass)
     199static DECLCALLBACK(int) Item01Load(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, uint32_t uPass)
    200200{
    201201    NOREF(pVM); NOREF(uPass);
    … …  
    291291 * @param   pSSM            SSM operation handle.
    292292 */
    293 DECLCALLBACK(int) Item02Save(PVM pVM, PSSMHANDLE pSSM)
     293static DECLCALLBACK(int) Item02Save(PVM pVM, PSSMHANDLE pSSM)
    294294{
    295295    NOREF(pVM);
    … …  
    355355 * @param   uPass           The data pass.
    356356 */
    357 DECLCALLBACK(int) Item02Load(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, uint32_t uPass)
     357static DECLCALLBACK(int) Item02Load(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, uint32_t uPass)
    358358{
    359359    NOREF(pVM); NOREF(uPass);
    … …  
    421421 * @param   pSSM            SSM operation handle.
    422422 */
    423 DECLCALLBACK(int) Item03Save(PVM pVM, PSSMHANDLE pSSM)
     423static DECLCALLBACK(int) Item03Save(PVM pVM, PSSMHANDLE pSSM)
    424424{
    425425    NOREF(pVM);
    … …  
    471471 * @param   uPass           The data pass.
    472472 */
    473 DECLCALLBACK(int) Item03Load(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, uint32_t uPass)
     473static DECLCALLBACK(int) Item03Load(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, uint32_t uPass)
    474474{
    475475    NOREF(pVM); NOREF(uPass);
    … …  
    533533 * @param   pSSM            SSM operation handle.
    534534 */
    535 DECLCALLBACK(int) Item04Save(PVM pVM, PSSMHANDLE pSSM)
     535static DECLCALLBACK(int) Item04Save(PVM pVM, PSSMHANDLE pSSM)
    536536{
    537537    NOREF(pVM);
    … …  
    579579 * @param   uPass           The data pass.
    580580 */
    581 DECLCALLBACK(int) Item04Load(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, uint32_t uPass)
     581static DECLCALLBACK(int) Item04Load(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, uint32_t uPass)
    582582{
    583583    NOREF(pVM); NOREF(uPass);

  • trunk/src/VBox/VMM/testcase/tstVMMR0CallHost-1.cpp

    r98103 r99775  
    6262
    6363
    64 int foo(int i, int iZero, int iMinusOne)
     64static int foo(int i, int iZero, int iMinusOne)
    6565{
    6666    NOREF(iZero);
    … …  
    9595
    9696
    97 DECLCALLBACK(int) tst2(intptr_t i, intptr_t i2)
     97static DECLCALLBACK(int) tst2(intptr_t i, intptr_t i2)
    9898{
    9999    RTTESTI_CHECK_MSG_RET(i >= 0 && i <= 8192, ("i=%d is out of range [0..8192]\n", i),      1);
    … …  
    106106
    107107
    108 DECLCALLBACK(DECL_NO_INLINE(RT_NOTHING, int)) stackRandom(PVMMR0JMPBUF pJmpBuf, PFNVMMR0SETJMP pfn, PVM pVM, PVMCPU pVCpu)
     108static DECLCALLBACK(DECL_NO_INLINE(RT_NOTHING, int)) stackRandom(PVMMR0JMPBUF pJmpBuf, PFNVMMR0SETJMP pfn, PVM pVM, PVMCPU pVCpu)
    109109{
    110110#ifdef RT_ARCH_AMD64
    … …  
    121121
    122122
    123 void tst(int iFrom, int iTo, int iInc)
     123static void tst(int iFrom, int iTo, int iInc)
    124124{
    125125    RT_BZERO(&g_Jmp, RT_UOFFSETOF(VMMR0JMPBUF, cbStackBuf));
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette