Changeset 99775 in vbox for trunk/src/VBox/VMM/VMMR3

Timestamp:

May 12, 2023 12:21:58 PM (22 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157370

Message:

*: Mark functions as static if not used outside of a given compilation unit. Enables the compiler to optimize inlining, reduces the symbol tables, exposes unused functions and in some rare cases exposes mismtaches between function declarations and definitions, but most importantly reduces the number of parfait reports for the extern-function-no-forward-declaration category. This should not result in any functional changes, bugref:3409

Location:

trunk/src/VBox/VMM/VMMR3

Files:

• CPUM.cpp (modified) (1 diff)
• CPUMR3CpuId.cpp (modified) (2 diffs)
• DBGF.cpp (modified) (1 diff)
• DBGFR3ModInMem.cpp (modified) (1 diff)
• DBGFR3Tracer.cpp (modified) (1 diff)
• PDMAsyncCompletion.cpp (modified) (1 diff)
• PDMAsyncCompletionFile.cpp (modified) (1 diff)
• PDMLdr.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMR3/CPUM.cpp

@@ -1184 +1184 @@
  * @param   pszArgs     "terse", "default" or "verbose".
  */
-DECLCALLBACK(void) cpumR3InfoVmxFeatures(PVM pVM, PCDBGFINFOHLP pHlp, const char *pszArgs)
+static DECLCALLBACK(void) cpumR3InfoVmxFeatures(PVM pVM, PCDBGFINFOHLP pHlp, const char *pszArgs)
 {
     RT_NOREF(pszArgs);

trunk/src/VBox/VMM/VMMR3/CPUMR3CpuId.cpp

@@ -3966 +3966 @@
  * @param   pMsrs               The guest MSRs.
  */
-int cpumR3LoadCpuIdInner(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, PCPUMCPUIDLEAF paLeaves, uint32_t cLeaves, PCCPUMMSRS pMsrs)
+static int cpumR3LoadCpuIdInner(PVM pVM, PSSMHANDLE pSSM, uint32_t uVersion, PCPUMCPUIDLEAF paLeaves, uint32_t cLeaves, PCCPUMMSRS pMsrs)
 {
     AssertMsgReturn(uVersion >= CPUM_SAVED_STATE_VERSION_VER3_2, ("%u\n", uVersion), VERR_SSM_UNSUPPORTED_DATA_UNIT_VERSION);
@@ -4703 +4703 @@
  * Get L2 cache associativity.
  */
-const char *getL2CacheAss(unsigned u)
+static const char *getL2CacheAss(unsigned u)
 {
     switch (u)

trunk/src/VBox/VMM/VMMR3/DBGF.cpp

@@ -286 +286 @@
  * @thread  EMT(pVCpu)
  */
-bool dbgfR3WaitForAttach(PVM pVM, PVMCPU pVCpu, DBGFEVENTTYPE enmEvent)
+static bool dbgfR3WaitForAttach(PVM pVM, PVMCPU pVCpu, DBGFEVENTTYPE enmEvent)
 {
     /*

trunk/src/VBox/VMM/VMMR3/DBGFR3ModInMem.cpp

@@ -145 +145 @@
  * @param   cbBuf           Size of buffer.
  */
-const char *dbgfR3ModNormalizeName(const char *pszName, char *pszBuf, size_t cbBuf)
+static const char *dbgfR3ModNormalizeName(const char *pszName, char *pszBuf, size_t cbBuf)
 {
     /*

trunk/src/VBox/VMM/VMMR3/DBGFR3Tracer.cpp

@@ -924 +924 @@
  * @param   ppDbgfTracerR3          Where to store the pointer to the tracer on success.
  */
-DECLHIDDEN(int) dbgfR3TracerCreate(PVM pVM, bool fR0Enabled, const char *pszTraceFilePath,
-                                   uint32_t cbRingBuf, PDBGFTRACERINSR3 *ppDbgfTracerR3)
+static int dbgfR3TracerCreate(PVM pVM, bool fR0Enabled, const char *pszTraceFilePath,
+                              uint32_t cbRingBuf, PDBGFTRACERINSR3 *ppDbgfTracerR3)
 {
     PDBGFTRACERINSR3 pThis = NULL;

trunk/src/VBox/VMM/VMMR3/PDMAsyncCompletion.cpp

@@ -835 +835 @@
  * @param   pCfgHandle  Pointer to the CFGM tree.
  */
-int pdmR3AsyncCompletionEpClassInit(PVM pVM, PCPDMASYNCCOMPLETIONEPCLASSOPS pEpClassOps, PCFGMNODE pCfgHandle)
+static int pdmR3AsyncCompletionEpClassInit(PVM pVM, PCPDMASYNCCOMPLETIONEPCLASSOPS pEpClassOps, PCFGMNODE pCfgHandle)
 {
     /* Validate input. */

trunk/src/VBox/VMM/VMMR3/PDMAsyncCompletionFile.cpp

@@ -393 +393 @@
 }
 
-int pdmacFileEpTaskInitiate(PPDMASYNCCOMPLETIONTASK pTask,
-                            PPDMASYNCCOMPLETIONENDPOINT pEndpoint, RTFOFF off,
-                            PCRTSGSEG paSegments, size_t cSegments,
-                            size_t cbTransfer, PDMACTASKFILETRANSFER enmTransfer)
+static int pdmacFileEpTaskInitiate(PPDMASYNCCOMPLETIONTASK pTask,
+                                   PPDMASYNCCOMPLETIONENDPOINT pEndpoint, RTFOFF off,
+                                   PCRTSGSEG paSegments, size_t cSegments,
+                                   size_t cbTransfer, PDMACTASKFILETRANSFER enmTransfer)
 {
     PPDMASYNCCOMPLETIONENDPOINTFILE pEpFile = (PPDMASYNCCOMPLETIONENDPOINTFILE)pEndpoint;

trunk/src/VBox/VMM/VMMR3/PDMLdr.cpp

@@ -1101 +1101 @@
  *                          case the arch dependent install dir is searched.
  */
-char *pdmR3FileR0(const char *pszFile, const char *pszSearchPath)
+static char *pdmR3FileR0(const char *pszFile, const char *pszSearchPath)
 {
     return pdmR3File(pszFile, NULL, pszSearchPath, /*fShared=*/false);
@@ -1107 +1107 @@
 
 
+#if 0 /* unused */
 /**
  * Constructs the full filename for a RC image file.
@@ -1119 +1120 @@
  *                          case the arch dependent install dir is searched.
  */
-char *pdmR3FileRC(const char *pszFile, const char *pszSearchPath)
+static char *pdmR3FileRC(const char *pszFile, const char *pszSearchPath)
 {
     return pdmR3File(pszFile, NULL, pszSearchPath, /*fShared=*/false);
 }
+#endif