Changeset 99775 in vbox for trunk/src/VBox/ValidationKit/utils/audio

Timestamp:

May 12, 2023 12:21:58 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157370

Message:

*: Mark functions as static if not used outside of a given compilation unit. Enables the compiler to optimize inlining, reduces the symbol tables, exposes unused functions and in some rare cases exposes mismtaches between function declarations and definitions, but most importantly reduces the number of parfait reports for the extern-function-no-forward-declaration category. This should not result in any functional changes, bugref:3409

Location:

trunk/src/VBox/ValidationKit/utils/audio

Files:

• vkatCmdSelfTest.cpp (modified) (2 diffs)
• vkatCommon.cpp (modified) (3 diffs)
• vkatDriverStack.cpp (modified) (10 diffs)

trunk/src/VBox/ValidationKit/utils/audio/vkatCmdSelfTest.cpp

@@ -238 +238 @@
  * @param   pCtx                Self test context to use.
  */
-RTEXITCODE audioTestDoSelftest(PSELFTESTCTX pCtx)
+static RTEXITCODE audioTestDoSelftest(PSELFTESTCTX pCtx)
 {
     RTTestPrintf(g_hTest, RTTESTLVL_ALWAYS,  "Running self test ...\n");
@@ -367 +367 @@
  * @param   pGetState   RTGetOpt state.
  */
-DECLCALLBACK(RTEXITCODE) audioTestCmdSelftestHandler(PRTGETOPTSTATE pGetState)
+static DECLCALLBACK(RTEXITCODE) audioTestCmdSelftestHandler(PRTGETOPTSTATE pGetState)
 {
     RT_ZERO(g_Ctx);

trunk/src/VBox/ValidationKit/utils/audio/vkatCommon.cpp

@@ -246 +246 @@
  * @param   uVolPercent         Volume (in percent) to set.
  */
-int audioTestSetMasterVolume(unsigned uVolPercent)
+static int audioTestSetMasterVolume(unsigned uVolPercent)
 {
     int rc = VINF_SUCCESS;
@@ -1312 +1312 @@
  * @param   pTcpOpts            Pointer to TCP options to use.
  */
-int audioTestEnvConnectViaTcp(PAUDIOTESTENV pTstEnv, PATSCLIENT pClient, const char *pszWhat, PAUDIOTESTENVTCPOPTS pTcpOpts)
+static int audioTestEnvConnectViaTcp(PAUDIOTESTENV pTstEnv, PATSCLIENT pClient, const char *pszWhat, PAUDIOTESTENVTCPOPTS pTcpOpts)
 {
     RT_NOREF(pTstEnv);
@@ -1392 +1392 @@
  * @param   pTcpOpts            TCP options to use.
  */
-int audioTestEnvConfigureAndStartTcpServer(PATSSERVER pSrv, PCATSCALLBACKS pCallbacks, const char *pszDesc,
-                                           PAUDIOTESTENVTCPOPTS pTcpOpts)
+static int audioTestEnvConfigureAndStartTcpServer(PATSSERVER pSrv, PCATSCALLBACKS pCallbacks, const char *pszDesc,
+                                                  PAUDIOTESTENVTCPOPTS pTcpOpts)
 {
     RTGETOPTUNION Val;

trunk/src/VBox/ValidationKit/utils/audio/vkatDriverStack.cpp

@@ -74 +74 @@
  * @{  */
 
-VMMR3DECL(PCFGMNODE) audioTestDrvHlp_CFGMR3GetChild(PCFGMNODE pNode, const char *pszPath)
+static DECLCALLBACK(PCFGMNODE) audioTestDrvHlp_CFGMR3GetChild(PCFGMNODE pNode, const char *pszPath)
 {
     RT_NOREF(pNode, pszPath);
@@ -81 +81 @@
 
 
-VMMR3DECL(int) audioTestDrvHlp_CFGMR3QueryString(PCFGMNODE pNode, const char *pszName, char *pszString, size_t cchString)
+static DECLCALLBACK(int) audioTestDrvHlp_CFGMR3QueryString(PCFGMNODE pNode, const char *pszName, char *pszString, size_t cchString)
 {
     if (pNode != NULL)
@@ -105 +105 @@
 
 
-VMMR3DECL(int) audioTestDrvHlp_CFGMR3QueryStringAlloc(PCFGMNODE pNode, const char *pszName, char **ppszString)
+static DECLCALLBACK(int) audioTestDrvHlp_CFGMR3QueryStringAlloc(PCFGMNODE pNode, const char *pszName, char **ppszString)
 {
     char szStr[128];
@@ -116 +116 @@
 
 
-VMMR3DECL(void) audioTestDrvHlp_MMR3HeapFree(PPDMDRVINS pDrvIns, void *pv)
+static DECLCALLBACK(void) audioTestDrvHlp_MMR3HeapFree(PPDMDRVINS pDrvIns, void *pv)
 {
     RT_NOREF(pDrvIns);
@@ -125 +125 @@
 
 
-VMMR3DECL(int) audioTestDrvHlp_CFGMR3QueryStringDef(PCFGMNODE pNode, const char *pszName, char *pszString, size_t cchString, const char *pszDef)
+static DECLCALLBACK(int) audioTestDrvHlp_CFGMR3QueryStringDef(PCFGMNODE pNode, const char *pszName, char *pszString, size_t cchString, const char *pszDef)
 {
     PCPDMDRVREG pDrvReg = (PCPDMDRVREG)pNode;
@@ -150 +150 @@
 
 
-VMMR3DECL(int) audioTestDrvHlp_CFGMR3QueryBoolDef(PCFGMNODE pNode, const char *pszName, bool *pf, bool fDef)
+static DECLCALLBACK(int) audioTestDrvHlp_CFGMR3QueryBoolDef(PCFGMNODE pNode, const char *pszName, bool *pf, bool fDef)
 {
     PCPDMDRVREG pDrvReg = (PCPDMDRVREG)pNode;
@@ -169 +169 @@
 
 
-VMMR3DECL(int) audioTestDrvHlp_CFGMR3QueryU8(PCFGMNODE pNode, const char *pszName, uint8_t *pu8)
+static DECLCALLBACK(int) audioTestDrvHlp_CFGMR3QueryU8(PCFGMNODE pNode, const char *pszName, uint8_t *pu8)
 {
     RT_NOREF(pNode, pszName, pu8);
@@ -176 +176 @@
 
 
-VMMR3DECL(int) audioTestDrvHlp_CFGMR3QueryU32(PCFGMNODE pNode, const char *pszName, uint32_t *pu32)
+static DECLCALLBACK(int) audioTestDrvHlp_CFGMR3QueryU32(PCFGMNODE pNode, const char *pszName, uint32_t *pu32)
 {
     RT_NOREF(pNode, pszName, pu32);
@@ -183 +183 @@
 
 
-VMMR3DECL(int) audioTestDrvHlp_CFGMR3ValidateConfig(PCFGMNODE pNode, const char *pszNode,
-                                                    const char *pszValidValues, const char *pszValidNodes,
-                                                    const char *pszWho, uint32_t uInstance)
+static DECLCALLBACK(int) audioTestDrvHlp_CFGMR3ValidateConfig(PCFGMNODE pNode, const char *pszNode,
+                                                              const char *pszValidValues, const char *pszValidNodes,
+                                                              const char *pszWho, uint32_t uInstance)
 {
     RT_NOREF(pNode, pszNode, pszValidValues, pszValidNodes, pszWho, uInstance);
@@ -321 +321 @@
 
 
-DECLCALLBACK(void) audioTestIHostAudioPort_NotifyDeviceChanged(PPDMIHOSTAUDIOPORT pInterface, PDMAUDIODIR enmDir, void *pvUser)
+static DECLCALLBACK(void) audioTestIHostAudioPort_NotifyDeviceChanged(PPDMIHOSTAUDIOPORT pInterface, PDMAUDIODIR enmDir, void *pvUser)
 {
     RT_NOREF(pInterface, enmDir, pvUser);