Changeset 99775 in vbox for trunk/src/VBox/ValidationKit/utils/cpu

Timestamp:

May 12, 2023 12:21:58 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157370

Message:

*: Mark functions as static if not used outside of a given compilation unit. Enables the compiler to optimize inlining, reduces the symbol tables, exposes unused functions and in some rare cases exposes mismtaches between function declarations and definitions, but most importantly reduces the number of parfait reports for the extern-function-no-forward-declaration category. This should not result in any functional changes, bugref:3409

File:

• trunk/src/VBox/ValidationKit/utils/cpu/cidet-core.cpp (modified) (23 diffs)

trunk/src/VBox/ValidationKit/utils/cpu/cidet-core.cpp

@@ -139 +139 @@
 
 
-bool CidetInstrHasMrmMemOperand(PCCIDETINSTR pInstr)
+static bool CidetInstrHasMrmMemOperand(PCCIDETINSTR pInstr)
 {
     return CIDET_INSTR_TEST_OP_FLAG(pInstr, CIDET_OF_M_RM_ONLY_M);
@@ -145 +145 @@
 
 
-bool CidetInstrHasMrmRegOperand(PCCIDETINSTR pInstr)
+static bool CidetInstrHasMrmRegOperand(PCCIDETINSTR pInstr)
 {
     return CIDET_INSTR_TEST_OP_FLAG(pInstr, CIDET_OF_M_RM_ONLY_R);
@@ -151 +151 @@
 
 
-bool CidetInstrRespondsToOperandSizePrefixes(PCCIDETINSTR pInstr)
+static bool CidetInstrRespondsToOperandSizePrefixes(PCCIDETINSTR pInstr)
 {
     return CIDET_INSTR_TEST_OP_MASK_VALUE(pInstr, CIDET_OF_Z_MASK, CIDET_OF_Z_VAR_WDQ);
@@ -188 +188 @@
  * @param   va              Arguments referenced in @a pszFormat.
  */
-int CidetCoreSetErrorV(PCIDETCORE pThis, const char *pszFormat, va_list va)
+static int CidetCoreSetErrorV(PCIDETCORE pThis, const char *pszFormat, va_list va)
 {
     pThis->pfnFailure(pThis, pszFormat, va);
@@ -203 +203 @@
  * @param   ...             Arguments referenced in @a pszFormat.
  */
-bool CidetCoreSetError(PCIDETCORE pThis, const char *pszFormat, ...)
+static bool CidetCoreSetError(PCIDETCORE pThis, const char *pszFormat, ...)
 {
     va_list va;
@@ -220 +220 @@
  * @param   cbSignificant   The number of significant bytes.
  */
-int64_t CidetCoreGetRandS64(PCIDETCORE pThis, uint8_t cbSignificant)
+static int64_t CidetCoreGetRandS64(PCIDETCORE pThis, uint8_t cbSignificant)
 {
     int64_t iVal = RTRandAdvS64(pThis->hRand);
@@ -243 +243 @@
  * @param   cbSignificant   The number of significant bytes.
  */
-uint64_t CidetCoreGetRandU64(PCIDETCORE pThis, uint8_t cbSignificant)
+static uint64_t CidetCoreGetRandU64(PCIDETCORE pThis, uint8_t cbSignificant)
 {
     Assert(cbSignificant == 1 || cbSignificant == 2 || cbSignificant == 4 || cbSignificant == 8);
@@ -255 +255 @@
 
 
-void CidetCoreInitializeCtxTemplate(PCIDETCORE pThis)
+static void CidetCoreInitializeCtxTemplate(PCIDETCORE pThis)
 {
     pThis->InTemplateCtx.rip = UINT64_MAX;
@@ -327 +327 @@
 
 
-bool CidetCoreIsEncodingCompatibleWithInstruction(PCIDETCORE pThis)
+static bool CidetCoreIsEncodingCompatibleWithInstruction(PCIDETCORE pThis)
 {
     RT_NOREF_PV(pThis);
@@ -1227 +1227 @@
 
 
-bool CidetCoreSetupNextBaseEncoding(PCIDETCORE pThis)
+static bool CidetCoreSetupNextBaseEncoding(PCIDETCORE pThis)
 {
     if (pThis->fUsesModRm)
@@ -1278 +1278 @@
 
 
-bool CidetCoreSetupFirstBaseEncoding(PCIDETCORE pThis)
+static bool CidetCoreSetupFirstBaseEncoding(PCIDETCORE pThis)
 {
     /*
@@ -1331 +1331 @@
  * @param   pThis               The core state structure.
  */
-bool CidetCoreSetupNextMemoryOperandConfig(PCIDETCORE pThis)
+static bool CidetCoreSetupNextMemoryOperandConfig(PCIDETCORE pThis)
 {
     RT_NOREF_PV(pThis);
@@ -1344 +1344 @@
  * @param   pThis               The core state structure.
  */
-bool CidetCoreSetupFirstMemoryOperandConfig(PCIDETCORE pThis)
+static bool CidetCoreSetupFirstMemoryOperandConfig(PCIDETCORE pThis)
 {
     pThis->cMemoryOperands = 0;
@@ -1384 +1384 @@
  * @param   pThis               The core state structure.
  */
-bool CidetCoreSetupNextCodeBufferConfig(PCIDETCORE pThis)
+static bool CidetCoreSetupNextCodeBufferConfig(PCIDETCORE pThis)
 {
     RT_NOREF_PV(pThis);
@@ -1397 +1397 @@
  * @param   pThis               The core state structure.
  */
-bool CidetCoreSetupFirstCodeBufferConfig(PCIDETCORE pThis)
+static bool CidetCoreSetupFirstCodeBufferConfig(PCIDETCORE pThis)
 {
     Assert(pThis->cCodeBufConfigs > 0);
@@ -1476 +1476 @@
 
 
-bool CideCoreSetInstruction(PCIDETCORE pThis, PCCIDETINSTR pInstr)
+static bool CideCoreSetInstruction(PCIDETCORE pThis, PCCIDETINSTR pInstr)
 {
     AssertReleaseMsgReturn(RT_VALID_PTR(pInstr), ("%p\n", pInstr), false);
@@ -1568 +1568 @@
 
 
-bool CidetCoreSetupInOut(PCIDETCORE pThis)
+static bool CidetCoreSetupInOut(PCIDETCORE pThis)
 {
     /*
@@ -1886 +1886 @@
  * @param   pThis           The core state structure (for context).
  */
-bool CidetCoreAssembleLength(PCIDETCORE pThis)
+static bool CidetCoreAssembleLength(PCIDETCORE pThis)
 {
     uint8_t off = 0;
@@ -2004 +2004 @@
  * @param   pThis           The core state structure (for context).
  */
-bool CidetCoreAssemble(PCIDETCORE pThis)
+static bool CidetCoreAssemble(PCIDETCORE pThis)
 {
     uint8_t off = 0;
@@ -2113 +2113 @@
 
 
-bool CidetCoreReInitCodeBuf(PCIDETCORE pThis)
+static bool CidetCoreReInitCodeBuf(PCIDETCORE pThis)
 {
     /*
@@ -2161 +2161 @@
 
 
-bool CidetCoreSetupCodeBuf(PCIDETCORE pThis, unsigned iSubTest)
+static bool CidetCoreSetupCodeBuf(PCIDETCORE pThis, unsigned iSubTest)
 {
     if (CidetCoreAssemble(pThis))
@@ -2202 +2202 @@
  * @param   pThis           The core state structure.
  */
-bool CidetCoreCheckResults(PCIDETCORE pThis)
+static bool CidetCoreCheckResults(PCIDETCORE pThis)
 {
     if (memcmp(&pThis->ActualCtx, &pThis->ExpectedCtx, CIDETCPUCTX_COMPARE_SIZE) == 0)
@@ -2265 +2265 @@
 
 
-bool CidetCoreTest_Basic(PCIDETCORE pThis)
+static bool CidetCoreTest_Basic(PCIDETCORE pThis)
 {
     /*