Changeset 99775 in vbox for trunk/src/VBox/ValidationKit/utils/usb

Timestamp:

May 12, 2023 12:21:58 PM (23 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

157370

Message:

*: Mark functions as static if not used outside of a given compilation unit. Enables the compiler to optimize inlining, reduces the symbol tables, exposes unused functions and in some rare cases exposes mismtaches between function declarations and definitions, but most importantly reduces the number of parfait reports for the extern-function-no-forward-declaration category. This should not result in any functional changes, bugref:3409

Location:

trunk/src/VBox/ValidationKit/utils/usb

Files:

• UsbTestServiceProtocol.h (modified) (2 diffs)
• UsbTestServiceTcp.cpp (modified) (1 diff)

trunk/src/VBox/ValidationKit/utils/usb/UsbTestServiceProtocol.h

@@ -360 +360 @@
  * @param   pPktHdr           The packet to convert.
  */
-DECLHIDDEN(void) utsProtocolRepH2N(PUTSPKTHDR pPktHdr);
+DECLHIDDEN(void) utsProtocolRepH2N(PUTSPKTSTS pPktHdr);
 
 /**
@@ -367 +367 @@
  * @param   pPktHdr           The packet to convert.
  */
-DECLHIDDEN(void) utsProtocolRepN2H(PUTSPKTHDR pPktHdr);
+DECLHIDDEN(void) utsProtocolRepN2H(PUTSPKTSTS pPktHdr);
 
 RT_C_DECLS_END

trunk/src/VBox/ValidationKit/utils/usb/UsbTestServiceTcp.cpp

@@ -469 +469 @@
  * @interface_method_impl{UTSTRANSPORT,pfnUsage}
  */
-DECLCALLBACK(void) utsTcpUsage(PRTSTREAM pStream)
+static DECLCALLBACK(void) utsTcpUsage(PRTSTREAM pStream)
 {
     RTStrmPrintf(pStream,