Changeset 99801 in vbox

Timestamp:

May 15, 2023 10:58:23 PM (19 months ago)

Author:

vboxsync

Message:

Runtime/testcase/{Makefile.kmk,tstRTCRest-1}: Address two
Solaris-specific test failures in RTCRestDouble both of which involve
strtod(3C).

tstRTCRest-1.cpp:testDouble() calls RTJsonParseFromString() to parse
TST_DBL_MIN_STRING1 (a shortened, stringified value of float.h:DBL_MIN)
and ends up in strtod(3C) which fails on Solaris with VERR_OUT_OF_RANGE
(errno=ERANGE) as the value is smaller than the exact value of DBL_MIN
(2^{-1022). There is already code to handle expected failures for this
value on Linux which returns VERR_INVALID_PARAMETER (errno=EINVAL) so
include VERR_OUT_OF_RANGE for Solaris.}

testDouble() also calls RTCRestDouble::fromString() with an argument of
" 0x42 " which is passed to strtod(3C) to convert the supplied string to
a floating-point number. On Solaris, calling strtod(3C) with a
hexadecimal value returns zero unless xpg6 has been set to include
_C99SUSv3_recognize_hexfp (0x1). This is set by the compiler when
C99/SUSv3 behaviour is requested (e.g. with -std=c99). Of the gcc
versions delivered with Solaris, gcc 10 is the first version to default
to C99 behaviour and thus it sets xpg6 to _C99SUSv3_mode_ON
(0x0000ffff) by default by implicitly linking with values-xpg6.o. Thus
testDouble()'s call to fromString(&obj4, " 0x42 ", ...) can succeed or
fail on Solaris 11 depending on which compiler is used. Address this by
refining the test on Solaris to also check the gcc version.

Location:

trunk/src/VBox/Runtime/testcase

Files:

• Makefile.kmk (modified) (1 diff)
• tstRTCRest-1.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/testcase/Makefile.kmk

@@ -360 +360 @@
   tstRTCRest-1_TEMPLATE = VBoxR3TstExe
   tstRTCRest-1_SOURCES = tstRTCRest-1.cpp
+  if ("$(KBUILD_TARGET)" == "solaris" && $(VBOX_GCC_VERSION_CXX) <= 70500)
+   tstRTCRest-1_DEFS = VBOX_SOLARIS_WITHOUT_XPG6_ENABLED
+  endif
  endif
 

trunk/src/VBox/Runtime/testcase/tstRTCRest-1.cpp

@@ -774 +774 @@
     RTERRINFOSTATIC ErrInfo;
     {
-        /* Some linux systems and probably all solaris fail to parse the longer MIN string, so just detect and skip. */
+        /* Some linux systems and probably all Solaris fail to parse the longer MIN string, so just detect and skip. */
         bool fGroksMinString = true;
 #if defined(RT_OS_LINUX) || defined(RT_OS_SOLARIS)
@@ -780 +780 @@
         int rcTmp = RTJsonParseFromString(&hTmpValue, TST_DBL_MIN_STRING1, NULL);
         RTJsonValueRelease(hTmpValue);
-        if (rcTmp == VERR_INVALID_PARAMETER)
+        if (rcTmp == VERR_INVALID_PARAMETER || rcTmp == VERR_OUT_OF_RANGE)
             fGroksMinString = false;
 #endif
@@ -890 +890 @@
         RTTESTI_CHECK_RC(fromString(&obj4, "false", NULL, RT_XSTR(__LINE__)), VERR_NO_DIGITS);
 
-#if (!defined(RT_OS_SOLARIS) && !defined(RT_OS_WINDOWS)) || RT_MSC_PREREQ(RT_MSC_VER_VS2015)
+#if (!defined(RT_OS_WINDOWS) && !defined(VBOX_SOLARIS_WITHOUT_XPG6_ENABLED)) || RT_MSC_PREREQ(RT_MSC_VER_VS2015)
         RTTESTI_CHECK_RC(fromString(&obj4, " 0x42 ", &ErrInfo, RT_XSTR(__LINE__)), VINF_SUCCESS);
         RTTESTI_CHECK(obj4.m_rdValue == 66.0);