Changeset 99811 in vbox

Timestamp:

May 16, 2023 9:12:53 AM (20 months ago)

Author:

vboxsync

Message:

NAT/lwIP: ticketref:21560 Adjust UDP proxy timeout from 18-21 to 21-24 range to respect intended 20 second timeout

File:

• trunk/src/VBox/Devices/Network/lwip-new/src/core/udp.c (modified) (1 diff)

trunk/src/VBox/Devices/Network/lwip-new/src/core/udp.c

@@ -691 +691 @@
     struct udp_pcb *xpcb;
 
-    if (++pcb->proxy_cnt < limit) {
+    /*
+     * Although a strict inequality '<' seems appropriate here (20 < 3 * 7),
+     * the fact that UDP proxy timer is shared by all UDP proxies may cause
+     * the first timer interval to expire anywhere between 0 to 3 seconds,
+     * which results in UDP proxy timeout being in 18 to 21 second range. By
+     * using '<=' we shift it to 21-24 second range. See @ticketref{21560}.
+     */
+    if (++pcb->proxy_cnt <= limit) {
       pprev = &pcb->next;
       pcb = pcb->next;