Changeset 99899 in vbox for trunk/src/VBox/VMM

Timestamp:

May 22, 2023 12:43:21 PM (21 months ago)

Author:

vboxsync

Message:

VMM/EM,DBGF: Removed the EMSTATE_IEM_THEN_REM stuff as it makes no sense without the old REM. bugref:10369

Location:

trunk/src/VBox/VMM

Files:

• VMMR3/DBGF.cpp (modified) (1 diff)
• VMMR3/EM.cpp (modified) (12 diffs)
• include/EMInternal.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMR3/DBGF.cpp

@@ -432 +432 @@
 
         case EMSTATE_IEM:
-        case EMSTATE_RAW_OBSOLETE:
-        case EMSTATE_IEM_THEN_REM:
         case EMSTATE_DEBUG_GUEST_IEM:
         case EMSTATE_DEBUG_GUEST_RAW:

trunk/src/VBox/VMM/VMMR3/EM.cpp

@@ -565 +565 @@
            || pVCpu->em.s.enmState == EMSTATE_IEM
            || pVCpu->em.s.enmState == EMSTATE_RECOMPILER
-           /* obsolete stuff: */
-           || pVCpu->em.s.enmState == EMSTATE_IEM_THEN_REM
          ? VINF_EM_RESCHEDULE
          : VINF_SUCCESS;
@@ -693 +691 @@
         case EMSTATE_DEBUG_HYPER:               return "EMSTATE_DEBUG_HYPER";
         case EMSTATE_GURU_MEDITATION:           return "EMSTATE_GURU_MEDITATION";
-        case EMSTATE_IEM_THEN_REM:              return "EMSTATE_IEM_THEN_REM";
+        case EMSTATE_IEM_THEN_REM_OBSOLETE:     return "EMSTATE_IEM_THEN_REM_OBSOLETE";
         case EMSTATE_NEM:                       return "EMSTATE_NEM";
         case EMSTATE_DEBUG_GUEST_NEM:           return "EMSTATE_DEBUG_GUEST_NEM";
@@ -1152 +1150 @@
 
 /**
- * Try execute the problematic code in IEM first, then fall back on REM if there
- * is too much of it or if IEM doesn't implement something.
- *
- * @returns Strict VBox status code from IEMExecLots.
- * @param   pVM        The cross context VM structure.
- * @param   pVCpu       The cross context virtual CPU structure of the calling EMT.
- * @param   pfFFDone    Force flags done indicator.
- *
- * @thread  EMT(pVCpu)
- */
-static VBOXSTRICTRC emR3ExecuteIemThenRem(PVM pVM, PVMCPU pVCpu, bool *pfFFDone)
-{
-#if defined(VBOX_VMM_TARGET_ARMV8)
-    LogFlow(("emR3ExecuteIemThenRem: %RGv\n", CPUMGetGuestFlatPC(pVCpu)));
-#else
-    LogFlow(("emR3ExecuteIemThenRem: %04x:%RGv\n", CPUMGetGuestCS(pVCpu), CPUMGetGuestRIP(pVCpu)));
-#endif
-    *pfFFDone = false;
-
-    /*
-     * Execute in IEM for a while.
-     */
-    while (pVCpu->em.s.cIemThenRemInstructions < 1024)
-    {
-        uint32_t     cInstructions;
-        VBOXSTRICTRC rcStrict = IEMExecLots(pVCpu, 1024 - pVCpu->em.s.cIemThenRemInstructions /*cMaxInstructions*/,
-                                            UINT32_MAX/2 /*cPollRate*/, &cInstructions);
-        pVCpu->em.s.cIemThenRemInstructions += cInstructions;
-        if (rcStrict != VINF_SUCCESS)
-        {
-            if (   rcStrict == VERR_IEM_ASPECT_NOT_IMPLEMENTED
-                || rcStrict == VERR_IEM_INSTR_NOT_IMPLEMENTED)
-                break;
-
-            Log(("emR3ExecuteIemThenRem: returns %Rrc after %u instructions\n",
-                 VBOXSTRICTRC_VAL(rcStrict), pVCpu->em.s.cIemThenRemInstructions));
-            return rcStrict;
-        }
-
-        EMSTATE enmNewState = emR3Reschedule(pVM, pVCpu);
-        if (enmNewState != EMSTATE_RECOMPILER && enmNewState != EMSTATE_IEM_THEN_REM)
-        {
-            LogFlow(("emR3ExecuteIemThenRem: -> %d (%s) after %u instructions\n",
-                     enmNewState, emR3GetStateName(enmNewState), pVCpu->em.s.cIemThenRemInstructions));
-            pVCpu->em.s.enmPrevState = pVCpu->em.s.enmState;
-            pVCpu->em.s.enmState     = enmNewState;
-            return VINF_SUCCESS;
-        }
-
-        /*
-         * Check for pending actions.
-         */
-        if (   VM_FF_IS_ANY_SET(pVM, VM_FF_ALL_REM_MASK)
-            || VMCPU_FF_IS_ANY_SET(pVCpu, VMCPU_FF_ALL_REM_MASK & ~VMCPU_FF_UNHALT))
-            return VINF_SUCCESS;
-    }
-
-    /*
-     * Switch to REM.
-     */
-    Log(("emR3ExecuteIemThenRem: -> EMSTATE_RECOMPILER (after %u instructions)\n", pVCpu->em.s.cIemThenRemInstructions));
-    pVCpu->em.s.enmState = EMSTATE_RECOMPILER;
-    return VINF_SUCCESS;
-}
-
-
-/**
- * Decides whether to execute RAW, HWACC or REM.
+ * Decides whether to execute HM, NEM, IEM/interpreter or IEM/recompiler.
  *
  * @returns new EM state
@@ -1259 +1190 @@
      *       turns off monitoring features essential for raw mode!
      */
-    return EMSTATE_IEM_THEN_REM;
+#ifdef VBOX_WITH_IEM_RECOMPILER
+    return pVM->em.s.fIemRecompiled ? EMSTATE_RECOMPILER : EMSTATE_IEM;
+#else
+    return EMSTATE_IEM;
+#endif
 }
 
@@ -2170 +2105 @@
         else
             pVCpu->em.s.enmState = emR3Reschedule(pVM, pVCpu);
-        pVCpu->em.s.cIemThenRemInstructions = 0;
         Log(("EMR3ExecuteVM: enmState=%s\n", emR3GetStateName(pVCpu->em.s.enmState)));
 
@@ -2239 +2173 @@
                         else
                         {
-                            Log2(("EMR3ExecuteVM: VINF_EM_RESCHEDULE_HM: %d -> %d (EMSTATE_IEM_THEN_REM)\n", enmOldState, EMSTATE_IEM_THEN_REM));
-                            pVCpu->em.s.enmState = EMSTATE_IEM_THEN_REM;
+                            Log2(("EMR3ExecuteVM: VINF_EM_RESCHEDULE_HM: %d -> %d (EMSTATE_RECOMPILER)\n", enmOldState, EMSTATE_RECOMPILER));
+                            pVCpu->em.s.enmState = EMSTATE_RECOMPILER;
                         }
                     }
@@ -2262 +2196 @@
                 case VINF_EM_RESCHEDULE_REM:
                     Assert(!pVM->em.s.fIemExecutesAll || pVCpu->em.s.enmState != EMSTATE_IEM);
-                    Log2(("EMR3ExecuteVM: VINF_EM_RESCHEDULE_REM: %d -> %d (EMSTATE_IEM_THEN_REM)\n",
-                          enmOldState, EMSTATE_IEM_THEN_REM));
-                    if (pVCpu->em.s.enmState != EMSTATE_IEM_THEN_REM)
-                    {
-                        pVCpu->em.s.enmState = EMSTATE_IEM_THEN_REM;
-                        pVCpu->em.s.cIemThenRemInstructions = 0;
-                    }
+                    Log2(("EMR3ExecuteVM: VINF_EM_RESCHEDULE_REM: %d -> %d (EMSTATE_REM)\n",
+                          enmOldState, EMSTATE_RECOMPILER));
+                    pVCpu->em.s.enmState = EMSTATE_RECOMPILER;
                     break;
 
@@ -2293 +2223 @@
                     EMSTATE enmState = emR3Reschedule(pVM, pVCpu);
                     Log2(("EMR3ExecuteVM: VINF_EM_RESCHEDULE: %d -> %d (%s)\n", enmOldState, enmState, emR3GetStateName(enmState)));
-                    if (pVCpu->em.s.enmState != enmState && enmState == EMSTATE_IEM_THEN_REM)
-                        pVCpu->em.s.cIemThenRemInstructions = 0;
                     pVCpu->em.s.enmState = enmState;
                     break;
@@ -2337 +2265 @@
                         EMSTATE enmState = emR3Reschedule(pVM, pVCpu);
                         Log2(("EMR3ExecuteVM: VINF_EM_RESET: %d -> %d (%s)\n", enmOldState, enmState, emR3GetStateName(enmState)));
-                        if (pVCpu->em.s.enmState != enmState && enmState == EMSTATE_IEM_THEN_REM)
-                            pVCpu->em.s.cIemThenRemInstructions = 0;
                         pVCpu->em.s.enmState = enmState;
                     }
@@ -2490 +2416 @@
                         || enmNewState == EMSTATE_DEBUG_GUEST_NEM
                         || enmNewState == EMSTATE_DEBUG_GUEST_IEM
-                        || enmNewState == EMSTATE_DEBUG_GUEST_RECOMPILER
-                        /* Obsolete stuff: */
-                        || enmNewState == EMSTATE_IEM_THEN_REM ) )
+                        || enmNewState == EMSTATE_DEBUG_GUEST_RECOMPILER) )
                 {
                     if (pVCpu->em.s.MWait.fWait & EMMWAIT_FLAG_ACTIVE)
@@ -2569 +2493 @@
                     }
                     fFFDone = false;
-                    break;
-                }
-
-                /*
-                 * Execute in IEM, hoping we can quickly switch aback to HM
-                 * or RAW execution.  If our hopes fail, we go to REM.
-                 */
-                case EMSTATE_IEM_THEN_REM:
-                {
-                    STAM_PROFILE_START(&pVCpu->em.s.StatIEMThenREM, pIemThenRem);
-                    rc = VBOXSTRICTRC_TODO(emR3ExecuteIemThenRem(pVM, pVCpu, &fFFDone));
-                    STAM_PROFILE_STOP(&pVCpu->em.s.StatIEMThenREM, pIemThenRem);
                     break;
                 }
@@ -2725 +2637 @@
                 case EMSTATE_NONE:
                 case EMSTATE_RAW_OBSOLETE:
+                case EMSTATE_IEM_THEN_REM_OBSOLETE:
                 case EMSTATE_TERMINATING:
                 default:

trunk/src/VBox/VMM/include/EMInternal.h

@@ -158 +158 @@
 
     /** Explicit padding. */
-    uint8_t                 abPadding0[3];
-
-    /** The number of instructions we've executed in IEM since switching to the
-     *  EMSTATE_IEM_THEN_REM state. */
-    uint32_t                cIemThenRemInstructions;
+    uint8_t                 abPadding0[7];
 
     /** Start of the current time slice in ms. */