Changeset 9996 in vbox for trunk/src/VBox/Additions/common

Timestamp:

Jun 27, 2008 1:29:37 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

32447

Message:

Additions/common: fixed some error codes in VBoxGuestR3LibVideo.cpp

File:

• trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibVideo.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibVideo.cpp

@@ -287 +287 @@
                                   sizeof(szModeParms), NULL); /** @todo add a VbglR3InfoSvcReadKeyF/FV that does the RTStrPrintf for you. */
     }
-/** @todo r=bird: this is kind of ugly.
- * What about just fixing the format as "CXxCYxCBITS" and then split it up into three strings by searching for the
- * two 'x'es. And then apply RTStrToUInt32Full to these in turn.
- * Also, the use of VERR_INVALID_PARAMETER seems inappropriate and confusing here. */
     if (RT_SUCCESS(rc))
         /* Extract the width from the string */
         rc = RTStrToUInt32Ex(szModeParms, &pszNext, 10, &cx);
     if ((rc != VWRN_TRAILING_CHARS) || (*pszNext != 'x'))
-        rc = VERR_INVALID_PARAMETER;
+        rc = VERR_PARSE_ERROR;
     if (RT_SUCCESS(rc))
     {
@@ -302 +298 @@
     }
     if ((rc != VWRN_TRAILING_CHARS) || (*pszNext != 'x'))
-        rc = VERR_INVALID_PARAMETER;
+        rc = VERR_PARSE_ERROR;
     if (RT_SUCCESS(rc))
     {
@@ -309 +305 @@
     }
     if (rc != VINF_SUCCESS)
-        rc = VERR_INVALID_PARAMETER;
+        rc = VERR_PARSE_ERROR;
     if (u32ClientId != 0)
         VbglR3InfoSvcDisconnect(u32ClientId);  /* Return value ignored, because what can we do anyway? */