Changeset 100714 in vbox for trunk/src/VBox/VMM/include

Timestamp:

Jul 27, 2023 10:12:09 AM (18 months ago)

Author:

vboxsync

Message:

VMM/IEM: Require a IEMOP_HLP_DONE_DECODING in all MC blocks so we know exacly when the recompiler starts emitting code (calls) and we can make sure it's still safe to restart insturction decoding. Also made the python script check this and that nothing that smells like decoding happens after IEMOP_HLP_DONE_DECODING and its friends. bugref:10369

File:

• trunk/src/VBox/VMM/include/IEMOpHlp.h (modified) (1 diff)

trunk/src/VBox/VMM/include/IEMOpHlp.h

@@ -327 +327 @@
  *
  *  @note Update IEM_VMX_IN_VMX_OPERATION if changes are made here.
+ *
+ * @todo r=bird: This is absolutely *INCORRECT* since IEM_VMX_IS_ROOT_MODE
+ *       is a complicated runtime state (calls CPUMIsGuestInVmxRootMode), and
+ *       not something we can decide while decoding.  Convert to an IEM_MC!
  */
 # define IEMOP_HLP_IN_VMX_OPERATION(a_szInstr, a_InsDiagPrefix) \