Changeset 101382 in vbox for trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsDisplay.cpp

Timestamp:

Oct 6, 2023 10:02:08 AM (19 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

159386

Message:

FE/Qt: Marking up some more guest OS ID strings. bugref:10384

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsDisplay.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsDisplay.cpp

@@ -54 +54 @@
 #include "CRecordingSettings.h"
 #include "CVRDEServer.h"
+#include <VBox/com/VirtualBox.h> /* For GUEST_OS_ID_STR_X86 and friends. */
 
 
@@ -1021 +1022 @@
 bool UIMachineSettingsDisplay::shouldWeWarnAboutLowVRAM()
 {
-    QStringList excludingOSList = QStringList()
-        << "Other" << "DOS" << "Netware" << "L4" << "QNX" << "JRockitVE";
-    return !excludingOSList.contains(m_strGuestOSTypeId);
+    static const char *s_apszExcludes[] =
+    {
+        GUEST_OS_ID_STR_X86("Other"),
+        GUEST_OS_ID_STR_X64("Other"),
+        GUEST_OS_ID_STR_A64("Other"),
+        GUEST_OS_ID_STR_X64("VBoxBS"),
+        GUEST_OS_ID_STR_X86("DOS"),
+        GUEST_OS_ID_STR_X86("Netware"),
+        GUEST_OS_ID_STR_X86("L4"),
+        GUEST_OS_ID_STR_X86("QNX"),
+        GUEST_OS_ID_STR_X86("JRockitVE"),
+    };
+    for (size_t idx = 0; idx < RT_ELEMENTS(s_apszExcludes); idx++)
+        if (m_strGuestOSTypeId == s_apszExcludes[idx])
+            return false;
+    return true;
 }