Changeset 101469 in vbox for trunk/src/VBox/Main/src-client/ConsoleImplConfigCommon.cpp

Timestamp:

Oct 17, 2023 10:22:01 AM (15 months ago)

Author:

vboxsync

Message:

Main/ConsoleImpl: Move the network controller configuration out of the x86 config constructor into a separate method in order to be able to use it from the Armv8 variant later on, bugref:10528

File:

• trunk/src/VBox/Main/src-client/ConsoleImplConfigCommon.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-client/ConsoleImplConfigCommon.cpp

@@ -4630 +4630 @@
 
 
+int Console::i_configNetworkCtrls(ComPtr<IMachine> pMachine, ComPtr<IPlatformProperties> pPlatformProperties,
+                                  ChipsetType_T enmChipset, BusAssignmentManager *pBusMgr, PCVMMR3VTABLE pVMM, PUVM pUVM,
+                                  PCFGMNODE pDevices, std::list<BootNic> &llBootNics)
+{
+/* Comment out the following line to remove VMWare compatibility hack. */
+#define VMWARE_NET_IN_SLOT_11
+
+    PCFGMNODE pDev = NULL;          /* /Devices/Dev/ */
+    PCFGMNODE pInst = NULL;         /* /Devices/Dev/0/ */
+    PCFGMNODE pCfg = NULL;          /* /Devices/Dev/.../Config/ */
+    PCFGMNODE pLunL0 = NULL;        /* /Devices/Dev/0/LUN#0/ */
+
+    ULONG maxNetworkAdapters;
+    HRESULT hrc = pPlatformProperties->GetMaxNetworkAdapters(enmChipset, &maxNetworkAdapters); H();
+
+#ifdef VMWARE_NET_IN_SLOT_11
+    bool fSwapSlots3and11 = false;
+#endif
+    PCFGMNODE pDevPCNet = NULL;          /* PCNet-type devices */
+    InsertConfigNode(pDevices, "pcnet", &pDevPCNet);
+#ifdef VBOX_WITH_E1000
+    PCFGMNODE pDevE1000 = NULL;          /* E1000-type devices */
+    InsertConfigNode(pDevices, "e1000", &pDevE1000);
+#endif
+#ifdef VBOX_WITH_VIRTIO
+    PCFGMNODE pDevVirtioNet = NULL;          /* Virtio network devices */
+    InsertConfigNode(pDevices, "virtio-net", &pDevVirtioNet);
+#endif /* VBOX_WITH_VIRTIO */
+    PCFGMNODE pDevDP8390 = NULL;         /* DP8390-type devices */
+    InsertConfigNode(pDevices, "dp8390", &pDevDP8390);
+    PCFGMNODE pDev3C501 = NULL;          /* EtherLink-type devices */
+    InsertConfigNode(pDevices, "3c501",  &pDev3C501);
+
+    for (ULONG uInstance = 0; uInstance < maxNetworkAdapters; ++uInstance)
+    {
+        ComPtr<INetworkAdapter> networkAdapter;
+         hrc = pMachine->GetNetworkAdapter(uInstance, networkAdapter.asOutParam());     H();
+        BOOL fEnabledNetAdapter = FALSE;
+        hrc = networkAdapter->COMGETTER(Enabled)(&fEnabledNetAdapter);                  H();
+        if (!fEnabledNetAdapter)
+            continue;
+
+        /*
+         * The virtual hardware type. Create appropriate device first.
+         */
+        const char *pszAdapterName = "pcnet";
+        NetworkAdapterType_T adapterType;
+        hrc = networkAdapter->COMGETTER(AdapterType)(&adapterType);                     H();
+        switch (adapterType)
+        {
+            case NetworkAdapterType_Am79C970A:
+            case NetworkAdapterType_Am79C973:
+            case NetworkAdapterType_Am79C960:
+                pDev = pDevPCNet;
+                break;
+#ifdef VBOX_WITH_E1000
+            case NetworkAdapterType_I82540EM:
+            case NetworkAdapterType_I82543GC:
+            case NetworkAdapterType_I82545EM:
+                pDev = pDevE1000;
+                pszAdapterName = "e1000";
+                break;
+#endif
+#ifdef VBOX_WITH_VIRTIO
+            case NetworkAdapterType_Virtio:
+                pDev = pDevVirtioNet;
+                pszAdapterName = "virtio-net";
+                break;
+#endif /* VBOX_WITH_VIRTIO */
+            case NetworkAdapterType_NE1000:
+            case NetworkAdapterType_NE2000:
+            case NetworkAdapterType_WD8003:
+            case NetworkAdapterType_WD8013:
+            case NetworkAdapterType_ELNK2:
+                pDev = pDevDP8390;
+                break;
+            case NetworkAdapterType_ELNK1:
+                pDev = pDev3C501;
+                break;
+            default:
+                AssertMsgFailed(("Invalid network adapter type '%d' for slot '%d'", adapterType, uInstance));
+                return pVMM->pfnVMR3SetError(pUVM, VERR_INVALID_PARAMETER, RT_SRC_POS,
+                                             N_("Invalid network adapter type '%d' for slot '%d'"), adapterType, uInstance);
+        }
+
+        InsertConfigNode(pDev, Utf8StrFmt("%u", uInstance).c_str(), &pInst);
+        InsertConfigInteger(pInst, "Trusted",              1); /* boolean */
+        /* the first network card gets the PCI ID 3, the next 3 gets 8..10,
+         * next 4 get 16..19. */
+        int iPCIDeviceNo;
+        switch (uInstance)
+        {
+            case 0:
+                iPCIDeviceNo = 3;
+                break;
+            case 1: case 2: case 3:
+                iPCIDeviceNo = uInstance - 1 + 8;
+                break;
+            case 4: case 5: case 6: case 7:
+                iPCIDeviceNo = uInstance - 4 + 16;
+                break;
+            default:
+                /* auto assignment */
+                iPCIDeviceNo = -1;
+                break;
+        }
+#ifdef VMWARE_NET_IN_SLOT_11
+        /*
+         * Dirty hack for PCI slot compatibility with VMWare,
+         * it assigns slot 0x11 to the first network controller.
+         */
+        if (iPCIDeviceNo == 3 && adapterType == NetworkAdapterType_I82545EM)
+        {
+            iPCIDeviceNo = 0x11;
+            fSwapSlots3and11 = true;
+        }
+        else if (iPCIDeviceNo == 0x11 && fSwapSlots3and11)
+            iPCIDeviceNo = 3;
+#endif
+        PCIBusAddress PCIAddr = PCIBusAddress(0, iPCIDeviceNo, 0);
+        hrc = pBusMgr->assignPCIDevice(pszAdapterName, pInst, PCIAddr);                 H();
+
+        InsertConfigNode(pInst, "Config", &pCfg);
+#ifdef VBOX_WITH_2X_4GB_ADDR_SPACE   /* not safe here yet. */ /** @todo Make PCNet ring-0 safe on 32-bit mac kernels! */
+        if (pDev == pDevPCNet)
+            InsertConfigInteger(pCfg, "R0Enabled",    false);
+#endif
+        /*
+         * Collect information needed for network booting and add it to the list.
+         */
+        BootNic     nic;
+
+        nic.mInstance    = uInstance;
+        /* Could be updated by reference, if auto assigned */
+        nic.mPCIAddress  = PCIAddr;
+
+        hrc = networkAdapter->COMGETTER(BootPriority)(&nic.mBootPrio);                  H();
+
+        llBootNics.push_back(nic);
+
+        /*
+         * The virtual hardware type. PCNet supports three types, E1000 three,
+         * but VirtIO only one.
+         */
+        switch (adapterType)
+        {
+            case NetworkAdapterType_Am79C970A:
+                InsertConfigString(pCfg, "ChipType", "Am79C970A");
+                break;
+            case NetworkAdapterType_Am79C973:
+                InsertConfigString(pCfg, "ChipType", "Am79C973");
+                break;
+            case NetworkAdapterType_Am79C960:
+                InsertConfigString(pCfg, "ChipType", "Am79C960");
+                break;
+            case NetworkAdapterType_I82540EM:
+                InsertConfigInteger(pCfg, "AdapterType", 0);
+                break;
+            case NetworkAdapterType_I82543GC:
+                InsertConfigInteger(pCfg, "AdapterType", 1);
+                break;
+            case NetworkAdapterType_I82545EM:
+                InsertConfigInteger(pCfg, "AdapterType", 2);
+                break;
+            case NetworkAdapterType_Virtio:
+                break;
+            case NetworkAdapterType_NE1000:
+                InsertConfigString(pCfg, "DeviceType", "NE1000");
+                break;
+            case NetworkAdapterType_NE2000:
+                InsertConfigString(pCfg, "DeviceType", "NE2000");
+                break;
+            case NetworkAdapterType_WD8003:
+                InsertConfigString(pCfg, "DeviceType", "WD8003");
+                break;
+            case NetworkAdapterType_WD8013:
+                InsertConfigString(pCfg, "DeviceType", "WD8013");
+                break;
+            case NetworkAdapterType_ELNK2:
+                InsertConfigString(pCfg, "DeviceType", "3C503");
+                break;
+            case NetworkAdapterType_ELNK1:
+                break;
+            case NetworkAdapterType_Null:      AssertFailedBreak(); /* (compiler warnings) */
+#ifdef VBOX_WITH_XPCOM_CPP_ENUM_HACK
+            case NetworkAdapterType_32BitHack: AssertFailedBreak(); /* (compiler warnings) */
+#endif
+        }
+
+        /*
+         * Get the MAC address and convert it to binary representation
+         */
+        Bstr macAddr;
+        hrc = networkAdapter->COMGETTER(MACAddress)(macAddr.asOutParam());              H();
+        Assert(!macAddr.isEmpty());
+        Utf8Str macAddrUtf8 = macAddr;
+#ifdef VBOX_WITH_CLOUD_NET
+        NetworkAttachmentType_T eAttachmentType;
+        hrc = networkAdapter->COMGETTER(AttachmentType)(&eAttachmentType);                 H();
+        if (eAttachmentType == NetworkAttachmentType_Cloud)
+        {
+            mGateway.setLocalMacAddress(macAddrUtf8);
+            /* We'll insert cloud MAC later, when it becomes known. */
+        }
+        else
+        {
+#endif
+        char *macStr = (char*)macAddrUtf8.c_str();
+        Assert(strlen(macStr) == 12);
+        RTMAC Mac;
+        RT_ZERO(Mac);
+        char *pMac = (char*)&Mac;
+        for (uint32_t i = 0; i < 6; ++i)
+        {
+            int c1 = *macStr++ - '0';
+            if (c1 > 9)
+                c1 -= 7;
+            int c2 = *macStr++ - '0';
+            if (c2 > 9)
+                c2 -= 7;
+            *pMac++ = (char)(((c1 & 0x0f) << 4) | (c2 & 0x0f));
+        }
+        InsertConfigBytes(pCfg, "MAC", &Mac, sizeof(Mac));
+#ifdef VBOX_WITH_CLOUD_NET
+        }
+#endif
+        /*
+         * Check if the cable is supposed to be unplugged
+         */
+        BOOL fCableConnected;
+        hrc = networkAdapter->COMGETTER(CableConnected)(&fCableConnected);              H();
+        InsertConfigInteger(pCfg, "CableConnected", fCableConnected ? 1 : 0);
+
+        /*
+         * Line speed to report from custom drivers
+         */
+        ULONG ulLineSpeed;
+        hrc = networkAdapter->COMGETTER(LineSpeed)(&ulLineSpeed);                       H();
+        InsertConfigInteger(pCfg, "LineSpeed", ulLineSpeed);
+
+        /*
+         * Attach the status driver.
+         */
+        i_attachStatusDriver(pInst, DeviceType_Network);
+
+        /*
+         * Configure the network card now
+         */
+        bool fIgnoreConnectFailure = mMachineState == MachineState_Restoring;
+        int vrc = i_configNetwork(pszAdapterName,
+                                  uInstance,
+                                  0,
+                                  networkAdapter,
+                                  pCfg,
+                                  pLunL0,
+                                  pInst,
+                                  false /*fAttachDetach*/,
+                                  fIgnoreConnectFailure,
+                                  pUVM,
+                                  pVMM);
+        if (RT_FAILURE(vrc))
+            return vrc;
+    }
+
+    return VINF_SUCCESS;
+}
+
+
 int Console::i_configGuestDbg(ComPtr<IVirtualBox> pVBox, ComPtr<IMachine> pMachine, PCFGMNODE pRoot)
 {