Changeset 102589 in vbox for trunk/src/VBox/Runtime/generic/http-curl.cpp

Timestamp:

Dec 12, 2023 5:35:32 PM (14 months ago)

Author:

vboxsync

Message:

IPRT/http-curl: nits (some mine)

File:

• trunk/src/VBox/Runtime/generic/http-curl.cpp (modified) (5 diffs)

trunk/src/VBox/Runtime/generic/http-curl.cpp

@@ -365 +365 @@
 static PFNLIBPROXYFACTORYDTOR                   g_pfnLibProxyFactoryDtor = NULL;
 static PFNLIBPROXYFACTORYGETPROXIES             g_pfnLibProxyFactoryGetProxies = NULL;
-/** Note: Only valid for libproxy >= 0.4.16. */
+/** Can be NULL, as it was introduced with libproxy v0.4.16 (2020-12-04). */
 static PFNLIBPROXYFACTORYFREEPROXIES            g_pfnLibProxyFactoryFreeProxies = NULL;
 /** @} */
@@ -1067 +1067 @@
             rc = RTLdrGetSymbol(hMod, "px_proxy_factory_get_proxies", (void **)&g_pfnLibProxyFactoryGetProxies);
         if (RT_SUCCESS(rc))
-        {
-            /* libproxy < 0.4.16 does not have this function, so this is not fatal if not found. */
+            /* libproxy < 0.4.16 does not have this function, so ignore the return code. */
             RTLdrGetSymbol(hMod, "px_proxy_factory_free_proxies", (void **)&g_pfnLibProxyFactoryFreeProxies);
-        }
         if (RT_SUCCESS(rc))
         {
@@ -1100 +1098 @@
     {
         /*
-         * Instance the factory and ask for a list of proxies.
+         * Instanciate the factory and ask for a list of proxies.
          */
         PLIBPROXYFACTORY pFactory = g_pfnLibProxyFactoryCtor();
@@ -1129 +1127 @@
                 /* Free the result. */
                 if (g_pfnLibProxyFactoryFreeProxies) /* libproxy >= 0.4.16. */
-                {
                     g_pfnLibProxyFactoryFreeProxies(papszProxies);
-                }
                 else
                 {
@@ -1140 +1136 @@
                 papszProxies = NULL;
             }
-
             g_pfnLibProxyFactoryDtor(pFactory);
         }