Changeset 103444 in vbox for trunk/src/VBox/Runtime/common/string/RTStrCat.cpp

Timestamp:

Feb 19, 2024 1:58:17 PM (11 months ago)

Author:

vboxsync

Message:

IPRT: Reverted r161541, r161577 & r161578 because the RTStrCopy2 and RTStrCat2 functions encourages writing unsafe code, given that RTStrCat[2] doesn't check for NULL destination buffers and will crash if the two are chained.

File:

• trunk/src/VBox/Runtime/common/string/RTStrCat.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/common/string/RTStrCat.cpp

@@ -45 +45 @@
 
 
-DECLINLINE(int) rtStrCat(char *pszDst, size_t cbDst, const char *pszSrc)
+RTDECL(int) RTStrCat(char *pszDst, size_t cbDst, const char *pszSrc)
 {
     char *pszDst2 = RTStrEnd(pszDst, cbDst);
@@ -65 +65 @@
     return VERR_BUFFER_OVERFLOW;
 }
-
-RTDECL(int) RTStrCat(char *pszDst, size_t cbDst, const char *pszSrc)
-{
-    return rtStrCat(pszDst, cbDst, pszSrc);
-}
 RT_EXPORT_SYMBOL(RTStrCat);
 
-RTDECL(char *) RTStrCat2(char *pszDst, size_t cbDst, const char *pszSrc)
-{
-    return RT_SUCCESS(rtStrCat(pszDst, cbDst, pszSrc)) ? pszDst : NULL;
-}
-RT_EXPORT_SYMBOL(RTStrCat2);
-