Changeset 104034 in vbox for trunk/src/VBox/VMM/include

Timestamp:

Mar 25, 2024 10:07:26 AM (11 months ago)

Author:

vboxsync

Message:

VMM/IEM: Implement experimental (disabled by default) delaying writeback of dirty guest registers (for GPRs only at the moment), bugref:10629

Location:

trunk/src/VBox/VMM/include

Files:

• IEMInternal.h (modified) (1 diff)
• IEMN8veRecompiler.h (modified) (6 diffs)

trunk/src/VBox/VMM/include/IEMInternal.h

@@ -1050 +1050 @@
         /* kIemTbDbgEntryType_GuestRegShadowing. */
         uint32_t    uType         : 4;
-        uint32_t    uUnused       : 4;
+        /** Flag whether the register is marked as dirty. */
+        uint32_t    fDirty        : 1;
+        uint32_t    uUnused       : 3;
         /** The guest register being shadowed (IEMNATIVEGSTREG). */
         uint32_t    idxGstReg     : 8;

trunk/src/VBox/VMM/include/IEMN8veRecompiler.h

@@ -70 +70 @@
 #endif
 
+/** @def IEMNATIVE_WITH_DELAYED_REGISTER_WRITEBACK
+ * Delay the writeback or dirty registers as long as possible. */
+#ifdef DEBUG_aeichner
+# define IEMNATIVE_WITH_DELAYED_REGISTER_WRITEBACK
+#endif
 
 /** @name Stack Frame Layout
@@ -1137 +1142 @@
     /** Bitmap marking valid entries in aidxGstRegShadows. */
     uint64_t                    bmGstRegShadows;
+#ifdef IEMNATIVE_WITH_DELAYED_REGISTER_WRITEBACK
+    /** Bitmap marking the shadowed guest register as dirty and needing writeback when flushing. */
+    uint64_t                    bmGstRegShadowDirty;
+#endif
 
 #ifdef IEMNATIVE_WITH_SIMD_REG_ALLOCATOR
@@ -1548 +1557 @@
 #ifdef IEMNATIVE_WITH_DELAYED_PC_UPDATING
 DECL_HIDDEN_THROW(uint32_t) iemNativeEmitPcWritebackSlow(PIEMRECOMPILERSTATE pReNative, uint32_t off);
+#endif
+#ifdef IEMNATIVE_WITH_DELAYED_REGISTER_WRITEBACK
+DECL_HIDDEN_THROW(uint32_t) iemNativeRegFlushPendingWrite(PIEMRECOMPILERSTATE pReNative, uint32_t off, IEMNATIVEGSTREG enmGstReg);
+DECL_HIDDEN_THROW(uint32_t) iemNativeRegFlushDirtyGuest(PIEMRECOMPILERSTATE pReNative, uint32_t off, uint64_t fFlushGstReg = UINT64_MAX);
+DECL_HIDDEN_THROW(uint32_t) iemNativeRegFlushDirtyGuestByHostRegShadow(PIEMRECOMPILERSTATE pReNative, uint32_t off, uint8_t idxHstReg);
 #endif
 
@@ -2110 +2124 @@
     Assert(   RT_BOOL(pReNative->Core.bmHstRegsWithGstShadow & RT_BIT_32(idxHstReg))
            == RT_BOOL(pReNative->Core.aHstRegs[idxHstReg].fGstRegShadows));
+#ifdef IEMNATIVE_WITH_DELAYED_REGISTER_WRITEBACK
+    Assert(!(pReNative->Core.aHstRegs[idxHstReg].fGstRegShadows & pReNative->Core.bmGstRegShadowDirty));
+#endif
 
 #ifdef IEMNATIVE_WITH_TB_DEBUG_INFO
@@ -2148 +2165 @@
     Assert(pReNative->Core.aHstRegs[idxHstReg].fGstRegShadows & RT_BIT_64(enmGstReg));
     Assert(pReNative->Core.bmHstRegsWithGstShadow             & RT_BIT_32(idxHstReg));
+#ifdef IEMNATIVE_WITH_DELAYED_REGISTER_WRITEBACK
+    Assert(!(pReNative->Core.aHstRegs[idxHstReg].fGstRegShadows & pReNative->Core.bmGstRegShadowDirty));
+#endif
 
 #ifdef IEMNATIVE_WITH_TB_DEBUG_INFO
@@ -2264 +2284 @@
 #endif
 
-#ifdef IEMNATIVE_WITH_SIMD_REG_ALLOCATOR
+#if defined(IEMNATIVE_WITH_SIMD_REG_ALLOCATOR) || defined(IEMNATIVE_WITH_DELAYED_REGISTER_WRITEBACK)
     /** @todo r=bird: There must be a quicker way to check if anything needs doing here!  */
     /** @todo This doesn't mix well with fGstShwExcept but we ignore this for now and just flush everything. */