Changeset 104072 in vbox for trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompFuncs.h

Timestamp:

Mar 26, 2024 9:05:49 PM (11 months ago)

Author:

vboxsync

Message:

VMM/IEM: Build fix and marked the two local SHL/SAR operations as not working correctly for 16-bit values. bugref:10371

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompFuncs.h (modified) (4 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompFuncs.h

@@ -3713 +3713 @@
     IEMNATIVE_ASSERT_VAR_SIZE(pReNative, idxVar, cbLocal);
 
-    if (cbLocal <= sizeof(uint32_t))
+    if (cbLocal <= sizeof(uint32_t)) /** @todo r=bird: for cbLocal < sizeof(uint32_t), this'll require a AND or something to restrict the result. */
         off = iemNativeEmitShiftGpr32Left(pReNative, off, idxVarReg, cShift);
     else
@@ -3750 +3750 @@
     IEMNATIVE_ASSERT_VAR_SIZE(pReNative, idxVar, cbLocal);
 
-    if (cbLocal <= sizeof(uint32_t))
+    if (cbLocal <= sizeof(uint32_t)) /** @todo r=bird: This is NOT working for cbLocal < sizeof(uint32_t) if negative! */
         off = iemNativeEmitArithShiftGpr32Right(pReNative, off, idxVarReg, cShift);
     else
@@ -3776 +3776 @@
     IEMNATIVE_ASSERT_VAR_SIZE(pReNative, idxVarEffAddr, sizeof(RTGCPTR));
     IEMNATIVE_ASSERT_VAR_IDX(pReNative, idxVar);
-    IEMNATIVE_ASSERT_VAR_SIZE(pReNative, idxVar, cbLocal); RT_NOREF(cbLocal);
+    IEMNATIVE_ASSERT_VAR_SIZE(pReNative, idxVar, cbLocal);
 
     uint8_t const idxVarReg        = iemNativeVarRegisterAcquire(pReNative, idxVar, &off, true /*fInitialized*/);
@@ -3784 +3784 @@
     if (cbLocal <= sizeof(uint32_t))
     {
-        uint8_t const idxRegTmp = iemNativeRegAllocTmp(pReNative, &off, idxVar);
+/** @todo ARM64: In case of boredone, the extended add instruction can do the
+ * conversion directly: ADD idxVarRegEffAddr, idxVarRegEffAddr, [w]idxVarReg, SXTH/SXTW */
+        uint8_t const idxRegTmp = iemNativeRegAllocTmp(pReNative, &off);
 
         switch (cbLocal)
         {
-            case sizeof(int8_t):  off = iemNativeEmitLoadGprSignExtendedFromGpr8(pReNative, off, idxRegTmp, idxVarReg); break;
             case sizeof(int16_t): off = iemNativeEmitLoadGprSignExtendedFromGpr16(pReNative, off, idxRegTmp, idxVarReg); break;
             case sizeof(int32_t): off = iemNativeEmitLoadGprSignExtendedFromGpr32(pReNative, off, idxRegTmp, idxVarReg); break;