Changeset 104238 in vbox for trunk/src/VBox/VMM/testcase

Timestamp:

Apr 8, 2024 8:15:10 PM (12 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

162690

Message:

VMM/IEM: Refactoring assembly helpers to not pass eflags by reference but instead by value and return the updated value (via eax/w0) - sixth chunk: SHL,SHR,SAR,ROL,ROR,RCL,RCR. bugref:10376

File:

• trunk/src/VBox/VMM/testcase/tstIEMAImpl.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/testcase/tstIEMAImpl.cpp

@@ -2783 +2783 @@
             a_TestType Test; \
             Test.fEflIn    = RandEFlags(); \
-            Test.fEflOut   = Test.fEflIn; \
             Test.uDstIn    = RandU ## a_cBits ## Dst(iTest); \
             Test.uDstOut   = Test.uDstIn; \
             Test.uSrcIn    = 0; \
             Test.uMisc     = RandU8() & (a_cBits * 4 - 1); /* need to go way beyond the a_cBits limit */ \
-            a_aSubTests[iFn].pfnNative(&Test.uDstOut, Test.uMisc, &Test.fEflOut); \
+            Test.fEflOut   = a_aSubTests[iFn].pfnNative(Test.fEflIn, &Test.uDstOut, Test.uMisc); \
             GenerateBinaryWrite(&BinOut, &Test, sizeof(Test)); \
             \
             Test.fEflIn    = (~Test.fEflIn & X86_EFL_LIVE_MASK) | X86_EFL_RA1_MASK; \
-            Test.fEflOut   = Test.fEflIn; \
             Test.uDstOut   = Test.uDstIn; \
-            a_aSubTests[iFn].pfnNative(&Test.uDstOut, Test.uMisc, &Test.fEflOut); \
+            Test.fEflOut   = a_aSubTests[iFn].pfnNative(Test.fEflIn, &Test.uDstOut, Test.uMisc); \
             GenerateBinaryWrite(&BinOut, &Test, sizeof(Test)); \
         } \
@@ -2838 +2836 @@
     for (uint32_t i = 0; i < cIterations; i++) \
     { \
-        uint32_t fBenchEfl = fEflIn; \
         a_uType  uBenchDst = uDstIn;  \
-        pfn(&uBenchDst, cShift, &fBenchEfl); \
+        pfn(fEflIn, &uBenchDst, cShift); \
         \
-        fBenchEfl = fEflIn; \
         uBenchDst = uDstIn;  \
-        pfn(&uBenchDst, cShift, &fBenchEfl); \
+        pfn(fEflIn, &uBenchDst, cShift); \
         \
-        fBenchEfl = fEflIn; \
         uBenchDst = uDstIn;  \
-        pfn(&uBenchDst, cShift, &fBenchEfl); \
+        pfn(fEflIn, &uBenchDst, cShift); \
         \
-        fBenchEfl = fEflIn; \
         uBenchDst = uDstIn;  \
-        pfn(&uBenchDst, cShift, &fBenchEfl); \
+        pfn(fEflIn, &uBenchDst, cShift); \
     } \
     return RTTimeNanoTS() - nsStart; \
@@ -2872 +2866 @@
             for (uint32_t iTest = 0; iTest < cTests; iTest++ ) \
             { \
-                uint32_t fEfl = paTests[iTest].fEflIn; \
-                a_uType  uDst = paTests[iTest].uDstIn; \
-                pfn(&uDst, paTests[iTest].uMisc, &fEfl); \
-                if (   uDst != paTests[iTest].uDstOut \
-                    || fEfl != paTests[iTest].fEflOut ) \
+                a_uType  uDst    = paTests[iTest].uDstIn; \
+                uint32_t fEflOut = pfn(paTests[iTest].fEflIn, &uDst, paTests[iTest].uMisc); \
+                if (   uDst    != paTests[iTest].uDstOut \
+                    || fEflOut != paTests[iTest].fEflOut ) \
                     RTTestFailed(g_hTest, "#%u%s: efl=%#08x dst=" a_Fmt " shift=%2u -> efl=%#08x dst=" a_Fmt ", expected %#08x & " a_Fmt "%s\n", \
                                  iTest, iVar == 0 ? "" : "/n", \
                                  paTests[iTest].fEflIn, paTests[iTest].uDstIn, paTests[iTest].uMisc, \
-                                 fEfl, uDst, paTests[iTest].fEflOut, paTests[iTest].uDstOut, \
-                                 EFlagsDiff(fEfl, paTests[iTest].fEflOut)); \
+                                 fEflOut, uDst, paTests[iTest].fEflOut, paTests[iTest].uDstOut, \
+                                 EFlagsDiff(fEflOut, paTests[iTest].fEflOut)); \
                 else \
                 { \
                      *g_pu ## a_cBits  = paTests[iTest].uDstIn; \
-                     *g_pfEfl          = paTests[iTest].fEflIn; \
-                     pfn(g_pu ## a_cBits, paTests[iTest].uMisc, g_pfEfl); \
+                     fEflOut = pfn(paTests[iTest].fEflIn, g_pu ## a_cBits, paTests[iTest].uMisc); \
                      RTTEST_CHECK(g_hTest, *g_pu ## a_cBits == paTests[iTest].uDstOut); \
-                     RTTEST_CHECK(g_hTest, *g_pfEfl == paTests[iTest].fEflOut); \
+                     RTTEST_CHECK(g_hTest, fEflOut == paTests[iTest].fEflOut); \
                 } \
             } \