Changeset 104269 in vbox for trunk/src/VBox/VMM/testcase/tstIEMAImpl.cpp

Timestamp:

Apr 10, 2024 9:42:20 AM (10 months ago)

Author:

vboxsync

Message:

VMM/IEM: Rework pcmpistri emulation to pass the new ECX value as return argument freeing up one argument which can be used to pass both source operands by reference getting rid of IEMPCMPISTRXSRC for this. This enables recompilation of pcmpistri which is used by Linux a fair bit, bugref:10641

File:

• trunk/src/VBox/VMM/testcase/tstIEMAImpl.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/testcase/tstIEMAImpl.cpp

@@ -9482 +9482 @@
             TestData.InVal2.uXmm = iTest < cTests ? RandU128() : s_aSpecials[iTest - cTests].uSrc2;
 
-            IEMPCMPISTRXSRC TestVal;
-            TestVal.uSrc1 = TestData.InVal1.uXmm;
-            TestVal.uSrc2 = TestData.InVal2.uXmm;
-
             uint32_t const fEFlagsIn = RandEFlags();
             for (uint16_t u16Imm = 0; u16Imm < 256; u16Imm++)
             {
                 uint32_t fEFlagsOut = fEFlagsIn;
-                pfn(&TestData.u32EcxOut, &fEFlagsOut, &TestVal, (uint8_t)u16Imm);
+                TestData.u32EcxOut  = pfn(&fEFlagsOut, &TestData.InVal1.uXmm,  &TestData.InVal2.uXmm, (uint8_t)u16Imm);
                 TestData.fEFlagsIn  = fEFlagsIn;
                 TestData.fEFlagsOut = fEFlagsOut;
@@ -9498 +9494 @@
 
             /* Repeat the test with the input value being the same. */
-            TestData.InVal2.uXmm = TestData.InVal1.uXmm;
-            TestVal.uSrc1 = TestData.InVal1.uXmm;
-            TestVal.uSrc2 = TestData.InVal2.uXmm;
-
             for (uint16_t u16Imm = 0; u16Imm < 256; u16Imm++)
             {
                 uint32_t fEFlagsOut = fEFlagsIn;
-                pfn(&TestData.u32EcxOut, &fEFlagsOut, &TestVal, (uint8_t)u16Imm);
+                TestData.u32EcxOut  = pfn(&fEFlagsOut, &TestData.InVal1.uXmm,  &TestData.InVal2.uXmm, (uint8_t)u16Imm);
                 TestData.fEFlagsIn  = fEFlagsIn;
                 TestData.fEFlagsOut = fEFlagsOut;
@@ -9538 +9530 @@
             for (uint32_t iTest = 0; iTest < cTests; iTest++)
             {
-                IEMPCMPISTRXSRC TestVal;
-                TestVal.uSrc1 = paTests[iTest].InVal1.uXmm;
-                TestVal.uSrc2 = paTests[iTest].InVal2.uXmm;
-
                 uint32_t fEFlags = paTests[iTest].fEFlagsIn;
-                uint32_t u32EcxOut = 0;
-                pfn(&u32EcxOut, &fEFlags, &TestVal, paTests[iTest].bImm);
+                uint32_t u32EcxOut = pfn(&fEFlags, &paTests[iTest].InVal1.uXmm, &paTests[iTest].InVal2.uXmm, paTests[iTest].bImm);
                 if (   fEFlags != paTests[iTest].fEFlagsOut
                     || u32EcxOut != paTests[iTest].u32EcxOut)