Changeset 104798 in vbox for trunk/src/VBox

Timestamp:

May 28, 2024 7:04:30 AM (6 months ago)

Author:

vboxsync

Message:

VMM/IEM: Introduce IEMNATIVE_WITH_RECOMPILER_EPILOGUE_SINGLETON as an experiment to unify the epilog for all TBs into single instance, enabling it only for arm64 right now, bugref:10677

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IEMAllN8veHlpA-arm64.S (modified) (1 diff)
• VMMAll/IEMAllN8veRecompiler.cpp (modified) (4 diffs)
• include/IEMN8veRecompiler.h (modified) (2 diffs)
• include/IEMN8veRecompilerEmit.h (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllN8veHlpA-arm64.S

@@ -95 +95 @@
         br      x2
 
+#ifdef IEMNATIVE_WITH_RECOMPILER_EPILOGUE_SINGLETON
+/**
+ * This is the common epilog for all TBs, restoring all volatile registers
+ * and cleaning up the stack frame. This is a direct jump target and not a
+ * real function to call using bl/blr.
+ */
+ALIGNCODE(IEM_HLP_FUNCTION_ALIGNMENT)
+BEGINPROC_HIDDEN iemNativeTbEpilog
+        ldp     x19, x20, [sp, #IEMNATIVE_FRAME_VAR_SIZE]!
+        ldp     x21, x22, [sp, #0x10]
+        ldp     x23, x24, [sp, #0x20]
+        ldp     x25, x26, [sp, #0x30]
+        ldp     x27, x28, [sp, #0x40]
+        ldp     x29, x30, [sp, #0x50]
+        add     sp, sp, #IEMNATIVE_FRAME_SAVE_REG_SIZE
+# ifdef RT_OS_DARWIN
+        retab
+# else
+        ret
+# endif
+#endif
+
 
 /**

trunk/src/VBox/VMM/VMMAll/IEMAllN8veRecompiler.cpp

@@ -6662 +6662 @@
     IEMNATIVE_STRICT_EFLAGS_SKIPPING_EMIT_CHECK(pReNative, off, X86_EFL_STATUS_BITS);
 
+#ifdef IEMNATIVE_WITH_RECOMPILER_EPILOGUE_SINGLETON
+    //off = iemNativeEmitBrk(pReNative, off, 0x7777);
+    off = iemNativeEmitJmpImm(pReNative, off, (uintptr_t)iemNativeTbEpilog);
+#else
     /*
      * Restore registers and return.
      */
-#ifdef RT_ARCH_AMD64
+# ifdef RT_ARCH_AMD64
     uint8_t * const pbCodeBuf = iemNativeInstrBufEnsure(pReNative, off, 20);
 
@@ -6683 +6687 @@
     pbCodeBuf[off++] = X86_OP_REX_B;            /* pop r12 */
     pbCodeBuf[off++] = 0x58 + X86_GREG_x12 - 8;
-# ifdef RT_OS_WINDOWS
+#  ifdef RT_OS_WINDOWS
     pbCodeBuf[off++] = 0x58 + X86_GREG_xDI;     /* pop rdi */
     pbCodeBuf[off++] = 0x58 + X86_GREG_xSI;     /* pop rsi */
-# endif
+#  endif
     pbCodeBuf[off++] = 0x58 + X86_GREG_xBX;     /* pop rbx */
     pbCodeBuf[off++] = 0xc9;                    /* leave */
@@ -6692 +6696 @@
     pbCodeBuf[off++] = 0xcc;                    /* int3 poison */
 
-#elif RT_ARCH_ARM64
+# elif RT_ARCH_ARM64
     uint32_t * const pu32CodeBuf = iemNativeInstrBufEnsure(pReNative, off, 10);
 
@@ -6719 +6723 @@
 
     /* retab / ret */
-# ifdef RT_OS_DARWIN /** @todo See todo on pacibsp in the prolog. */
+#  ifdef RT_OS_DARWIN /** @todo See todo on pacibsp in the prolog. */
     if (1)
         pu32CodeBuf[off++] = ARMV8_A64_INSTR_RETAB;
     else
+#  endif
+        pu32CodeBuf[off++] = ARMV8_A64_INSTR_RET;
+
+# else
+#  error "port me"
 # endif
-        pu32CodeBuf[off++] = ARMV8_A64_INSTR_RET;
-
-#else
-# error "port me"
-#endif
     IEMNATIVE_ASSERT_INSTR_BUF_ENSURE(pReNative, off);
+#endif /* IEMNATIVE_WITH_RECOMPILER_EPILOGUE_SINGLETON */
 
     /* HACK: For IEMNATIVE_STRICT_EFLAGS_SKIPPING_EMIT_CHECK. */

trunk/src/VBox/VMM/include/IEMN8veRecompiler.h

@@ -82 +82 @@
 #endif
 
+/** @def IEMNATIVE_WITH_RECOMPILER_EPILOGUE_SINGLETON
+ * Enables having only a single epilogue for native TBs. */
+#if defined(RT_ARCH_ARM64) || defined(DOXYGEN_RUNNING)
+# define IEMNATIVE_WITH_RECOMPILER_EPILOGUE_SINGLETON
+#endif
 
 /** @name Stack Frame Layout
@@ -2580 +2585 @@
 #endif
 
+#ifdef IEMNATIVE_WITH_RECOMPILER_EPILOGUE_SINGLETON
+/** The common epilog jumped to from a TB. 
+ * @note This is not a callable function! */
+extern "C" IEM_DECL_NATIVE_HLP_DEF(int, iemNativeTbEpilog, (void));
+#endif
+
 #endif /* !RT_IN_ASSEMBLER - ASM-NOINC-END */
 

trunk/src/VBox/VMM/include/IEMN8veRecompilerEmit.h

@@ -7663 +7663 @@
 
 
+/**
+ * Emits an indirect jump to an immediate 64-bit address (uses the temporary GPR).
+ */
+DECL_INLINE_THROW(uint32_t) iemNativeEmitJmpImm(PIEMRECOMPILERSTATE pReNative, uint32_t off, uintptr_t uPfn)
+{
+    off = iemNativeEmitLoadGprImm64(pReNative, off, IEMNATIVE_REG_FIXED_TMP0, uPfn);
+    return iemNativeEmitJmpViaGpr(pReNative, off, IEMNATIVE_REG_FIXED_TMP0);
+}
+
+
 /*********************************************************************************************************************************
 *   Calls.                                                                                                                       *