Changeset 104811 in vbox for trunk/src/VBox/Devices

Timestamp:

May 29, 2024 5:29:10 PM (8 months ago)

Author:

vboxsync

Message:

Devices/Graphics/DevVGA-SVGA3d-dx-dx11.cpp: removed obsolete code which used multiple D3D11 devices. bugref:9830

File:

• trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-dx-dx11.cpp (modified) (49 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-dx-dx11.cpp

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2020-2023 Oracle and/or its affiliates.
+ * Copyright (C) 2020-2024 Oracle and/or its affiliates.
  *
  * This file is part of VirtualBox base platform packages, as
@@ -38 +38 @@
 #include <iprt/asm-mem.h>
 #include <iprt/assert.h>
-#include <iprt/avl.h>
 #include <iprt/errcore.h>
 #include <iprt/mem.h>
@@ -66 +65 @@
 #endif
 
-/* One ID3D11Device object is used for all VMSVGA contexts. */
-/** @todo This should be the only option because VGPU freely uses surfaces from different VMSVGA contexts
- * and synchronization of access to shared surfaces kills performance.
+/* One ID3D11Device object is used for all VMSVGA guest contexts because the VGPU design makes resources
+ * independent from rendering contexts. I.e. multiple guest contexts freely access a surface.
+ *
+ * The initial implementation of this backend has used separate ID3D11Devices for each VMSVGA context
+ * and created shared resources to allow one ID3D11Device to access a resource which was rendered to by
+ * another ID3D11Device. This synchronization of access to shared resources kills performance actually.
  */
-#define DX_FORCE_SINGLE_DEVICE
+
 /* A single staging ID3D11Buffer is used for uploading data to other buffers. */
 #define DX_COMMON_STAGING_BUFFER
@@ -80 +82 @@
 # define D3D_RELEASE(a_Ptr) do { if ((a_Ptr)) (a_Ptr)->Release(); (a_Ptr) = NULL; } while (0)
 #endif
-
-/** Fake ID for the backend DX context. The context creates all shared textures. */
-#define DX_CID_BACKEND UINT32_C(0xfffffffe)
 
 #define D3D_RELEASE_ARRAY(a_Count, a_papArray) do { \
@@ -217 +216 @@
     } staging;
 
-    /* Screen targets are created as shared surfaces. */
-    HANDLE              SharedHandle;     /* The shared handle of this structure. */
-
-    /* DX context which last rendered to the texture.
-     * This is only for render targets and screen targets, which can be shared between contexts.
-     * The backend context (cid == DX_CID_BACKEND) can also be a drawing context.
-     */
-    uint32_t cidDrawing;
-
-    /** AVL tree containing DXSHAREDTEXTURE structures. */
-    AVLU32TREE SharedTextureTree;
-
     /* Render target views, depth stencil views and shader resource views created for this texture or buffer. */
     RTLISTANCHOR listView;                        /* DXVIEW */
 
 } VMSVGA3DBACKENDSURFACE;
-
-/* "The only resources that can be shared are 2D non-mipmapped textures." */
-typedef struct DXSHAREDTEXTURE
-{
-    AVLU32NODECORE              Core;             /* Key is context id which opened this texture. */
-    ID3D11Texture2D            *pTexture;         /* The opened shared texture. */
-    uint32_t sid;                                 /* Surface id. */
-} DXSHAREDTEXTURE;
 
 
@@ -388 +367 @@
     PFN_D3D_DISASSEMBLE        pfnD3DDisassemble;
 
-    DXDEVICE                   dxDevice;               /* Device for the VMSVGA3D context independent operation. */
+    DXDEVICE                   dxDevice;
     UINT                       VendorId;
     UINT                       DeviceId;
@@ -395 +374 @@
 
     DXBOUNDRESOURCES           resources;              /* What is currently applied to the pipeline. */
-
-    bool                       fSingleDevice;          /* Whether to use one DX device for all guest contexts. */
-
-    /** @todo Here a set of functions which do different job in single and multiple device modes. */
 } VMSVGA3DBACKEND;
 
@@ -1196 +1171 @@
     int rc = VINF_SUCCESS;
 
-    if (pBackend->fSingleDevice && pBackend->dxDevice.pDevice)
+    if (pBackend->dxDevice.pDevice)
     {
         pDXDevice->pDevice = pBackend->dxDevice.pDevice;
@@ -1482 +1457 @@
 
 
-DECLINLINE(bool) dxIsSurfaceShareable(PVMSVGA3DSURFACE pSurface)
-{
-    /* It is not expected that volume textures will be shared between contexts. */
-    if (pSurface->f.surfaceFlags & SVGA3D_SURFACE_VOLUME)
-        return false;
-
-    return (pSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET)
-        || (pSurface->f.surfaceFlags & SVGA3D_SURFACE_BIND_RENDER_TARGET);
-}
-
-
+/// @todo Rename, parameters
 static DXDEVICE *dxDeviceFromCid(uint32_t cid, PVMSVGA3DSTATE pState)
 {
-    if (cid != DX_CID_BACKEND)
-    {
-        if (pState->pBackend->fSingleDevice)
-            return &pState->pBackend->dxDevice;
-
-        VMSVGA3DDXCONTEXT *pDXContext;
-        int rc = vmsvga3dDXContextFromCid(pState, cid, &pDXContext);
-        if (RT_SUCCESS(rc))
-            return &pDXContext->pBackendDXContext->dxDevice;
-    }
-    else
-        return &pState->pBackend->dxDevice;
-
-    AssertFailed();
-    return NULL;
-}
-
-
+    RT_NOREF(cid);
+    return &pState->pBackend->dxDevice;
+}
+
+
+/// @todo Rename, parameters
 static DXDEVICE *dxDeviceFromContext(PVMSVGA3DSTATE p3dState, VMSVGA3DDXCONTEXT *pDXContext)
 {
-    DXDEVICE *pDXDevice;
-    if (pDXContext && !p3dState->pBackend->fSingleDevice)
-        pDXDevice = &pDXContext->pBackendDXContext->dxDevice;
-    else
-        pDXDevice = &p3dState->pBackend->dxDevice;
-
+    RT_NOREF(pDXContext);
+    DXDEVICE *pDXDevice = &p3dState->pBackend->dxDevice;
 #ifdef DEBUG
     HRESULT hr = pDXDevice->pDevice->GetDeviceRemovedReason();
@@ -1553 +1502 @@
 
 
-static int dxContextWait(uint32_t cidDrawing, PVMSVGA3DSTATE pState)
-{
-    if (pState->pBackend->fSingleDevice)
-      return VINF_SUCCESS;
-
-    /* Flush cidDrawing context and issue a query. */
-    DXDEVICE *pDXDevice = dxDeviceFromCid(cidDrawing, pState);
-    if (pDXDevice)
-        return dxDeviceFlush(pDXDevice);
-    /* cidDrawing does not exist anymore. */
-    return VINF_SUCCESS;
-}
-
-
-static int dxSurfaceWait(PVMSVGA3DSTATE pState, PVMSVGA3DSURFACE pSurface, uint32_t cidRequesting)
-{
-    if (pState->pBackend->fSingleDevice)
-        return VINF_SUCCESS;
-
-    VMSVGA3DBACKENDSURFACE *pBackendSurface = pSurface->pBackendSurface;
-    if (!pBackendSurface)
-        AssertFailedReturn(VERR_INVALID_STATE);
-
-    int rc = VINF_SUCCESS;
-    if (pBackendSurface->cidDrawing != SVGA_ID_INVALID)
-    {
-        if (pBackendSurface->cidDrawing != cidRequesting)
-        {
-            LogFunc(("sid = %u, assoc cid = %u, drawing cid = %u, req cid = %u\n",
-                     pSurface->id, pSurface->idAssociatedContext, pBackendSurface->cidDrawing, cidRequesting));
-            Assert(dxIsSurfaceShareable(pSurface));
-            rc = dxContextWait(pBackendSurface->cidDrawing, pState);
-            pBackendSurface->cidDrawing = SVGA_ID_INVALID;
-        }
-    }
-    return rc;
-}
-
-
+/// @todo Parameters
 static ID3D11Resource *dxResource(PVMSVGA3DSTATE pState, PVMSVGA3DSURFACE pSurface, VMSVGA3DDXCONTEXT *pDXContext)
 {
+    RT_NOREF(pState, pDXContext);
     VMSVGA3DBACKENDSURFACE *pBackendSurface = pSurface->pBackendSurface;
     if (!pBackendSurface)
         AssertFailedReturn(NULL);
 
-    ID3D11Resource *pResource;
-
-    uint32_t const cidRequesting = pDXContext ? pDXContext->cid : DX_CID_BACKEND;
-    if (cidRequesting == pSurface->idAssociatedContext || pState->pBackend->fSingleDevice)
-        pResource = pBackendSurface->u.pResource;
-    else
-    {
-        /*
-         * Context, which as not created the surface, is requesting.
-         */
-        AssertReturn(pDXContext, NULL);
-
-        Assert(dxIsSurfaceShareable(pSurface));
-        Assert(pSurface->idAssociatedContext == DX_CID_BACKEND);
-
-        DXSHAREDTEXTURE *pSharedTexture = (DXSHAREDTEXTURE *)RTAvlU32Get(&pBackendSurface->SharedTextureTree, pDXContext->cid);
-        if (!pSharedTexture)
-        {
-            DXDEVICE *pDevice = dxDeviceFromContext(pState, pDXContext);
-            AssertReturn(pDevice->pDevice, NULL);
-
-            AssertReturn(pBackendSurface->SharedHandle, NULL);
-
-            /* This context has not yet opened the texture. */
-            pSharedTexture = (DXSHAREDTEXTURE *)RTMemAllocZ(sizeof(DXSHAREDTEXTURE));
-            AssertReturn(pSharedTexture, NULL);
-
-            pSharedTexture->Core.Key = pDXContext->cid;
-            bool const fSuccess = RTAvlU32Insert(&pBackendSurface->SharedTextureTree, &pSharedTexture->Core);
-            AssertReturn(fSuccess, NULL);
-
-            HRESULT hr = pDevice->pDevice->OpenSharedResource(pBackendSurface->SharedHandle, __uuidof(ID3D11Texture2D), (void**)&pSharedTexture->pTexture);
-            Assert(SUCCEEDED(hr));
-            if (SUCCEEDED(hr))
-                pSharedTexture->sid = pSurface->id;
-            else
-            {
-                RTAvlU32Remove(&pBackendSurface->SharedTextureTree, pDXContext->cid);
-                RTMemFree(pSharedTexture);
-                return NULL;
-            }
-        }
-
-        pResource = pSharedTexture->pTexture;
-    }
-
-    /* Wait for drawing to finish. */
-    dxSurfaceWait(pState, pSurface, cidRequesting);
-
-    return pResource;
+    return pBackendSurface->u.pResource;
 }
 
@@ -1657 +1520 @@
     SVGACOTableDXRTViewEntry const *pRTViewEntry = &pDXContext->cot.paRTView[renderTargetViewId];
     return pRTViewEntry->sid;
-}
-
-
-static int dxTrackRenderTargets(PVGASTATECC pThisCC, PVMSVGA3DDXCONTEXT pDXContext)
-{
-    PVMSVGA3DSTATE pState = pThisCC->svga.p3dState;
-    AssertReturn(pState, VERR_INVALID_STATE);
-
-    for (unsigned long i = 0; i < RT_ELEMENTS(pDXContext->svgaDXContext.renderState.renderTargetViewIds); ++i)
-    {
-        uint32_t const renderTargetViewId = pDXContext->svgaDXContext.renderState.renderTargetViewIds[i];
-        if (renderTargetViewId == SVGA_ID_INVALID)
-            continue;
-
-        uint32_t const sid = dxGetRenderTargetViewSid(pDXContext, renderTargetViewId);
-        LogFunc(("[%u] sid = %u, drawing cid = %u\n", i, sid, pDXContext->cid));
-
-        PVMSVGA3DSURFACE pSurface;
-        int rc = vmsvga3dSurfaceFromSid(pState, sid, &pSurface);
-        if (RT_SUCCESS(rc))
-        {
-            AssertContinue(pSurface->pBackendSurface);
-            pSurface->pBackendSurface->cidDrawing = pDXContext->cid;
-        }
-    }
-    return VINF_SUCCESS;
 }
 
@@ -2487 +2324 @@
     PVMSVGA3DBACKENDSURFACE pBackendSurface = (PVMSVGA3DBACKENDSURFACE)RTMemAllocZ(sizeof(VMSVGA3DBACKENDSURFACE));
     AssertPtrReturn(pBackendSurface, VERR_NO_MEMORY);
-    pBackendSurface->cidDrawing = SVGA_ID_INVALID;
     RTListInit(&pBackendSurface->listView);
     *ppBackendSurface = pBackendSurface;
     return VINF_SUCCESS;
-}
-
-
-static HRESULT dxInitSharedHandle(PVMSVGA3DBACKEND pBackend, PVMSVGA3DBACKENDSURFACE pBackendSurface)
-{
-    if (pBackend->fSingleDevice)
-        return S_OK;
-
-    /* Get the shared handle. */
-    IDXGIResource *pDxgiResource = NULL;
-    HRESULT hr = pBackendSurface->u.pResource->QueryInterface(__uuidof(IDXGIResource), (void**)&pDxgiResource);
-    Assert(SUCCEEDED(hr));
-    if (SUCCEEDED(hr))
-    {
-        hr = pDxgiResource->GetSharedHandle(&pBackendSurface->SharedHandle);
-        Assert(SUCCEEDED(hr));
-        D3D_RELEASE(pDxgiResource);
-    }
-
-    return hr;
 }
 
@@ -2537 +2353 @@
 
 
+/// @todo Parameters
 static DXDEVICE *dxSurfaceDevice(PVMSVGA3DSTATE p3dState, PVMSVGA3DSURFACE pSurface, PVMSVGA3DDXCONTEXT pDXContext, UINT *pMiscFlags)
 {
-    if (p3dState->pBackend->fSingleDevice)
-    {
-        *pMiscFlags = 0;
-        return &p3dState->pBackend->dxDevice;
-    }
-
-    if (!pDXContext || dxIsSurfaceShareable(pSurface))
-    {
-        *pMiscFlags = D3D11_RESOURCE_MISC_SHARED;
-        return &p3dState->pBackend->dxDevice;
-    }
-
+    RT_NOREF(pSurface, pDXContext);
     *pMiscFlags = 0;
-    return &pDXContext->pBackendDXContext->dxDevice;
+    return &p3dState->pBackend->dxDevice;
 }
 
@@ -2806 +2612 @@
 
         if (SUCCEEDED(hr))
-            hr = dxInitSharedHandle(pBackend, pBackendSurface);
-
-        if (SUCCEEDED(hr))
         {
             pBackendSurface->enmResType = VMSVGA3D_RESTYPE_TEXTURE_CUBE;
@@ -2861 +2664 @@
             Assert(SUCCEEDED(hr));
         }
-
-        if (SUCCEEDED(hr))
-            hr = dxInitSharedHandle(pBackend, pBackendSurface);
 
         if (SUCCEEDED(hr))
@@ -2921 +2721 @@
                 Assert(SUCCEEDED(hr));
             }
-
-            if (SUCCEEDED(hr))
-                hr = dxInitSharedHandle(pBackend, pBackendSurface);
 
             if (SUCCEEDED(hr))
@@ -2986 +2783 @@
 
             if (SUCCEEDED(hr))
-                hr = dxInitSharedHandle(pBackend, pBackendSurface);
-
-            if (SUCCEEDED(hr))
             {
                 pBackendSurface->enmResType = VMSVGA3D_RESTYPE_TEXTURE_2D;
@@ -3017 +2811 @@
         pBackendSurface->enmDxgiFormat = dxgiFormat;
         pSurface->pBackendSurface = pBackendSurface;
-        if (p3dState->pBackend->fSingleDevice || RT_BOOL(MiscFlags & D3D11_RESOURCE_MISC_SHARED))
-            pSurface->idAssociatedContext = DX_CID_BACKEND;
-        else
-            pSurface->idAssociatedContext = pDXContext->cid;
         return VINF_SUCCESS;
     }
@@ -3110 +2900 @@
         pBackendSurface->enmDxgiFormat = DXGI_FORMAT_UNKNOWN;
         pSurface->pBackendSurface = pBackendSurface;
-        pSurface->idAssociatedContext = pDXContext->cid;
         return VINF_SUCCESS;
     }
@@ -3183 +2972 @@
         pBackendSurface->enmDxgiFormat = DXGI_FORMAT_UNKNOWN;
         pSurface->pBackendSurface = pBackendSurface;
-        pSurface->idAssociatedContext = pDXContext->cid;
         return VINF_SUCCESS;
     }
@@ -3255 +3043 @@
         pBackendSurface->enmDxgiFormat = DXGI_FORMAT_UNKNOWN;
         pSurface->pBackendSurface = pBackendSurface;
-        pSurface->idAssociatedContext = pDXContext->cid;
         return VINF_SUCCESS;
     }
@@ -3395 +3182 @@
          */
         pSurface->pBackendSurface = pBackendSurface;
-        pSurface->idAssociatedContext = pDXContext->cid;
         return VINF_SUCCESS;
     }
@@ -3511 +3297 @@
         Log6Func(("Load D3DDisassemble: %Rrc\n", rc2));
     }
-
-#if !defined(RT_OS_WINDOWS) || defined(DX_FORCE_SINGLE_DEVICE)
-    pBackend->fSingleDevice = true;
-#endif
-
-    LogRelMax(1, ("VMSVGA: Single DX device mode: %s\n", pBackend->fSingleDevice ? "enabled" : "disabled"));
 
     vmsvga3dDXInitContextMobData(&pBackend->svgaDXContext);
@@ -3872 +3652 @@
         || pBackendSurface->enmResType == VMSVGA3D_RESTYPE_TEXTURE_3D)
     {
-        dxSurfaceWait(pState, pSurface, pSurface->idAssociatedContext);
-
         ID3D11Resource *pMappedResource;
         if (enmMapType == VMSVGA3D_SURFACE_MAP_READ)
@@ -4090 +3868 @@
             pDevice->pImmediateContext->CopySubresourceRegion(pDstResource, DstSubresource, DstX, DstY, DstZ,
                                                               pSrcResource, SrcSubresource, pSrcBox);
-
-            pBackendSurface->cidDrawing = pSurface->idAssociatedContext;
         }
     }
@@ -4164 +3940 @@
             pDevice->pImmediateContext->CopySubresourceRegion(pDstResource, DstSubresource, DstX, DstY, DstZ,
                                                               pSrcResource, SrcSubresource, &SrcBox);
-
-            pBackendSurface->cidDrawing = pSurface->idAssociatedContext;
         }
 #endif
@@ -4263 +4037 @@
     vmsvgaR3Clip3dRect(&boundRect, &clipRect);
     ASSERT_GUEST_RETURN(clipRect.w && clipRect.h, VERR_INVALID_PARAMETER);
-
-    /* Wait for the surface to finish drawing. */
-    dxSurfaceWait(pState, pSurface, DX_CID_BACKEND);
 
     /* Copy the screen texture to the shared surface. */
@@ -4880 +4651 @@
     AssertRCReturn(rc, rc);
 
-    LogFunc(("src%s cid %d -> dst%s cid %d\n",
-             pSrcSurface->pBackendSurface ? "" : " sysmem",
-             pSrcSurface ? pSrcSurface->idAssociatedContext : SVGA_ID_INVALID,
-             pDstSurface->pBackendSurface ? "" : " sysmem",
-             pDstSurface ? pDstSurface->idAssociatedContext : SVGA_ID_INVALID));
+    LogFunc(("src%s sid = %u -> dst%s sid = %u\n",
+             pSrcSurface->pBackendSurface ? "" : " sysmem", pSrcSurface->id,
+             pDstSurface->pBackendSurface ? "" : " sysmem", pDstSurface->id));
 
     //DXDEVICE *pDevice = dxDeviceFromContext(pThisCC->svga.p3dState, pDXContext);
@@ -4893 +4662 @@
         if (pDstSurface->pBackendSurface == NULL)
         {
-            /* Create the target if it can be used as a device context shared resource (render or screen target). */
-            if (pBackend->fSingleDevice || dxIsSurfaceShareable(pDstSurface))
-            {
-                rc = vmsvga3dBackSurfaceCreateTexture(pThisCC, NULL, pDstSurface);
-                AssertRCReturn(rc, rc);
-            }
+            rc = vmsvga3dBackSurfaceCreateTexture(pThisCC, NULL, pDstSurface);
+            AssertRCReturn(rc, rc);
         }
 
@@ -4904 +4669 @@
         {
             /* Surface -> Surface. */
-            /* Expect both of them to be shared surfaces created by the backend context. */
-            Assert(pSrcSurface->idAssociatedContext == DX_CID_BACKEND && pDstSurface->idAssociatedContext == DX_CID_BACKEND);
-
-            /* Wait for the source surface to finish drawing. */
-            dxSurfaceWait(pState, pSrcSurface, DX_CID_BACKEND);
-
             DXDEVICE *pDXDevice = &pBackend->dxDevice;
 
@@ -4947 +4706 @@
             pDXDevice->pImmediateContext->CopySubresourceRegion(pDstResource, DstSubresource, DstX, DstY, DstZ,
                                                                 pSrcResource, SrcSubresource, &SrcBox);
-
-            pDstSurface->pBackendSurface->cidDrawing = DX_CID_BACKEND;
         }
         else
@@ -5400 +5157 @@
 
     RTMemFree(pBackendSurface);
-
-    /* No context has created the surface, because the surface does not exist anymore. */
-    pSurface->idAssociatedContext = SVGA_ID_INVALID;
 }
 
@@ -5760 +5514 @@
         RTMemFreeZ(pBackendDXContext->paVideoProcessorOutputView, sizeof(pBackendDXContext->paVideoProcessorOutputView[0]) * pBackendDXContext->cVideoProcessorOutputView);
 
-        /* Destroy backend surfaces which belong to this context. */
-        /** @todo The context should have a list of surfaces (and also shared resources). */
-        /** @todo This should not be needed in fSingleDevice mode. */
-        for (uint32_t sid = 0; sid < pThisCC->svga.p3dState->cSurfaces; ++sid)
-        {
-            PVMSVGA3DSURFACE const pSurface = pThisCC->svga.p3dState->papSurfaces[sid];
-            if (   pSurface
-                && pSurface->id == sid)
-            {
-                if (pSurface->idAssociatedContext == pDXContext->cid)
-                {
-                    if (pSurface->pBackendSurface)
-                        vmsvga3dBackSurfaceDestroy(pThisCC, true, pSurface);
-                }
-                else if (pSurface->idAssociatedContext == DX_CID_BACKEND)
-                {
-                    /* May have shared resources in this context. */
-                    if (pSurface->pBackendSurface)
-                    {
-                        DXSHAREDTEXTURE *pSharedTexture = (DXSHAREDTEXTURE *)RTAvlU32Get(&pSurface->pBackendSurface->SharedTextureTree, pDXContext->cid);
-                        if (pSharedTexture)
-                        {
-                            Assert(pSharedTexture->sid == sid);
-                            RTAvlU32Remove(&pSurface->pBackendSurface->SharedTextureTree, pDXContext->cid);
-                            D3D_RELEASE(pSharedTexture->pTexture);
-                            RTMemFreeZ(pSharedTexture, sizeof(*pSharedTexture));
-                        }
-                    }
-                }
-            }
-        }
-
         dxDeviceDestroy(pBackend, &pBackendDXContext->dxDevice);
 
@@ -5811 +5533 @@
 static DECLCALLBACK(int) vmsvga3dBackDXSwitchContext(PVGASTATECC pThisCC, PVMSVGA3DDXCONTEXT pDXContext)
 {
-    PVMSVGA3DBACKEND pBackend = pThisCC->svga.p3dState->pBackend;
-    if (!pBackend->fSingleDevice)
-        return VINF_NOT_IMPLEMENTED; /* Not required. */
-
     /* The new context state will be applied by the generic DX code. */
-    RT_NOREF(pDXContext);
+    RT_NOREF(pThisCC, pDXContext);
     return VINF_SUCCESS;
 }
@@ -7378 +7096 @@
     }
 
-    /* Note which surfaces are being drawn. */
-    dxTrackRenderTargets(pThisCC, pDXContext);
-
 #ifdef DX_FLUSH_AFTER_DRAW
     dxDeviceFlush(pDevice);
@@ -7637 +7352 @@
     }
 
-    /* Note which surfaces are being drawn. */
-    dxTrackRenderTargets(pThisCC, pDXContext);
-
 #ifdef DX_FLUSH_AFTER_DRAW
     dxDeviceFlush(pDevice);
@@ -7668 +7380 @@
     pDevice->pImmediateContext->DrawInstanced(vertexCountPerInstance, instanceCount, startVertexLocation, startInstanceLocation);
 
-    /* Note which surfaces are being drawn. */
-    dxTrackRenderTargets(pThisCC, pDXContext);
-
 #ifdef DX_FLUSH_AFTER_DRAW
     dxDeviceFlush(pDevice);
@@ -7699 +7408 @@
     pDevice->pImmediateContext->DrawIndexedInstanced(indexCountPerInstance, instanceCount, startIndexLocation, baseVertexLocation, startInstanceLocation);
 
-    /* Note which surfaces are being drawn. */
-    dxTrackRenderTargets(pThisCC, pDXContext);
-
 #ifdef DX_FLUSH_AFTER_DRAW
     dxDeviceFlush(pDevice);
@@ -7723 +7429 @@
 
     pDevice->pImmediateContext->DrawAuto();
-
-    /* Note which surfaces are being drawn. */
-    dxTrackRenderTargets(pThisCC, pDXContext);
 
 #ifdef DX_FLUSH_AFTER_DRAW
@@ -8410 +8113 @@
     }
 
-    LogFunc(("cid %d: src cid %d%s -> dst cid %d%s\n",
-             pDXContext->cid, pSrcSurface->idAssociatedContext,
-             (pSrcSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET) ? " st" : "",
-             pDstSurface->idAssociatedContext,
-             (pDstSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET) ? " st" : ""));
+    LogFunc(("src%s sid = %u -> dst%s sid = %u\n",
+             (pSrcSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET) ? " st" : "", pSrcSurface->id,
+             (pDstSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET) ? " st" : "", pDstSurface->id));
 
     /* Clip the box. */
@@ -8476 +8177 @@
 #endif
 
-    pDstSurface->pBackendSurface->cidDrawing = pDXContext->cid;
     return VINF_SUCCESS;
 }
@@ -8517 +8217 @@
     }
 
-    LogFunc(("cid %d: src cid %d%s -> dst cid %d%s\n",
-             pDXContext->cid, pSrcSurface->idAssociatedContext,
-             (pSrcSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET) ? " st" : "",
-             pDstSurface->idAssociatedContext,
-             (pDstSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET) ? " st" : ""));
+    LogFunc(("src%s sid = %u -> dst%s sid = %u\n",
+             (pSrcSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET) ? " st" : "", pSrcSurface->id,
+             (pDstSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET) ? " st" : "", pDstSurface->id));
 
     ID3D11Resource *pDstResource = dxResource(pThisCC->svga.p3dState, pDstSurface, pDXContext);
@@ -8528 +8226 @@
     pDevice->pImmediateContext->CopyResource(pDstResource, pSrcResource);
 
-    pDstSurface->pBackendSurface->cidDrawing = pDXContext->cid;
     return VINF_SUCCESS;
 }
@@ -8829 +8526 @@
 #endif
 
-    LogFunc(("cid %d: src cid %d%s -> dst cid %d%s\n",
-             pDXContext->cid, pSrcSurface->idAssociatedContext,
-             (pSrcSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET) ? " st" : "",
-             pDstSurface->idAssociatedContext,
-             (pDstSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET) ? " st" : ""));
+    LogFunc(("src%s sid = %u -> dst%s sid = %u\n",
+             (pSrcSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET) ? " st" : "", pSrcSurface->id,
+             (pDstSurface->f.surfaceFlags & SVGA3D_SURFACE_SCREENTARGET) ? " st" : "", pDstSurface->id));
 
     /* Clip the box. */
@@ -8895 +8590 @@
     D3D_RELEASE(pDstRenderTargetView);
 
-    pDstSurface->pBackendSurface->cidDrawing = pDXContext->cid;
     return VINF_SUCCESS;
 }
@@ -9849 +9543 @@
     vmsvgaR3ClipCopyBox(&pMipLevel->mipmapSize, &pMipLevel->mipmapSize, &clipBox);
 
-    LogFunc(("surface%s cid %d\n",
-             pSurface->pBackendSurface ? "" : " sysmem",
-             pSurface ? pSurface->idAssociatedContext : SVGA_ID_INVALID));
+    LogFunc(("surface%s sid = %u\n",
+             pSurface->pBackendSurface ? "" : " sysmem", pSurface->id));
 
     if (pSurface->pBackendSurface)
@@ -9940 +9633 @@
     pDXDevice->pImmediateContext->ResolveSubresource(pDstResource, dstSubResource, pSrcResource, srcSubResource, dxgiFormat);
 
-    pDstSurface->pBackendSurface->cidDrawing = pDXContext->cid;
     return VINF_SUCCESS;
 }
@@ -10103 +9795 @@
     pDevice->pImmediateContext->DrawIndexedInstancedIndirect(pBufferForArgs, byteOffsetForArgs);
 
-    /* Note which surfaces are being drawn. */
-    dxTrackRenderTargets(pThisCC, pDXContext);
-
 #ifdef DX_FLUSH_AFTER_DRAW
     dxDeviceFlush(pDevice);
@@ -10142 +9831 @@
 
     pDevice->pImmediateContext->DrawInstancedIndirect(pBufferForArgs, byteOffsetForArgs);
-
-    /* Note which surfaces are being drawn. */
-    dxTrackRenderTargets(pThisCC, pDXContext);
 
 #ifdef DX_FLUSH_AFTER_DRAW