Changeset 107471 in vbox for trunk/src/VBox/Main/src-server/UnattendedScript.cpp

Timestamp:

Jan 7, 2025 3:14:01 PM (3 weeks ago)

Author:

vboxsync

Message:

Main/src-server/UnattendedScript.cpp: Don't call Utf8Str::find() multiple times in the RT_MIN() macro expansion, Utf8Str::find() has no side effects but calling it twice is just a waste of time, bugref:3409

File:

• trunk/src/VBox/Main/src-server/UnattendedScript.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/UnattendedScript.cpp

@@ -754 +754 @@
         pszValue = rstrTmp.assign(mpUnattended->i_getHostname(), 0, mpUnattended->i_getHostname().find(".")).c_str();
     else if (IS_MATCH("HOSTNAME_WITHOUT_DOMAIN_MAX_15"))
-        pszValue = rstrTmp.assign(mpUnattended->i_getHostname(), 0, RT_MIN(mpUnattended->i_getHostname().find("."), 15)).c_str();
+    {
+        size_t const idxDot = mpUnattended->i_getHostname().find(".");
+        pszValue = rstrTmp.assign(mpUnattended->i_getHostname(), 0, RT_MIN(idxDot, 15)).c_str();
+    }
     else if (IS_MATCH("HOSTNAME_DOMAIN"))
         pszValue = rstrTmp.assign(mpUnattended->i_getHostname(), mpUnattended->i_getHostname().find(".") + 1).c_str();