Changeset 107736 in vbox for trunk/src/VBox/Storage/VMDK.cpp

Timestamp:

Jan 14, 2025 9:11:31 AM (5 weeks ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166843

Message:

Storage/VMDK.cpp: Fix parfait warning about unused assignment, we should return an error if memory allocation fails + todos, bugref:3409

File:

• trunk/src/VBox/Storage/VMDK.cpp (modified) (3 diffs)

trunk/src/VBox/Storage/VMDK.cpp

@@ -8660 +8660 @@
         return VERR_NO_MEMORY;
 
+    /** @todo r=aeichner Carefully review the error handling logic, we mustn't leave the image in an inconsistent
+     *                   state if something fails, apart from hard underlying I/O errors of course.
+     *                   Memory allocation failures should not cause any corruptions.
+     */
     int rc;
     do
@@ -8669 +8673 @@
         uint32_t cbGTOff = RT_ALIGN_Z(VMDK_SECTOR2BYTE(cDirSectorDiff + cTableSectorDiff + cDirSectorDiff), 512);
 
+        /** @todo r=aeichner An error here doesn't make the whole operation fail, it just breaks out of the loop. */ 
         for (int i = pExtent->cGDEntries - 1; i >= 0; i--)
         {
@@ -8776 +8781 @@
             pExtent->pRGD = (uint32_t *)RTMemReallocZ(pExtent->pRGD, pExtent->cGDEntries * sizeof(uint32_t), cbNewGD);
             if (RT_UNLIKELY(!pExtent->pRGD))
-                rc = VERR_NO_MEMORY;
+                return VERR_NO_MEMORY;
         }
     }