Changeset 108014 in vbox for trunk/src/VBox/Runtime/common/script/scriptlex.cpp

Timestamp:

Feb 1, 2025 7:20:09 PM (4 weeks ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167286

Message:

Runtime/common/script/scriptlex.cpp: Fix C string literal scanning and add some helper APIs to create tokens for errors and identifiers, bugref:10733

File:

• trunk/src/VBox/Runtime/common/script/scriptlex.cpp (modified) (15 diffs)

trunk/src/VBox/Runtime/common/script/scriptlex.cpp

@@ -422 +422 @@
 
 
-/**
- * Produce an error token with the given error message.
- *
- * @returns IPRT status code.
- * @param   pThis                  The lexer state.
- * @param   pTok                   The token to fill.
- * @param   rc                     The status code to use in the message.
- * @param   pszMsg                 The format string for the error message.
- * @param   ...                    Arguments to the format string.
- */
-static int rtScriptLexProduceTokError(PRTSCRIPTLEXINT pThis, PRTSCRIPTLEXTOKEN pTok,
-                                      int rc, const char *pszMsg, ...)
-{
+RTDECL(int) RTScriptLexProduceTokError(RTSCRIPTLEX hScriptLex, PRTSCRIPTLEXTOKEN pTok,
+                                       int rc, const char *pszMsg, ...)
+{
+    PRTSCRIPTLEXINT pThis = hScriptLex;
+
     va_list va;
     va_start(va, pszMsg);
@@ -447 +439 @@
 
     return rc;
+}
+
+
+RTDECL(int) RTScriptLexProduceTokIde(RTSCRIPTLEX hScriptLex, PRTSCRIPTLEXTOKEN pTok, const char *pszIde, size_t cchIde)
+{
+    PRTSCRIPTLEXINT pThis = hScriptLex;
+
+    /* Insert into string cache. */
+    pTok->enmType = RTSCRIPTLEXTOKTYPE_IDENTIFIER;
+    pTok->Type.Id.pszIde = RTStrCacheEnterN(pThis->hStrCacheId, pszIde, cchIde);
+    if (RT_UNLIKELY(!pTok->Type.Id.pszIde))
+        return RTScriptLexProduceTokError(hScriptLex, pTok, VERR_NO_STR_MEMORY, "Lexer: Out of memory inserting identifier into string cache");
+
+    pTok->PosEnd = pThis->Pos;
+    return VINF_SUCCESS;
 }
 
@@ -476 +483 @@
             break;
         default:
-            rtScriptLexProduceTokError(pThis, pTok, VERR_INVALID_PARAMETER,
+            RTScriptLexProduceTokError(pThis, pTok, VERR_INVALID_PARAMETER,
                                        "Lexer: The match contains an invalid token type: %d\n",
                                        pTok->enmType);
@@ -541 +548 @@
             pThis->rcRdr = pThis->pCfg->pfnProdDef(pThis, ch, pTok, pThis->pCfg->pvProdDefUser);
         else
-            rtScriptLexProduceTokError(pThis, pTok, VERR_INVALID_PARAMETER,
+            RTScriptLexProduceTokError(pThis, pTok, VERR_INVALID_PARAMETER,
                                        "Lexer: Invalid character found in input: %c\n",
                                        ch);
@@ -974 +981 @@
     if (   idx == sizeof(aszIde) - 1
         && rtScriptLexLocateChInStrConsume(hScriptLex, ch, pszCharSet))
-        return rtScriptLexProduceTokError(hScriptLex, pTok, VERR_BUFFER_OVERFLOW, "Lexer: Identifier exceeds the allowed length");
+        return RTScriptLexProduceTokError(hScriptLex, pTok, VERR_BUFFER_OVERFLOW, "Lexer: Identifier exceeds the allowed length");
 
     /* Insert into string cache. */
@@ -980 +987 @@
     pTok->Type.Id.pszIde = RTStrCacheEnterN(pThis->hStrCacheId, &aszIde[0], idx);
     if (RT_UNLIKELY(!pTok->Type.Id.pszIde))
-        return rtScriptLexProduceTokError(hScriptLex, pTok, VERR_NO_STR_MEMORY, "Lexer: Out of memory inserting identifier into string cache");
+        return RTScriptLexProduceTokError(hScriptLex, pTok, VERR_NO_STR_MEMORY, "Lexer: Out of memory inserting identifier into string cache");
 
     pTok->PosEnd = pThis->Pos;
@@ -1034 +1041 @@
     int rc = rtScriptLexScanStringLiteralChAdd(pThis, '\0', idxChCur);
     if (RT_FAILURE(rc))
-        return rtScriptLexProduceTokError(hScriptLex, pTok, rc, "Lexer: Error adding character to string literal");
+        return RTScriptLexProduceTokError(hScriptLex, pTok, rc, "Lexer: Error adding character to string literal");
 
     ch = RTScriptLexGetCh(hScriptLex);
@@ -1040 +1047 @@
     {
         if (ch == '\0')
-            return rtScriptLexProduceTokError(hScriptLex, pTok, VERR_EOF, "Lexer: End of stream before closing string literal terminal");
+            return RTScriptLexProduceTokError(hScriptLex, pTok, VERR_EOF, "Lexer: End of stream before closing string literal terminal");
         else if (ch == '\"')
         {
+            RTScriptLexConsumeCh(hScriptLex);
+
             /* End of string, add it to the string literal cache and build the token. */
             pTok->enmType = RTSCRIPTLEXTOKTYPE_STRINGLIT;
@@ -1048 +1057 @@
             pTok->Type.StringLit.pszString = RTStrCacheEnterN(pThis->hStrCacheStringLit, pThis->pszStrLit, idxChCur);
             if (RT_UNLIKELY(!pTok->Type.StringLit.pszString))
-                return rtScriptLexProduceTokError(hScriptLex, pTok, VERR_NO_STR_MEMORY, "Lexer: Error adding string literal to the cache");
+                return RTScriptLexProduceTokError(hScriptLex, pTok, VERR_NO_STR_MEMORY, "Lexer: Error adding string literal to the cache");
             else
                 break;
@@ -1104 +1113 @@
                 default:
                     /* Not supported for now. */
-                    return rtScriptLexProduceTokError(hScriptLex, pTok, VERR_NOT_SUPPORTED, "Lexer: Invalid/unsupported escape sequence");
+                    return RTScriptLexProduceTokError(hScriptLex, pTok, VERR_NOT_SUPPORTED, "Lexer: Invalid/unsupported escape sequence");
             }
         }
@@ -1112 +1121 @@
             idxChCur++;
         else
-            return rtScriptLexProduceTokError(hScriptLex, pTok, rc, "Lexer: Error adding character to string literal");
+            return RTScriptLexProduceTokError(hScriptLex, pTok, rc, "Lexer: Error adding character to string literal");
 
         ch = RTScriptLexConsumeChEx(hScriptLex, RTSCRIPT_LEX_CONV_F_NOTHING);
@@ -1132 +1141 @@
     int rc = rtScriptLexScanStringLiteralChAdd(pThis, '\0', idxChCur);
     if (RT_FAILURE(rc))
-        return rtScriptLexProduceTokError(hScriptLex, pTok, rc, "Lexer: Error adding character to string literal");
+        return RTScriptLexProduceTokError(hScriptLex, pTok, rc, "Lexer: Error adding character to string literal");
 
     ch = RTScriptLexGetChEx(hScriptLex, RTSCRIPT_LEX_CONV_F_NOTHING);
@@ -1138 +1147 @@
     {
         if (ch == '\0')
-            return rtScriptLexProduceTokError(hScriptLex, pTok, VERR_EOF, "Lexer: End of stream before closing string literal terminal");
+            return RTScriptLexProduceTokError(hScriptLex, pTok, VERR_EOF, "Lexer: End of stream before closing string literal terminal");
         else if (ch == '\'')
         {
@@ -1153 +1162 @@
                 pTok->Type.StringLit.pszString = RTStrCacheEnterN(pThis->hStrCacheStringLit, pThis->pszStrLit, idxChCur);
                 if (RT_UNLIKELY(!pTok->Type.StringLit.pszString))
-                    return rtScriptLexProduceTokError(hScriptLex, pTok, VERR_NO_STR_MEMORY, "Lexer: Error adding string literal to the cache");
+                    return RTScriptLexProduceTokError(hScriptLex, pTok, VERR_NO_STR_MEMORY, "Lexer: Error adding string literal to the cache");
                 else
                     break;
@@ -1164 +1173 @@
             idxChCur++;
         else
-            return rtScriptLexProduceTokError(hScriptLex, pTok, rc, "Lexer: Error adding character to string literal");
+            return RTScriptLexProduceTokError(hScriptLex, pTok, rc, "Lexer: Error adding character to string literal");
         ch = RTScriptLexConsumeChEx(hScriptLex, RTSCRIPT_LEX_CONV_F_NOTHING);
     }