Changeset 108493 in vbox for trunk/src/VBox/VMM/VMMAll/GICAll.cpp

Timestamp:

Mar 10, 2025 12:04:23 PM (6 weeks ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167881

Message:

VMM/GIC: bugref:10404 Bits.

File:

• trunk/src/VBox/VMM/VMMAll/GICAll.cpp (modified) (6 diffs)

trunk/src/VBox/VMM/VMMAll/GICAll.cpp

@@ -2306 +2306 @@
     {
         case GIC_DIST_REG_CTLR_OFF:
-            Assert(pGicDev->fAffRoutingEnabled);    /* We don't support GICv2 backwards compatibility, so ARE bit must be set. */
+            Assert(pGicDev->fAffRoutingEnabled);
             *puValue = (pGicDev->fIntrGroup0Enabled ? GIC_DIST_REG_CTRL_ENABLE_GRP0    : 0)
                      | (pGicDev->fIntrGroup1Enabled ? GIC_DIST_REG_CTRL_ENABLE_GRP1_NS : 0)
-                     | GIC_DIST_REG_CTRL_DS
-                     | (pGicDev->fAffRoutingEnabled ? GIC_DIST_REG_CTRL_ARE_S : 0);
+                     | GIC_DIST_REG_CTRL_DS         /* We don't support multiple security states. */
+                     | GIC_DIST_REG_CTRL_ARE_S;     /* We don't support GICv2 backwards compatibility, ARE is always enabled. */
             break;
         case GIC_DIST_REG_TYPER_OFF:
@@ -2319 +2319 @@
                      | GIC_DIST_REG_TYPER_NUM_PES_SET(0)      /* Affinity routing is always enabled, hence this MBZ. */
                      /*| GIC_DIST_REG_TYPER_NMI*/             /** @todo Support non-maskable interrupts */
-                     /*| GIC_DIST_REG_TYPER_SECURITY_EXTN */  /** @todo Support dual security states. */
+                     /*| GIC_DIST_REG_TYPER_SECURITY_EXTN*/   /** @todo Support dual security states. */
                      | (pGicDev->fMbi ? GIC_DIST_REG_TYPER_MBIS : 0)
-                     /*| GIC_DIST_REG_TYPER_LPIS */           /** @todo Support LPIs */
+                     /*| GIC_DIST_REG_TYPER_LPIS*/            /** @todo Support LPIs */
                      | (pGicDev->fRangeSel ? GIC_DIST_REG_TYPER_RSS : 0)
                      | GIC_DIST_REG_TYPER_IDBITS_SET(16)      /* We only support 16-bit interrupt IDs. */
@@ -2383 +2383 @@
         }
 #endif
-        case GIC_DIST_REG_ITARGETSRn_OFF_START: /* Only 32 lines for now. */
+        case GIC_DIST_REG_ITARGETSRn_OFF_START:
             AssertReleaseFailed();
             break;
@@ -2391 +2391 @@
             break;
 #endif
-        case GIC_DIST_REG_IGRPMODRn_OFF_START: /* Only 32 lines for now. */
-            AssertReleaseFailed();
-            break;
-        case GIC_DIST_REG_NSACRn_OFF_START: /* Only 32 lines for now. */
+        case GIC_DIST_REG_IGRPMODRn_OFF_START:
+            AssertReleaseFailed();
+            break;
+        case GIC_DIST_REG_NSACRn_OFF_START:
             AssertReleaseFailed();
             break;
@@ -2726 +2726 @@
         }
 #endif
-        case GIC_DIST_REG_ITARGETSRn_OFF_START: /* Only 32 lines for now. */
+        case GIC_DIST_REG_ITARGETSRn_OFF_START:
             AssertReleaseFailed();
             break;
@@ -2737 +2737 @@
             break;
 #endif
-        case GIC_DIST_REG_IGRPMODRn_OFF_START: /* Only 32 lines for now. */
-            AssertReleaseFailed();
-            break;
-        case GIC_DIST_REG_NSACRn_OFF_START: /* Only 32 lines for now. */
+        case GIC_DIST_REG_IGRPMODRn_OFF_START:
+            AssertReleaseFailed();
+            break;
+        case GIC_DIST_REG_NSACRn_OFF_START:
             AssertReleaseFailed();
             break;