Changeset 109165 in vbox for trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/gallium/Svga.h

Timestamp:

May 5, 2025 6:17:33 PM (4 days ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

168723

Message:

WDDM: Miniport: unify handling of guest backing memory for surfaces, object tables, etc. bugref:10885

File:

• trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/gallium/Svga.h (modified) (8 diffs)

trunk/src/VBox/Additions/WINNT/Graphics/Video/mp/wddm/gallium/Svga.h

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2016-2024 Oracle and/or its affiliates.
+ * Copyright (C) 2016-2025 Oracle and/or its affiliates.
  *
  * This file is part of VirtualBox base platform packages, as
@@ -34 +34 @@
 #include "VBoxMPGaUtils.h"
 
+#include <iprt/asm.h>
 #include <iprt/assert.h>
 #include <iprt/avl.h>
@@ -164 +165 @@
 typedef struct VMSVGAGBO
 {
+    int32_t volatile            cRefs;                      /* Reference count */
+    struct
+    {
+        uint32_t                fMdl : 1;
+        uint32_t                reserved : 31;
+    }                           flags;
     uint32_t                    cbGbo;                      /* Size of gbo in bytes. */
     uint32_t                    cPTPages;                   /* How many pages are required to hold PPN64 page table. */
     SVGAMobFormat               enmMobFormat;               /* Page table format. */
+    union                                                   /* Backing memory. */
+    {
+        PMDL                    pMdl;
+        RTR0MEMOBJ              hMemObj;
+    };
     PPN64                       base;                       /* Page which contains the page table. */
     RTR0MEMOBJ                  hMemObjPT;                  /* Page table pages. */
@@ -174 +186 @@
 #define SVGA3D_MAX_MOBS (SVGA3D_MAX_CONTEXT_IDS + SVGA3D_MAX_CONTEXT_IDS + SVGA3D_MAX_SURFACE_IDS)
 
-/* Memory OBject: a gbo with an id, possibly bound to an allocation. */
-typedef struct VMSVGAMOB
-{
-    AVLU32NODECORE              core;                       /* AVL entry. Key is mobid, allocated by the miniport. */
-    HANDLE                      hAllocation;                /* Allocation which is bound to the mob. */
-    VMSVGAGBO                   gbo;                        /* Gbo for this mob. */
-    RTR0MEMOBJ                  hMemObj;                    /* The guest memory if allocated by miniport. */
-    uint32_t                    u64MobFence;                /* Free by the guest when the host reports this fence value. */
-    RTLISTNODE                  node;                       /* VBOXWDDM_EXT_VMSVGA::listMobDeferredDestruction */
-} VMSVGAMOB, *PVMSVGAMOB;
-
-#define VMSVGAMOB_ID(a_pMob) ((a_pMob)->core.Key)
-
 typedef struct VMSVGAOT
 {
-    VMSVGAGBO                   gbo;
-    RTR0MEMOBJ                  hMemObj;
+    PVMSVGAGBO                  pGbo;
     uint32_t                    cEntries;                   /* How many objects can be stored in the OTable. */
 } VMSVGAOT, *PVMSVGAOT;
@@ -213 +211 @@
     uint32_t u32GmrMaxPages;  /** SVGA_REG_GMRS_MAX_PAGES */
     uint32_t u32MemorySize;   /** SVGA_REG_MEMORY_SIZE */
+    uint32_t u32MaxMobSize;   /** SVGA_REG_MOB_MAX_SIZE */
     uint32_t u32MaxTextureWidth;  /** SVGA3D_DEVCAP_MAX_TEXTURE_WIDTH */
     uint32_t u32MaxTextureHeight; /** SVGA3D_DEVCAP_MAX_TEXTURE_HEIGHT */
@@ -261 +260 @@
     VMSVGAOT aOT[SVGA_OTABLE_DX_MAX];
 
-    PVMSVGAMOB pMiniportMob; /* Used by miniport to communicate with the device. */
+    /* Used by miniport to communicate with the device. */
+    PVMSVGAGBO pMiniportGbo;
+    SVGAMobId mobidMiniport;
     struct VMSVGAMINIPORTMOB volatile *pMiniportMobData; /* Pointer to the miniport mob content. */
 
     uint64_t volatile u64MobFence;
     RTLISTANCHOR listMobDeferredDestruction; /* Mob to be deleted after. */
+    int32_t volatile cQueuedWorkItems;
 
 #ifdef DEBUG
     /* Statistics. */
+    uint32_t volatile cAllocatedGbos;
     uint32_t volatile cAllocatedMobs;
-    uint32_t volatile cAllocatedMobPages;
     uint32_t volatile cAllocatedGmrs;
     uint32_t volatile cAllocatedGmrPages;
@@ -303 +305 @@
 typedef struct VMSVGACOT
 {
-    PVMSVGAMOB              pMob;                       /* COTable mob. */
+    SVGAMobId               mobid;                      /* COTable mob. */
     uint32_t                cEntries;                   /* How many objects can be stored in the COTable. */
 } VMSVGACOT, *PVMSVGACOT;
@@ -644 +646 @@
 #endif
 
-NTSTATUS SvgaGboInit(VMSVGAGBO *pGbo, uint32_t cPages);
-void SvgaGboFree(VMSVGAGBO *pGbo);
-NTSTATUS SvgaGboFillPageTableForMDL(PVMSVGAGBO pGbo,
-                                    PMDL pMdl,
-                                    uint32_t MdlOffset);
-NTSTATUS SvgaGboFillPageTableForMemObj(PVMSVGAGBO pGbo,
-                                       RTR0MEMOBJ hMemObj);
+NTSTATUS SvgaGboCreate(VBOXWDDM_EXT_VMSVGA *pSvga,
+                       PVMSVGAGBO *ppGbo,
+                       uint32_t cbGbo,
+                       const char *pszTag);
+NTSTATUS SvgaGboCreateForMdl(VBOXWDDM_EXT_VMSVGA *pSvga,
+                             PVMSVGAGBO *ppGbo,
+                             SIZE_T NumberOfPages,
+                             PMDL pMdl,
+                             ULONG MdlOffset);
+void SvgaGboFree(VBOXWDDM_EXT_VMSVGA *pSvga,
+                 VMSVGAGBO *pGbo);
+
+DECLINLINE(void) SvgaGboReference(PVMSVGAGBO pGbo)
+{
+    if (pGbo)
+    {
+        int32_t const c = ASMAtomicIncS32(&pGbo->cRefs);
+        Assert(c > 0); RT_NOREF(c);
+    }
+}
+
+DECLINLINE(void) SvgaGboUnreference(VBOXWDDM_EXT_VMSVGA *pSvga,
+                                    PVMSVGAGBO *ppGbo)
+{
+    if (*ppGbo)
+    {
+        int32_t const c = ASMAtomicDecS32(&(*ppGbo)->cRefs);
+        Assert(c >= 0);
+        if (c == 0)
+            SvgaGboFree(pSvga, *ppGbo);
+        *ppGbo = NULL;
+    }
+}
 
 void SvgaMobFree(VBOXWDDM_EXT_VMSVGA *pSvga,
-                 PVMSVGAMOB pMob);
-PVMSVGAMOB SvgaMobQuery(VBOXWDDM_EXT_VMSVGA *pSvga,
-                        uint32_t mobid);
-NTSTATUS SvgaMobCreate(VBOXWDDM_EXT_VMSVGA *pSvga,
-                       PVMSVGAMOB *ppMob,
-                       uint32_t cMobPages,
-                       HANDLE hAllocation);
-NTSTATUS SvgaMobSetMemObj(PVMSVGAMOB pMob,
-                          RTR0MEMOBJ hMemObj);
+                 SVGAMobId *pMobid);
+NTSTATUS SvgaMobAlloc(VBOXWDDM_EXT_VMSVGA *pSvga,
+                      SVGAMobId *pMobid,
+                      PVMSVGAGBO pGbo);
+void *SvgaMobAddress(VBOXWDDM_EXT_VMSVGA *pSvga,
+                     SVGAMobId mobid);
+NTSTATUS SvgaMobDefine(VBOXWDDM_EXT_VMSVGA *pSvga,
+                       SVGAMobId mobid,
+                       void *pvCmd,
+                       uint32_t cbReserved,
+                       uint32_t *pcbCmd);
 NTSTATUS SvgaMobDestroy(VBOXWDDM_EXT_VMSVGA *pSvga,
-                        PVMSVGAMOB pMob,
+                        SVGAMobId mobid,
                         void *pvCmd,
                         uint32_t cbReserved,
                         uint32_t *pcbCmd);
+void SvgaDeferredMobDestruction(PVBOXWDDM_EXT_VMSVGA pSvga);
 
 NTSTATUS SvgaCOTNotifyId(VBOXWDDM_EXT_VMSVGA *pSvga,